Bug 181013 - [PATCH] graphics/ufraw build failure after glib update
Summary: [PATCH] graphics/ufraw build failure after glib update
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Boris Samorodov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-04 12:10 UTC by me
Modified: 2013-08-11 15:50 UTC (History)
0 users

See Also:


Attachments
file.diff (345 bytes, patch)
2013-08-04 12:10 UTC, me
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description me 2013-08-04 12:10:00 UTC
After the latest glib update, graphics/ufraw does not build, because ${LOCALBASE}/share/glib-2.0/gettext/mkinstalldirs does not exist anymore.

On my system, I found the same version here: ${LOCALBASE}/share/automake-1.14/mkinstalldirs

Since automake-1.14 is not a build dependency of graphics/ufraw, but icu-50.1.2 is, I tried this version: ${LOCALBASE}/share/icu/50.1.2/mkinstalldirs

${LOCALBASE}/share/icu/50.1.2/mkinstalldirs is almost identical to ${LOCALBASE}/share/automake-1.4/mkinstalldirs, which comes with automake-1.4.6_6 and which seems to be enough for graphics/ufraw to build.

Of course, these path' are all very version dependent.

Fix: Use some different version of mkinstalldirs, for example the one from icu-50.1.2, which already is a build dependency.

Patch attached with submission follows:
How-To-Repeat: make -C /usr/ports/graphics/ufraw/
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-08-04 12:10:10 UTC
Maintainer of graphics/ufraw,

Please note that PR ports/181013 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/181013

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-08-04 12:10:11 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Rodrigo OSORIO 2013-08-06 20:23:03 UTC
Jan,

Thanks for your submition, the patch looks ok to me.

AFAIK, no portrevision bump is required so,
it can be commited as is.

regards
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2013-08-07 03:48:21 UTC
State Changed
From-To: feedback->open

Maintainer approved.
Comment 5 Boris Samorodov freebsd_committer freebsd_triage 2013-08-11 14:44:28 UTC
Responsible Changed
From-To: freebsd-ports-bugs->bsam

Take.
Comment 6 dfilter service freebsd_committer freebsd_triage 2013-08-11 15:46:11 UTC
Author: bsam
Date: Sun Aug 11 14:45:59 2013
New Revision: 324591
URL: http://svnweb.freebsd.org/changeset/ports/324591

Log:
  Fix build after recent glib update.
  
  PR:		ports/181013
  Submitted by:	Jan Henrik Sylvester <me@janh.de>
  Approved by:	rodrigo@bebik.net (maintainer)

Modified:
  head/graphics/ufraw/Makefile

Modified: head/graphics/ufraw/Makefile
==============================================================================
--- head/graphics/ufraw/Makefile	Sun Aug 11 14:11:33 2013	(r324590)
+++ head/graphics/ufraw/Makefile	Sun Aug 11 14:45:59 2013	(r324591)
@@ -104,7 +104,7 @@ post-patch:
 .endfor
 
 pre-build:
-	@${INSTALL_SCRIPT} ${LOCALBASE}/share/glib-2.0/gettext/mkinstalldirs \
+	@${INSTALL_SCRIPT} ${LOCALBASE}/share/icu/50.1.2/mkinstalldirs \
 		${WRKSRC}
 
 post-install:
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 7 Boris Samorodov freebsd_committer freebsd_triage 2013-08-11 15:46:32 UTC
State Changed
From-To: open->closed

Committed, thanks!