- Conver to new perl5 framework. - Remove duplication of 'USES=gettext'.
Class Changed From-To: sw-bug->maintainer-update Fix category (submitter is maintainer) (via the GNATS Auto Assign Tool)
Author: az Date: Tue Aug 20 11:48:33 2013 New Revision: 325041 URL: http://svnweb.freebsd.org/changeset/ports/325041 Log: - Conver to new perl5 framework. - Remove duplication of 'USES=gettext'. PR: ports/181205 Submitted by: Yasuhiro KIMURA <yasu@utahime.org> (maintainer) Modified: head/japanese/eb/Makefile Modified: head/japanese/eb/Makefile ============================================================================== --- head/japanese/eb/Makefile Tue Aug 20 11:43:44 2013 (r325040) +++ head/japanese/eb/Makefile Tue Aug 20 11:48:33 2013 (r325041) @@ -65,8 +65,7 @@ PORTDOCS= eb-01.html eb-02.html eb-03.ht USE_AUTOTOOLS= libtool USE_BZIP2= yes -USES= gettext -USE_PERL5= yes +USES= gettext perl5 GNU_CONFIGURE= yes USE_LDCONFIG= yes CONFIGURE_ARGS= --with-pkgdocdir=${DOCSDIR} @@ -78,7 +77,6 @@ APPENDIXDIR= ${DATADIR}/appendix .include <bsd.port.options.mk> .if ${PORT_OPTIONS:MNLS} -USES+= gettext CONFIGURE_ARGS+= --enable-nls \ --with-gettext-includes=${LOCALBASE}/include \ --with-gettext-libraries=${LOCALBASE}/lib \ _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!
State Changed From-To: closed->open I believe the submitted patch could be incorrect and I intend to test it further.
Responsible Changed From-To: freebsd-ports-bugs->marino It could be a mistake to move USE+=gettext out of NLS option because it's likely that gettext is only required to support NLS. Once that it is confirmed that this port builds without gettext when NLS is off, the USES will be fixed. (or otherwise the PR will be closed again)
Author: marino Date: Fri Aug 23 00:06:37 2013 New Revision: 325246 URL: http://svnweb.freebsd.org/changeset/ports/325246 Log: japanese/eb: Make gettext dependency a condition of NLS PORTREVISION bumped to reset dependencies for folks that don't use NLS. PR: 181205 Submitted by: az Reviewed by: jgh, marino Approved by: bapt/culot (mentors, implicit) Modified: head/japanese/eb/Makefile Modified: head/japanese/eb/Makefile ============================================================================== --- head/japanese/eb/Makefile Thu Aug 22 23:55:13 2013 (r325245) +++ head/japanese/eb/Makefile Fri Aug 23 00:06:37 2013 (r325246) @@ -3,6 +3,7 @@ PORTNAME= eb PORTVERSION= 4.4.3 +PORTREVISION= 1 CATEGORIES= japanese MASTER_SITES= ftp://ftp.sra.co.jp/pub/misc/eb/ \ ftp://ftp.sra.co.jp/pub/misc/eb/old/eb-${PORTVERSION:C/^([0-9]+)\.([0-9]+).*/\1.\2/}/ @@ -65,7 +66,7 @@ PORTDOCS= eb-01.html eb-02.html eb-03.ht USE_AUTOTOOLS= libtool USE_BZIP2= yes -USES= gettext perl5 +USES= perl5 GNU_CONFIGURE= yes USE_LDCONFIG= yes CONFIGURE_ARGS= --with-pkgdocdir=${DOCSDIR} @@ -77,6 +78,7 @@ APPENDIXDIR= ${DATADIR}/appendix .include <bsd.port.options.mk> .if ${PORT_OPTIONS:MNLS} +USES+= gettext CONFIGURE_ARGS+= --enable-nls \ --with-gettext-includes=${LOCALBASE}/include \ --with-gettext-libraries=${LOCALBASE}/lib \ @@ -84,6 +86,7 @@ CONFIGURE_ARGS+= --enable-nls \ --with-iconv-libraries=${LOCALBASE}/lib PLIST_SUB= NLS="" .else +CONFIGURE_ARGS+= --disable-nls PLIST_SUB= NLS="@comment " .endif _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed It was confirmed that gettext should be a conditional dedependency based on the NLS option. The makefile was modified and the portrevision augmented.