The port does not build with clang: ----- fluxconf.c:244:13: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] _("Now you must restart fluxbox (using the root menu, not killing X). Don't forget to press \"Let fluxbox change the conf\" before exiting.")); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/defines.h:4:19: note: expanded from macro '_' #define _(String) g_locale_to_utf8(gettext (String),strlen(gettext(String)),0,0,0) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. ----- Fix: . fix build with clang (CFLAGS+=-Wno-error); . add LICENSE (GPLv2), bump PORTREVISION; . trim headers; . reword COMMENT; . NOPORTDOCS -> PORT_OPTIONS:MDOCS; . use one line install instead of an if loop. Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->miwi miwi@ wants this submitter's PRs (via the GNATS Auto Assign Tool)
Maintainer of x11-wm/fluxconf, Please note that PR ports/181619 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/181619 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Responsible Changed From-To: miwi->bsam Take my PR back. ;-)
Author: bsam Date: Wed Sep 11 15:53:29 2013 New Revision: 326989 URL: http://svnweb.freebsd.org/changeset/ports/326989 Log: . fix build with clang (CFLAGS+=-Wno-error); . add LICENSE (GPLv2), bump PORTREVISION; . trim headers; . reword COMMENT; . NOPORTDOCS -> PORT_OPTIONS:MDOCS; . use one line install instead of an if loop. PR: ports/181619 Submitted by: bsam (me) Reviewed by: alfredoj69@gmail.com (maintainer timeout, 2 weeks) Modified: head/x11-wm/fluxconf/Makefile Modified: head/x11-wm/fluxconf/Makefile ============================================================================== --- head/x11-wm/fluxconf/Makefile Wed Sep 11 15:21:32 2013 (r326988) +++ head/x11-wm/fluxconf/Makefile Wed Sep 11 15:53:29 2013 (r326989) @@ -3,28 +3,31 @@ PORTNAME= fluxconf PORTVERSION= 0.9.9 -PORTREVISION= 7 +PORTREVISION= 8 CATEGORIES= x11-wm MASTER_SITES= http://devaux.fabien.free.fr/flux/ MAINTAINER= alfredoj69@gmail.com -COMMENT= A configuration program for the fluxbox window manager +COMMENT= Fluxbox window manager configuration program USES= pkgconfig USE_GNOME= gtk20 GNU_CONFIGURE= yes +CFLAGS+= -Wno-error PORTDOCS= fluxconf.png fluxkeys.png fluxmenu.png index.html PLIST_FILES= bin/fluxbare bin/fluxconf bin/fluxkeys bin/fluxmenu \ share/locale/fi/LC_MESSAGES/fluxconf.mo \ share/locale/fr/LC_MESSAGES/fluxconf.mo +OPTIONS_DEFINE= DOCS + +.include <bsd.port.options.mk> + post-install: -.if !defined(NOPORTDOCS) +.if ${PORT_OPTIONS:MDOCS} @${MKDIR} ${DOCSDIR} -.for file in ${PORTDOCS} - ${INSTALL_DATA} ${WRKSRC}/docs/${file} ${DOCSDIR} -.endfor + ${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/docs/,} ${DOCSDIR} .endif .include <bsd.port.mk> _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed, thanks! ;-)