Bug 181620 - sysutils/logstash start script variables typo
Summary: sysutils/logstash start script variables typo
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-28 16:20 UTC by Vick Khera
Modified: 2013-09-16 18:50 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vick Khera 2013-08-28 16:20:00 UTC
	

the sysutils/logstash port installs a start script. in that script the comment
block at the top says to use the variable logstash_logging to turn on logging.
This is a typo, the correct variable name used later in the script is logstash_log.

Fix: 

Change reference to logstash_logging to logstash_log in the comment block.
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2013-08-28 16:31:16 UTC
Responsible Changed
From-To: freebsd-ports-bugs->madpilot

I'll take it.
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2013-08-28 16:36:11 UTC
Hi Regis,

This PR has been filed regarding logstash. It's a simple typo in the 
comment, can you approve the change so I can commit it?

http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/181620

Thanks.

-- 
Guido Falsi <madpilot@FreeBSD.org>
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2013-08-28 16:38:51 UTC
Class Changed
From-To: doc-bug->change-request

Change class
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2013-08-28 16:39:04 UTC
State Changed
From-To: open->feedback

Ask for maintainer approval.
Comment 5 dfilter service freebsd_committer freebsd_triage 2013-09-16 18:42:57 UTC
Author: madpilot
Date: Mon Sep 16 17:42:50 2013
New Revision: 327428
URL: http://svnweb.freebsd.org/changeset/ports/327428

Log:
  Make comment and actual variable names the same.
  
  PR:		ports/181620
  Submitted by:	Vivek Khera <vivek@khera.org>
  Approved by:	Maintainer timeout

Modified:
  head/sysutils/logstash/files/logstash.in   (contents, props changed)

Modified: head/sysutils/logstash/files/logstash.in
==============================================================================
--- head/sysutils/logstash/files/logstash.in	Mon Sep 16 17:39:26 2013	(r327427)
+++ head/sysutils/logstash/files/logstash.in	Mon Sep 16 17:42:50 2013	(r327428)
@@ -20,7 +20,7 @@
 #     "web": Starts logstash as a web ui
 #     "agent": Justs works as a log shipper 
 #
-# logstash_logging (bool):
+# logstash_log (bool):
 #   Set to "NO" by default.
 #   Set it to "YES" to enable logstash logging to file
 #   Default output to /var/log/logstash.log
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 Guido Falsi freebsd_committer freebsd_triage 2013-09-16 18:42:59 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!