Bug 181708 - fix databases/sqlbuddy build problem caused by the deletion of php5-sqlite
Summary: fix databases/sqlbuddy build problem caused by the deletion of php5-sqlite
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-31 16:00 UTC by horus.li
Modified: 2014-04-21 22:00 UTC (History)
0 users

See Also:


Attachments
file.diff (269 bytes, patch)
2013-08-31 16:00 UTC, horus.li
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description horus.li 2013-08-31 16:00:01 UTC
With deletion of php5-sqlite, build process of databases/sqlbuddy cannot finish successfully. (Failed with 'Unknown extension sqlite for PHP 5.') The best step to take is to keep PHP at version 5.3.x and use php53-sqlite. Here the patch goes.

Fix: patch attached.

Patch attached with submission follows:
How-To-Repeat: make -C /usr/ports/databases/sqlbuddy all
Comment 1 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2013-09-01 14:02:46 UTC
Responsible Changed
From-To: freebsd-ports-bugs->itetcu

I'll take it.
Comment 2 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2013-09-01 14:31:33 UTC
>  COMMENT=	Web based MySQL administration with a set of PHP scripts 
> +DEFAULT_PHP_VER=53


OPTIONS_DEFINE= MYSQL SQLITE
OPTIONS_DEFAULT=        SQLITE

Umm, if it's a "MySQL administration" thingy why is SQLite the default?
Especially since it doesn't seems to be well supported by upstream
(from a quick look at their forums).

-- 
IOnut - Un^d^dregistered ;) FreeBSD "user"
  "Intellectual Property" is   nowhere near as valuable   as "Intellect"
FreeBSD committer -> itetcu@FreeBSD.org, PGP Key ID 29597D20
Comment 3 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2013-09-01 14:46:43 UTC
State Changed
From-To: open->feedback

Asked maintainer a question.
Comment 4 Thomas Abthorpe freebsd_committer freebsd_triage 2014-04-08 16:01:44 UTC
Responsible Changed
From-To: itetcu->freebsd-ports-bugs

Reassign to the heap
Comment 5 dfilter service freebsd_committer freebsd_triage 2014-04-21 20:02:21 UTC
Author: marino
Date: Mon Apr 21 19:02:18 2014
New Revision: 351703
URL: http://svnweb.freebsd.org/changeset/ports/351703
QAT: https://qat.redports.org/buildarchive/r351703/

Log:
  databases/sqlbuddy: Unbreak and stage
  
  The maintainer actually provided a PR to address the breakage long
  before it was marked broken.  itetcu asked him a valid question: Why
  is sqlbuddy defaulting to sqlite when it is primarily a mysql tool?
  The question was never answered and the PR got thrown back on the heap.
  
  The SQLite component is what is missing.  Let's remove sqlite as an
  option to restore the build and stage while here.  It's bumped because
  of the change in default options.
  
  PR:		ports/181708
  submitted by:	maintainer (Chenguang Li)
  modified by:	marino
  MFH:		2014Q2

Modified:
  head/databases/sqlbuddy/Makefile

Modified: head/databases/sqlbuddy/Makefile
==============================================================================
--- head/databases/sqlbuddy/Makefile	Mon Apr 21 18:46:03 2014	(r351702)
+++ head/databases/sqlbuddy/Makefile	Mon Apr 21 19:02:18 2014	(r351703)
@@ -3,6 +3,7 @@
 
 PORTNAME=	sqlbuddy
 PORTVERSION=	1.3.3
+PORTREVISION=	1
 CATEGORIES=	databases www
 MASTER_SITES=	http://www.sqlbuddy.com/download/
 DISTNAME=	${PORTNAME}_1_3_3
@@ -10,35 +11,20 @@ DISTNAME=	${PORTNAME}_1_3_3
 MAINTAINER=	horus.li@gmail.com
 COMMENT=	Web based MySQL administration with a set of PHP scripts
 
-BROKEN=		Fails to check-sanity
-
 USES=		zip
 NO_BUILD=	yes
 
 WRKSRC=		${WRKDIR}/${PORTNAME}
 
-USE_PHP=	ctype pcre session
+USE_PHP=	ctype pcre session mysql
 WANT_PHP_WEB=	yes
 
-OPTIONS_DEFINE=	MYSQL SQLITE
-OPTIONS_DEFAULT=	SQLITE
-
 SUB_FILES=	pkg-message
 
-NO_STAGE=	yes
-.include <bsd.port.options.mk>
-
-.if ${PORT_OPTIONS:MMYSQL}
-USE_PHP+=	mysql
-.endif
-.if ${PORT_OPTIONS:MSQLITE}
-USE_PHP+=	sqlite
-.endif
-
 pre-everything::
 	@${ECHO_MSG} ""
 	@${ECHO_MSG} "NOTE:"
-	@${ECHO_MSG} "This port suppose you have already installed one or both of these databases supported, "
+	@${ECHO_MSG} "This port assumes you have already installed a mysql database, "
 	@${ECHO_MSG} "and you want to use SQL Buddy to manage the server."
 	@${ECHO_MSG} "If you are planning to install it/them on this machine later, "
 	@${ECHO_MSG} "you can find it/them at ${PORTSDIR}/databases."
@@ -47,9 +33,8 @@ pre-everything::
 do-install:
 	@${ECHO_MSG} ""
 	@${ECHO_MSG} "Installing SQL Buddy under ${WWWDIR}/"
-	@${MKDIR} ${WWWDIR}
-	@cd ${WRKSRC} && ${CP} -R * ${WWWDIR}
-	@${CHOWN} -R ${WWWOWN}:${WWWGRP} ${WWWDIR}
-	@${CAT} ${PKGMESSAGE}
+	@${MKDIR} ${STAGEDIR}${WWWDIR}
+	@cd ${WRKSRC} && ${CP} -R * ${STAGEDIR}${WWWDIR}
+	@${CHOWN} -R ${WWWOWN}:${WWWGRP} ${STAGEDIR}${WWWDIR}
 
 .include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 John Marino freebsd_committer freebsd_triage 2014-04-21 20:11:57 UTC
State Changed
From-To: feedback->closed

port builds again - but without sqlite as an option
Comment 7 dfilter service freebsd_committer freebsd_triage 2014-04-21 21:53:57 UTC
Author: marino
Date: Mon Apr 21 20:53:54 2014
New Revision: 351713
URL: http://svnweb.freebsd.org/changeset/ports/351713
QAT: https://qat.redports.org/buildarchive/r351713/

Log:
  MFH: r351703
  
  databases/sqlbuddy: Unbreak and stage
  
  The maintainer actually provided a PR to address the breakage long
  before it was marked broken.  itetcu asked him a valid question: Why
  is sqlbuddy defaulting to sqlite when it is primarily a mysql tool?
  The question was never answered and the PR got thrown back on the heap.
  
  The SQLite component is what is missing.  Let's remove sqlite as an
  option to restore the build and stage while here.  It's bumped because
  of the change in default options.
  
  PR:		ports/181708
  submitted by:	maintainer (Chenguang Li)
  modified by:	marino
  Approved by:	portmgr (antoine)

Modified:
  branches/2014Q2/databases/sqlbuddy/Makefile
Directory Properties:
  branches/2014Q2/   (props changed)

Modified: branches/2014Q2/databases/sqlbuddy/Makefile
==============================================================================
--- branches/2014Q2/databases/sqlbuddy/Makefile	Mon Apr 21 20:47:50 2014	(r351712)
+++ branches/2014Q2/databases/sqlbuddy/Makefile	Mon Apr 21 20:53:54 2014	(r351713)
@@ -3,6 +3,7 @@
 
 PORTNAME=	sqlbuddy
 PORTVERSION=	1.3.3
+PORTREVISION=	1
 CATEGORIES=	databases www
 MASTER_SITES=	http://www.sqlbuddy.com/download/
 DISTNAME=	${PORTNAME}_1_3_3
@@ -10,35 +11,20 @@ DISTNAME=	${PORTNAME}_1_3_3
 MAINTAINER=	horus.li@gmail.com
 COMMENT=	Web based MySQL administration with a set of PHP scripts
 
-BROKEN=		Fails to check-sanity
-
 USES=		zip
 NO_BUILD=	yes
 
 WRKSRC=		${WRKDIR}/${PORTNAME}
 
-USE_PHP=	ctype pcre session
+USE_PHP=	ctype pcre session mysql
 WANT_PHP_WEB=	yes
 
-OPTIONS_DEFINE=	MYSQL SQLITE
-OPTIONS_DEFAULT=	SQLITE
-
 SUB_FILES=	pkg-message
 
-NO_STAGE=	yes
-.include <bsd.port.options.mk>
-
-.if ${PORT_OPTIONS:MMYSQL}
-USE_PHP+=	mysql
-.endif
-.if ${PORT_OPTIONS:MSQLITE}
-USE_PHP+=	sqlite
-.endif
-
 pre-everything::
 	@${ECHO_MSG} ""
 	@${ECHO_MSG} "NOTE:"
-	@${ECHO_MSG} "This port suppose you have already installed one or both of these databases supported, "
+	@${ECHO_MSG} "This port assumes you have already installed a mysql database, "
 	@${ECHO_MSG} "and you want to use SQL Buddy to manage the server."
 	@${ECHO_MSG} "If you are planning to install it/them on this machine later, "
 	@${ECHO_MSG} "you can find it/them at ${PORTSDIR}/databases."
@@ -47,9 +33,8 @@ pre-everything::
 do-install:
 	@${ECHO_MSG} ""
 	@${ECHO_MSG} "Installing SQL Buddy under ${WWWDIR}/"
-	@${MKDIR} ${WWWDIR}
-	@cd ${WRKSRC} && ${CP} -R * ${WWWDIR}
-	@${CHOWN} -R ${WWWOWN}:${WWWGRP} ${WWWDIR}
-	@${CAT} ${PKGMESSAGE}
+	@${MKDIR} ${STAGEDIR}${WWWDIR}
+	@cd ${WRKSRC} && ${CP} -R * ${STAGEDIR}${WWWDIR}
+	@${CHOWN} -R ${WWWOWN}:${WWWGRP} ${STAGEDIR}${WWWDIR}
 
 .include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"