Bug 181736 - [stage] textproc/domc: simplify and unbreak on sparc64, amd64 (r324422 regression)
Summary: [stage] textproc/domc: simplify and unbreak on sparc64, amd64 (r324422 regres...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-02 00:10 UTC by Jan Beich
Modified: 2014-08-14 22:09 UTC (History)
1 user (show)

See Also:

Attachments
shared.diff (2.62 KB, patch)
2013-09-02 00:10 UTC, Jan Beich 		no flags Details | Diff
combined (6.26 KB, patch)
2014-08-13 03:59 UTC, Jan Beich 		no flags Details | Diff
poudriere testport log (9.3R i386) (12.77 KB, text/plain)
2014-08-13 04:00 UTC, Jan Beich 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2013-09-02 00:10:00 UTC 
The vendor Makefile uses same object files to build both static and
shared library. Before r324422 .c.a suffix rule contained a line to
clean up non-pic object files before building SONAME. This was broken
without removing ARNAME from `all' target. Which object files get
-fpic now depends on a race between .c.a and .c.o.

http://pb2.nyi.freebsd.org/bulk/nogcc-default/2013-08-30_22h26m46s/logs/errors/domc-0.8.0_1.log

How-To-Repeat: $ make MAKE_JOBS_NUMBER=1 |& fgrep pic
$ make MAKE_JOBS_NUMBER=16 |& fgrep pic
cc -O2 -pipe -I/usr/local/include -fno-strict-aliasing -Wall -W -g -DMSGNO -I/usr/local/include -L/usr/local/lib -fpic -c -o src/events.o src/events.c
cc -O2 -pipe -I/usr/local/include -fno-strict-aliasing -Wall -W -g -DMSGNO -I/usr/local/include -L/usr/local/lib -fpic -c -o src/node.o src/node.c
Comment 1 Alexey Dokuchaev freebsd_committer freebsd_triage 2013-09-02 13:56:38 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->danfe

Grab it; this is probably my fault. :(
Comment 2 Jan Beich freebsd_committer freebsd_triage 2014-08-13 03:57:05 UTC 
How long is danfe@ going to sit on this trivial PR? A regression is supposed to be fixed promptly, not worked around (in r326330) and then forgotten.

Resetting assignee for better visibility.
Comment 3 Jan Beich freebsd_committer freebsd_triage 2014-08-13 03:59:01 UTC 
Created attachment 145746 [details]
combined

More changes made:
- rebase
- stagify
- fix PREFIX!=LOCALBASE
- fix redefinition of wcwidth(3)
- simplify files/patch-Makefile
- define LICENSE
Comment 4 Jan Beich freebsd_committer freebsd_triage 2014-08-13 04:00:41 UTC 
Created attachment 145747 [details]
poudriere testport log (9.3R i386)
Comment 5 Jan Beich freebsd_committer freebsd_triage 2014-08-13 04:20:52 UTC 
$ portlint -C
WARN: Makefile: only one MASTER_SITE configured.  Consider adding additional mirrors.
WARN: Consider to set DEVELOPER=yes in /etc/make.conf
0 fatal errors and 2 warnings found.
Comment 6 John Marino freebsd_committer freebsd_triage 2014-08-13 05:58:56 UTC 
port has no maintainer, Jan provided updated patch and testlogs -- moving to patch-ready.
Comment 7 commit-hook freebsd_committer freebsd_triage 2014-08-14 22:02:11 UTC 
A commit references this bug:

Author: marino
Date: Thu Aug 14 20:57:31 UTC 2014
New revision: 364867
URL: http://svnweb.freebsd.org/changeset/ports/364867

Log:
  Stage textproc/domc and unbreak on sparc64, amd64

  PR:		181736
  Submitted by:	Jan Beich

Changes:
  head/textproc/domc/Makefile
  head/textproc/domc/files/patch-Makefile
  head/textproc/domc/files/patch-src_defines.h
  head/textproc/domc/files/patch-src_domc.h
  head/textproc/domc/pkg-plist
Comment 8 John Marino freebsd_committer freebsd_triage 2014-08-14 22:09:12 UTC 
thanks!