Bug 181910 - [maintainer][patch] www/uzbl fix missing dependency on pkgconfig
Summary: [maintainer][patch] www/uzbl fix missing dependency on pkgconfig
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: William Grzybowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-07 14:10 UTC by Klaus Aehlig
Modified: 2013-09-07 17:00 UTC (History)
0 users

See Also:

Attachments
uzbl.patch (881 bytes, patch)
2013-09-07 14:10 UTC, Klaus Aehlig 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Klaus Aehlig 2013-09-07 14:10:00 UTC 
	www/uzbl build-depends on pkg-config, but the dependency wasn't explicitly
	declared. Apparaently, in the past, it was pulled in indirectly, but this
	seems to have changed. This leads to a build error, see

	http://www.linta.de/~aehlig/download/uucp/tinderboxlogs/uzbl-0.0.0.2012.05.14_1.log.orig

	Fix this by adding pkgconfig to USES. Do not bump PORTREVISION,
	as installations that built sucessfully are not affected. While
	there, convert header to new style and fix a lint error (2 consecutive
	empty lines).

	This fixes the build, see

	http://www.linta.de/~aehlig/download/uucp/tinderboxlogs/uzbl-0.0.0.2012.05.14_1.log

Fix: Apply the following patch.
How-To-Repeat: 	Try a tinderbox build of www/uzbl on an up-to-date system.
Comment 1 William Grzybowski freebsd_committer freebsd_triage 2013-09-07 14:38:03 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->wg

I'll take it.
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-09-07 16:50:07 UTC 
Author: wg
Date: Sat Sep  7 15:49:54 2013
New Revision: 326643
URL: http://svnweb.freebsd.org/changeset/ports/326643

Log:
  www/uzbl: missing pkgconfig dependency
  
  - Add missing pkgconfig [1]
  - Trim Makefile header [1]
  - USES gmake pygtk2
  - Convert lib depends to new syntax
  - Python 2.5 is no longer supported
  - Add DOCS option
  - NOPORTDOCS -> PORT_OPTIONS:MDOCS
  
  PR:		ports/181910 [1]
  Submitted by:	Klaus Aehlig <aehlig linta.de> (maintainer)

Modified:
  head/www/uzbl/Makefile

Modified: head/www/uzbl/Makefile
==============================================================================
--- head/www/uzbl/Makefile	Sat Sep  7 15:45:23 2013	(r326642)
+++ head/www/uzbl/Makefile	Sat Sep  7 15:49:54 2013	(r326643)
@@ -1,13 +1,9 @@
-# Ports collection makefile for:	uzbl
-# Date created:				2009/12/14
-# Whom:					aehlig@linta.de
-#
+# Created by: Klaus Aehlig <aehlig@linta.de>
 # $FreeBSD$
-#
 
 PORTNAME=	uzbl
 DISTVERSION=	0.0.0.${GITDATE}
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	www
 MASTER_SITES=	http://www.linta.de/distfiles/
 
@@ -17,23 +13,25 @@ COMMENT=	Web interface tools which adher
 LICENSE=	GPLv3
 LICENSE_FILE=	${WRKSRC}/LICENSE
 
-LIB_DEPENDS=	webkitgtk-1.0:${PORTSDIR}/www/webkit-gtk2
+LIB_DEPENDS=	libwebkitgtk-1.0.so:${PORTSDIR}/www/webkit-gtk2
 RUN_DEPENDS=	socat:${PORTSDIR}/net/socat \
-		dmenu:${PORTSDIR}/x11/dmenu \
-		${PYTHON_PKGNAMEPREFIX}gtk>=2:${PORTSDIR}/x11-toolkits/py-gtk2
+		dmenu:${PORTSDIR}/x11/dmenu
 
-USE_GNOME=	gtk20
+USES=		gmake pkgconfig
+USE_GNOME=	gtk20 pygtk2
 USE_LDCONFIG=	yes
-USE_GMAKE=	yes
-USE_PYTHON=	2.5-2.7
+USE_PYTHON=	-2.7
 
 GITDATE=	2012.05.14
 GITVERSION=	228bc38
 
 WRKSRC=		${WRKDIR}/Dieterbe-uzbl-${GITVERSION}
 
+OPTIONS_DEFINE=	DOCS
 
-.if !defined(NOPORTDOCS)
+.include <bsd.port.options.mk>
+
+.if ${PORT_OPTIONS:MDOCS}
 PORTDOCS=	AUTHORS README COMMUNITY CONTRIBUTING FAQ INSTALL TODO config-syntax \
 		multiple-instances-management performance url-editing config.h vim
 .endif
@@ -64,8 +62,8 @@ do-install:
 .for f in uzbl-event-manager uzbl-browser uzbl-tabbed
 	${INSTALL_SCRIPT} ${WRKSRC}/bin/${f} ${PREFIX}/bin
 .endfor
-.if !defined(NOPORTDOCS)
-	${MKDIR} ${DOCSDIR}
+.if ${PORT_OPTIONS:MDOCS}
+	@${MKDIR} ${DOCSDIR}
 	${INSTALL_DATA} ${WRKSRC}/src/config.h ${DOCSDIR}
 .for f in COMMUNITY CONTRIBUTING FAQ INSTALL TODO config-syntax \
 		multiple-instances-management performance url-editing
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 William Grzybowski freebsd_committer freebsd_triage 2013-09-07 16:50:14 UTC 
State Changed
From-To: open->closed

Committed. Thanks!