Bug 182005 - graphics/libfpx broken
Summary: graphics/libfpx broken
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Mikhail Teterin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-11 02:20 UTC by Takeshi Taguchi
Modified: 2013-09-12 00:07 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Takeshi Taguchi 2013-09-11 02:20:00 UTC 
graphics/libfpx is broken now.
here is a log.

# make
===>   libfpx-1.3.1.2 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by libfpx-1.3.1.2 for building
===>  Extracting for libfpx-1.3.1.2
=> SHA256 Checksum OK for libfpx-1.3.1-2.tar.xz.
===>  Patching for libfpx-1.3.1.2
===>  Applying FreeBSD patches for libfpx-1.3.1.2
/usr/bin/sed -i '' -e '/^#include "fpxlib-config.h"/d'   /usr/ports/graphics/libfpx/work/libfpx-1.3.1-2/basics/filename.cpp      /usr/ports/graphics/libfpx/work/libfpx-1.3.1-2/oless/h/owchar.h         /usr/ports/graphics/libfpx/work/libfpx-1.3.1-2/ole/gen_guid.cpp         /usr/ports/graphics/libfpx/work/libfpx-1.3.1-2/fpxlib.h
===>  Configuring for libfpx-1.3.1.2
===>   FreeBSD 10 autotools fix applied to /usr/ports/graphics/libfpx/work/libfpx-1.3.1-2/configure
===>   FreeBSD 10 autotools fix applied to /usr/ports/graphics/libfpx/work/libfpx-1.3.1-2/aclocal.m4
===>   FreeBSD 10 autotools fix applied to /usr/ports/graphics/libfpx/work/libfpx-1.3.1-2/m4/libtool.m4
===>  Building for libfpx-1.3.1.2
--- objwarn ---
.. snip ....
--- olestats.So ---
c++ -fpic -DPIC  -O2 -pipe -DHAVE_WCHAR_H -DHAVE_DLFCN_H -DHAVE_SYS_TIME_H -DHAVE_SYS_PARAM_H -DHAVE_SYS_MOUNT_H -Qunused-arguments -fstack-protector -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wpointer-arith -Wno-uninitialized -Wno-empty-body -Wno-string-plus-int -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function -Wno-conversion -fno-rtti -fno-exceptions -fno-strict-aliasing -DHAVE_WCHAR_H -DHAVE_DLFCN_H -DHAVE_SYS_TIME_H -DHAVE_SYS_PARAM_H -DHAVE_SYS_MOUNT_H -I/usr/ports/graphics/libfpx/work/libfpx-1.3.1-2/oless/h -I/usr/ports/graphics/libfpx/work/libfpx-1.3.1-2/jpeg -I/usr/ports/graphics/libfpx/work/libfpx-1.3.1-2/ole -I/usr/ports/graphics/libfpx/work/libfpx-1.3.1-2/basics -I/usr/ports/graphics/libfpx/work/libfpx-1.3.1-2/ri_image -I/usr/ports/graphics/libfpx/work/libfpx-1.3.1-2/oless -I/usr/ports/graphics/libfpx/work/libfpx-1.3.1-2/fpx -I/usr/ports/graphics/libfpx/work/libfpx-1.3.1-2/. -I/usr/local/include -D_UNIX -Wno-c++11-exte
 nsions -c /usr/ports/graphics/libfpx/work/libfpx-1.3.1-2/ole/olestats.cpp -o olestats.So
In file included from /usr/ports/graphics/libfpx/work/libfpx-1.3.1-2/ole/olestats.cpp:40:
In file included from /usr/ports/graphics/libfpx/work/libfpx-1.3.1-2/ole/olestorg.h:25:
In file included from /usr/include/c++/v1/fstream:169:
In file included from /usr/include/c++/v1/ostream:130:
In file included from /usr/include/c++/v1/ios:216:
In file included from /usr/include/c++/v1/__locale:15:
In file included from /usr/include/c++/v1/string:433:
/usr/include/c++/v1/cwchar:180:106: error: cannot initialize a parameter of type 'const WCHAR *' (aka 'const unsigned short *') with an lvalue of type 'const wchar_t *'
inline _LIBCPP_INLINE_VISIBILITY const wchar_t* wcschr(const wchar_t* __s, wchar_t __c) {return ::wcschr(__s, __c);}
                                                                                                         ^~~
/usr/ports/graphics/libfpx/work/libfpx-1.3.1-2/oless/h/owchar.h:75:42: note: passing argument to parameter 'string' here
WCHAR *  _CRTAPI1 wcschr ( const WCHAR * string, WCHAR ch );
                                         ^
.. snip ...
--- olefiles.So ---
In file included from /usr/ports/graphics/libfpx/work/libfpx-1.3.1-2/ole/olefiles.cpp:33:
In file included from /usr/ports/graphics/libfpx/work/libfpx-1.3.1-2/ole/olestorg.h:25:
In file included from /usr/include/c++/v1/fstream:169:
In file included from /usr/include/c++/v1/ostream:130:
In file included from /usr/include/c++/v1/ios:216:
In file included from /usr/include/c++/v1/__locale:15:
/usr/include/c++/v1/string:702:17: error: no matching function for call to 'fpx_wcslen'
        {return wcslen(__s);}
                ^~~~~~
/usr/ports/graphics/libfpx/work/libfpx-1.3.1-2/oless/h/owchar.h:59:20: note: expanded from macro 'wcslen'
#  define wcslen   fpx_wcslen
                   ^~~~~~~~~~
/usr/ports/graphics/libfpx/work/libfpx-1.3.1-2/oless/h/owchar.h:81:19: note: candidate function not viable: no known conversion from 'const char_type *' (aka 'const wchar_t *') to 'const WCHAR *' (aka 'const unsigned short *') for 1st argument
size_t   _CRTAPI1 wcslen(WCHAR const *wsz);
                  ^
/usr/ports/graphics/libfpx/work/libfpx-1.3.1-2/oless/h/owchar.h:59:20: note: expanded from macro 'wcslen'
#  define wcslen   fpx_wcslen
                   ^
5 errors generated.
*** [olefiles.So] Error code 1

make[1]: stopped in /usr/ports/graphics/libfpx/work/libfpx-1.3.1-2
2 errors

make[1]: stopped in /usr/ports/graphics/libfpx/work/libfpx-1.3.1-2
===> Compilation failed unexpectedly.

Fix: 

add USE_GCC=4.2+
How-To-Repeat: # cd ${PORTSDIR}/graphics/libfpx
# make
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-09-11 02:20:08 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->mi

mi@aldan.algebra.com => mi@ (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-09-11 02:20:09 UTC 
Maintainer of graphics/libfpx,

Please note that PR ports/182005 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/182005

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2013-09-11 02:20:10 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-09-11 23:46:08 UTC 
Author: mi
Date: Wed Sep 11 22:46:00 2013
New Revision: 327016
URL: http://svnweb.freebsd.org/changeset/ports/327016

Log:
  Update from 1.3.1-2, which is no longer available for download, to
  1.3.1-3 -- which contains all of our patches reported to date.
  
  Add a patch by stefanf@, which allows the port to build on 10.x
  Though I'll try to submit the patch upstream as before, I'll try
  to persuade them to not remove the 1.3.1-3 again after the apply
  it and "release" 1.3.1-4
  
  PR:		182009, 182005, 181779
  Obtained from:	stefanf

Added:
  head/graphics/libfpx/files/patch-c++   (contents, props changed)
Deleted:
  head/graphics/libfpx/files/patch-unused-privates
  head/graphics/libfpx/files/patch-warnings
Modified:
  head/graphics/libfpx/Makefile
  head/graphics/libfpx/distinfo

Modified: head/graphics/libfpx/Makefile
==============================================================================
--- head/graphics/libfpx/Makefile	Wed Sep 11 22:16:38 2013	(r327015)
+++ head/graphics/libfpx/Makefile	Wed Sep 11 22:46:00 2013	(r327016)
@@ -2,7 +2,7 @@
 # $FreeBSD$
 
 PORTNAME=	libfpx
-DISTVERSION=	1.3.1-2
+DISTVERSION=	1.3.1-3
 CATEGORIES=	graphics
 MASTER_SITES=	http://imagemagick.mirrorcatalogs.com/delegates/	\
 		http://www.imagemagick.org/download/delegates/	\
@@ -17,6 +17,7 @@ MAINTAINER=	mi@aldan.algebra.com
 COMMENT=	Library routines for working with Flashpix images
 
 USE_XZ=	yes
+MAKE_JOBS_UNSAFE=yes
 
 PLIST_FILES=	lib/libfpx.so.2 lib/libfpx.so lib/libfpx.a include/fpxlib.h
 USE_LDCONFIG=	yes

Modified: head/graphics/libfpx/distinfo
==============================================================================
--- head/graphics/libfpx/distinfo	Wed Sep 11 22:16:38 2013	(r327015)
+++ head/graphics/libfpx/distinfo	Wed Sep 11 22:46:00 2013	(r327016)
@@ -1,2 +1,2 @@
-SHA256 (libfpx-1.3.1-2.tar.xz) = 61c6332e8049460bebd9148589ffaad45a3849f0bf5f2dd8a79fefe9ac9ab0b0
-SIZE (libfpx-1.3.1-2.tar.xz) = 1892952
+SHA256 (libfpx-1.3.1-3.tar.xz) = cb82d8d90a0f195abcb6c0f1dc4cf181e9569f8f28d96969ed8378938641847a
+SIZE (libfpx-1.3.1-3.tar.xz) = 1892860

Added: head/graphics/libfpx/files/patch-c++
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/graphics/libfpx/files/patch-c++	Wed Sep 11 22:46:00 2013	(r327016)
@@ -0,0 +1,10 @@
+--- oless/h/owchar.h	2013-09-03 13:38:08.000000000 -0400
++++ oless/h/owchar.h	2013-09-11 18:31:34.000000000 -0400
+@@ -24,6 +24,6 @@
+ #include <stdarg.h>
+ 
+-
+ #ifdef __cplusplus
++#include <string>
+ extern "C" {
+ #endif
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Mikhail Teterin freebsd_committer freebsd_triage 2013-09-12 00:06:51 UTC 
State Changed
From-To: feedback->closed

A fix for this problem is added to the updated port. Thanks.