Bug 182022 - Fix port: textproc/docbook-xml should use base unzip where possible
Summary: Fix port: textproc/docbook-xml should use base unzip where possible
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jun Kuriyama
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-11 21:10 UTC by Chris Rees
Modified: 2013-10-06 13:35 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rees freebsd_committer freebsd_triage 2013-09-11 21:10:00 UTC
	USE_ZIP depends on any binary called unzip, so build fails when base unzip is present, but not the zip package.

	http://www.bayofrum.net/medusa/tinderlogs/10-local-20130829053459/docbook-xml-4.2_1.log (modified tinderbox to use the ports system to install dependencies, but will apply if installing on a clean system)

Fix: Use plain unzip rather than ${UNZIP_CMD}



-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.--AQSCWTPapyVp01ZCbMkMOsIrOS6xp6EXQ6giKBfXHIER6YPg
Content-Type: text/plain; name="patch.txt"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="patch.txt"

Index: Makefile
===================================================================
--- Makefile	(revision 327009)
+++ Makefile	(working copy)
@@ -1,9 +1,5 @@
-# New ports collection makefile for:	DocBook XML DTD
-# Date created:		28 March 1999
-# Whom:			kuriyama
-#
+# Created by: kuriyama
 # $FreeBSD$
-#
 
 PORTNAME=	docbook-xml
 PORTVERSION=	4.2
@@ -36,7 +32,7 @@
 	@[ -d ${DOCBOOKDIR}/ent ] || ${MKDIR} ${DOCBOOKDIR}/ent
 
 do-install:
-	for file in `${UNZIP_CMD} -l ${DISTDIR}/${DISTFILES}|${AWK} '/:[0-9].*[^\/]$$/{print $$4}'`; do \
+	for file in `unzip -l ${DISTDIR}/${DISTFILES}|${AWK} '/:[0-9].*[^\/]$$/{print $$4}'`; do \
 		${INSTALL_DATA} ${WRKSRC}/$$file ${DOCBOOKDIR}/$$file; \
 	done
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-09-11 21:10:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->kuriyama

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Chris Rees freebsd_committer freebsd_triage 2013-10-06 13:35:10 UTC
State Changed
From-To: open->closed

Committed.