Bug 182053 - [maintainer update] mail/lurker build fix
Summary: [maintainer update] mail/lurker build fix
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: William Grzybowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-13 00:40 UTC by Kevin Dorne
Modified: 2013-09-26 18:40 UTC (History)
0 users

See Also:


Attachments
file.diff (1.47 KB, patch)
2013-09-13 00:40 UTC, Kevin Dorne
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Dorne 2013-09-13 00:40:00 UTC
This fix is in response to a build failure:

Maintainer:     sweetpea-freebsd@tentacle.net
Last committer: ak@FreeBSD.org
Ident:          $FreeBSD: head/mail/lurker/Makefile 324744 2013-08-14 22:35:50Z ak $
Log URL:        http://beefy2.isc.freebsd.org/bulk/head-amd64-default/2013-09-12_01h37m09s/logs/lurker-2.3.log
Build URL:      http://beefy2.isc.freebsd.org/bulk/head-amd64-default/2013-09-12_01h37m09s

Fix: Added patch to unset ac_cv_header_zlib_h in configure script; this allows search for zlib to proceed normally.

Patch attached with submission follows:
How-To-Repeat: Build on 10-CURRENT
Comment 1 Glen Barber freebsd_committer freebsd_triage 2013-09-13 00:42:32 UTC
Responsible Changed
From-To: freebsd-bugs->freebsd-ports-bugs

Ports PR.
Comment 2 William Grzybowski freebsd_committer freebsd_triage 2013-09-13 12:13:29 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wg

I'll take it.
Comment 3 William Grzybowski 2013-09-13 15:28:57 UTC
Hi,

That doesn't seem to work for me:
https://redports.org/~wg/20130913140833-40396-144419/lurker-2.3_1.log

-- 
William Grzybowski
------------------------------------------
Curitiba/PR - Brasil
Comment 4 Kevin Dorne 2013-09-13 20:12:25 UTC
Strange, I can't duplicate it on a clean system.

Can you try building with MAKE_JOBS_UNSAFE=yes as suggested and see if
you still have the problem? It appears that the definitions in configure
aren't being passed to the compiler.
Comment 5 Kevin Dorne 2013-09-26 17:53:00 UTC
Can we go ahead and commit this change anyway? It does address the
initial build problem, and if additional problems spring up, we can
address them then. (I have built this several times on a clean
10-CURRENT system with no problems.)
Comment 6 dfilter service freebsd_committer freebsd_triage 2013-09-26 18:30:21 UTC
Author: wg
Date: Thu Sep 26 17:30:13 2013
New Revision: 328398
URL: http://svnweb.freebsd.org/changeset/ports/328398

Log:
  mail/lurker: fix build on head
  
  - Fix build on head [1]
  - Remove useless LICENSE_FILE
  - Remove leading article from COMMENT
  - Allow staging
  
  PR:		ports/182053
  Submitted by:	Kevin Rauwolf <sweetpea-freebsd tentacle.net> (maintainer)

Added:
  head/mail/lurker/files/patch-configure   (contents, props changed)
Modified:
  head/mail/lurker/Makefile
  head/mail/lurker/pkg-plist

Modified: head/mail/lurker/Makefile
==============================================================================
--- head/mail/lurker/Makefile	Thu Sep 26 17:29:29 2013	(r328397)
+++ head/mail/lurker/Makefile	Thu Sep 26 17:30:13 2013	(r328398)
@@ -1,8 +1,8 @@
-# Created by: Kevin Rauwolf <sweetpea-freebsd@tentacle.net>
 # $FreeBSD$
 
 PORTNAME=	lurker
 PORTVERSION=	2.3
+PORTREVISION=	1
 CATEGORIES=	mail
 MASTER_SITES=	SF:0 \
 		SF/${PORTNAME}/mimelib/${MIMELIB_VERSION}/:1
@@ -10,10 +10,9 @@ DISTFILES=	${DISTNAME}${EXTRACT_SUFX}:0 
 EXTRACT_ONLY=	${DISTNAME}${EXTRACT_SUFX}
 
 MAINTAINER=	sweetpea-freebsd@tentacle.net
-COMMENT=	A mailing list archiver
+COMMENT=	Mailing list archiver
 
 LICENSE=	GPLv2
-LICENSE_FILE=	${WRKSRC}/COPYING
 
 MIMELIB_VERSION=	3.1.1
 USES=		iconv
@@ -24,28 +23,19 @@ CONFIGURE_ARGS=	--with-mimelib-local \
 		--with-default-www-dir=${PREFIX}/www/lurker \
 		--with-cgi-bin-dir=${PREFIX}/www/lurker
 
-MAN1=		lurker-index.1 lurker-list.1 lurker-params.1 \
-		lurker-regenerate.1 lurker-search.1 lurker-prune.1
+OPTIONS_DEFINE=	DOCS
 
-NO_STAGE=	yes
 post-extract:
 	@cd ${WRKSRC} && ${EXTRACT_CMD} ${EXTRACT_BEFORE_ARGS} \
 		${DISTDIR}/mimelib-${MIMELIB_VERSION}.tar.gz ${EXTRACT_AFTER_ARGS}
 
 post-install:
-.if !defined(NOPORTDOCS)
-	${MKDIR} ${DOCSDIR}
-	${INSTALL_MAN} ${WRKSRC}/INSTALL ${DOCSDIR}
-	${INSTALL_MAN} ${WRKSRC}/FAQ ${DOCSDIR}
-	${INSTALL_MAN} ${WRKSRC}/ChangeLog ${DOCSDIR}
-.endif
-	@${CHOWN} -R www:www ${PREFIX}/www/lurker
-	${INSTALL_DATA} ${WRKSRC}/lurker.conf ${PREFIX}/etc/lurker/lurker.conf.sample
-	@if [ ! -f ${PREFIX}/etc/lurker/lurker.conf ]; then \
-		${CP} -p ${PREFIX}/etc/lurker/lurker.conf.sample ${PREFIX}/etc/lurker/lurker.conf ; \
-	fi
-	${INSTALL_DATA} ${WRKSRC}/apache.conf ${PREFIX}/etc/lurker/apache.conf.sample
-	@if [ ! -f ${PREFIX}/etc/lurker/apache.conf ]; then \
-		${CP} -p ${PREFIX}/etc/lurker/apache.conf.sample ${PREFIX}/etc/lurker/apache.conf ; \
-	fi
+	@${MKDIR} ${STAGEDIR}${DOCSDIR}
+	${INSTALL_MAN} ${WRKSRC}/INSTALL ${STAGEDIR}${DOCSDIR}
+	${INSTALL_MAN} ${WRKSRC}/FAQ ${STAGEDIR}${DOCSDIR}
+	${INSTALL_MAN} ${WRKSRC}/ChangeLog ${STAGEDIR}${DOCSDIR}
+	@${CHOWN} -R www:www ${STAGEDIR}${PREFIX}/www/lurker
+	${INSTALL_DATA} ${WRKSRC}/lurker.conf ${STAGEDIR}${PREFIX}/etc/lurker/lurker.conf.sample
+	${INSTALL_DATA} ${WRKSRC}/apache.conf ${STAGEDIR}${PREFIX}/etc/lurker/apache.conf.sample
+
 .include <bsd.port.mk>

Added: head/mail/lurker/files/patch-configure
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/mail/lurker/files/patch-configure	Thu Sep 26 17:30:13 2013	(r328398)
@@ -0,0 +1,10 @@
+--- configure.orig	2009-10-30 11:51:40.000000000 -0700
++++ configure	2013-09-12 09:08:52.000000000 -0700
+@@ -5109,6 +5109,7 @@
+ 
+ { echo "$as_me:$LINENO: checking for zlib.h" >&5
+ echo $ECHO_N "checking for zlib.h... $ECHO_C" >&6; }
++unset ac_cv_header_zlib_h
+ if test "${ac_cv_header_zlib_h+set}" = set; then
+   echo $ECHO_N "(cached) $ECHO_C" >&6
+ else

Modified: head/mail/lurker/pkg-plist
==============================================================================
--- head/mail/lurker/pkg-plist	Thu Sep 26 17:29:29 2013	(r328397)
+++ head/mail/lurker/pkg-plist	Thu Sep 26 17:30:13 2013	(r328398)
@@ -4,14 +4,18 @@ bin/lurker-params
 bin/lurker-prune
 bin/lurker-regenerate
 bin/lurker-search
-etc/lurker/apache.conf
-etc/lurker/lurker.conf
 @unexec if cmp -s %D/etc/lurker/lurker.conf.sample $D/etc/lurker/lurker.conf; then rm -f $D/etc/lurker/lurker.conf; fi
 etc/lurker/lurker.conf.sample
 @exec if [ ! -f %D/etc/lurker/lurker.conf ] ; then cp -p $D/%F %B/lurker.conf; fi
 @unexec if cmp -s %D/etc/lurker/apache.conf.sample $D/etc/lurker/apache.conf; then rm -f $D/etc/lurker/apache.conf; fi
 etc/lurker/apache.conf.sample
 @exec if [ ! -f %D/etc/lurker/apache.conf ] ; then cp -p $D/%F %B/apache.conf; fi
+man/man1/lurker-index.1.gz
+man/man1/lurker-list.1.gz
+man/man1/lurker-params.1.gz
+man/man1/lurker-prune.1.gz
+man/man1/lurker-regenerate.1.gz
+man/man1/lurker-search.1.gz
 %%PORTDOCS%%%%DOCSDIR%%/INSTALL
 %%PORTDOCS%%%%DOCSDIR%%/FAQ
 %%PORTDOCS%%%%DOCSDIR%%/ChangeLog
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 7 William Grzybowski freebsd_committer freebsd_triage 2013-09-26 18:30:36 UTC
State Changed
From-To: open->closed

Committed. Thanks!