Bug 182054 - [PATCH] dns/libidn: Amend to pkg-config data, to fix FreeBSD 10-CURRENT build failure
Summary: [PATCH] dns/libidn: Amend to pkg-config data, to fix FreeBSD 10-CURRENT build...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-13 01:30 UTC by Matthias Andree
Modified: 2013-09-29 14:00 UTC (History)
1 user (show)

See Also:


Attachments
libidn-1.28_1.patch (756 bytes, patch)
2013-09-13 01:30 UTC, Matthias Andree
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Andree freebsd_committer freebsd_triage 2013-09-13 01:30:00 UTC
FreeBSD 10 requires that all shared library symbols are resolved at link
time.  This fails if a libidn user does not link against libintl, but
libidn itself is linked against libintl.

In this situation, pkg-config --libs must print -lintl after -lidn.

I have reported this to the help-libidn mailing list.

This patch fixes the bug, and bumps the portrevision (which is required
in this situation - we change installed files).

Port maintainer (gaod@hychen.org) is cc'd.

Gaod, please follow up with a message stating whether you approve of
this change or not.

Generated with FreeBSD Port Tools 0.99_8 (mode: change, diff: ports)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-09-13 01:30:10 UTC
Maintainer of dns/libidn,

Please note that PR ports/182054 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/182054

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-09-13 01:30:11 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 matthias 2013-09-15 11:39:16 UTC
Reference to upstream bug report:
<http://lists.gnu.org/archive/html/help-libidn/2013-09/msg00003.html>

-- 
Matthias Andree
Comment 4 Matthias Andree freebsd_committer freebsd_triage 2013-09-29 13:53:22 UTC
State Changed
From-To: feedback->closed

Committed after feedback timeout.
Comment 5 dfilter service freebsd_committer freebsd_triage 2013-09-29 13:53:24 UTC
Author: mandree
Date: Sun Sep 29 12:53:16 2013
New Revision: 328685
URL: http://svnweb.freebsd.org/changeset/ports/328685

Log:
  Amend to pkg-config data, to fix FreeBSD 10-CURRENT build failures in
  dependent ports.
  
  PR:		ports/182054
  Approved by:	gaod@hychen.org (maintainer timeout, 16 days)

Modified:
  head/dns/libidn/Makefile

Modified: head/dns/libidn/Makefile
==============================================================================
--- head/dns/libidn/Makefile	Sun Sep 29 12:50:40 2013	(r328684)
+++ head/dns/libidn/Makefile	Sun Sep 29 12:53:16 2013	(r328685)
@@ -3,6 +3,7 @@
 
 PORTNAME=	libidn
 PORTVERSION=	1.28
+PORTREVISION=	1
 CATEGORIES=	dns
 MASTER_SITES=	GNU
 
@@ -40,6 +41,9 @@ post-patch:
 	@${REINPLACE_CMD} -e '/^install-data-am: / s| install-imagesDATA||' \
 		${WRKSRC}/doc/Makefile.in
 .endif
+.if ${PORT_OPTIONS:MNLS}
+	@${REINPLACE_CMD} -e 's/-lidn/& -lintl/' ${WRKSRC}/libidn.pc.in
+.endif
 
 post-install:
 .if ${PORT_OPTIONS:MDOCS}
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"