Bug 182069 - [PATCH] devel/py-gobject: Fix GFlags messages
Summary: [PATCH] devel/py-gobject: Fix GFlags messages
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-13 21:00 UTC by Rusmir Dusko
Modified: 2014-03-03 22:50 UTC (History)
1 user (show)

See Also:


Attachments
py27-gobject-2.28.6_3.patch (990 bytes, patch)
2013-09-13 21:00 UTC, Rusmir Dusko
no flags Details | Diff
py-gobject.diff (3.22 KB, patch)
2013-09-29 11:33 UTC, Rusmir Dusko
no flags Details | Diff
py-gobject.diff (1.98 KB, patch)
2013-09-29 11:30 UTC, Rusmir Dusko
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rusmir Dusko freebsd_committer freebsd_triage 2013-09-13 21:00:01 UTC
Added file(s):
- files/patch-gio-gio-types.defs

Port maintainer (gnome@FreeBSD.org) is cc'd.

Generated and tested manually, tested with port test and with RedPorts, sent with FreeBSD Port Tools 0.99_8 (mode: change, diff: ports)

How-To-Repeat: 
Build log

https://redports.org/buildarchive/20130912232301-7036/


Without this patch i have get these messages with graphics/boxer and many other Ports

** (process:17507): WARNING **: Trying to register gtype 'GMountMountFlags' as enum when in fact it is of type 'GFlags'

** (process:17507): WARNING **: Trying to register gtype 'GDriveStartFlags' as enum when in fact it is of type 'GFlags'

** (process:17507): WARNING **: Trying to register gtype 'GSocketMsgFlags' as enum when in fact it is of type 'GFlags'
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-09-13 21:00:10 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Rusmir Dusko freebsd_committer freebsd_triage 2013-09-29 11:30:37 UTC
- Remove not needed LICENSE_FILE
- Use the new format for LIB_DEPENDS
- USES gmake pathfix pkgconfig
- Support STAGEDIR, new pkg-plist with make makeplist
- Add patch, fix GFlags messages
Comment 3 Rusmir Dusko freebsd_committer freebsd_triage 2013-09-29 11:33:29 UTC
Sorry have forget patch

files/patch-gio-gio-types.defs

Here is new diff
Comment 4 Rusmir Dusko freebsd_committer freebsd_triage 2014-03-03 22:24:12 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 5 dfilter service freebsd_committer freebsd_triage 2014-03-03 22:46:51 UTC
Author: nemysis
Date: Mon Mar  3 22:46:43 2014
New Revision: 346974
URL: http://svnweb.freebsd.org/changeset/ports/346974
QAT: https://qat.redports.org/buildarchive/r346974/

Log:
  - Remove not needed LICENSE_FILE
  - Use the new format for LIB_DEPENDS
  - USES gmake instead of USE_GMAKE
  - Change USE_PYTHON=yes to USE_PYTHON=2
  - Support STAGEDIR, new pkg-plist with make makeplist
  - Strip libraries
  - Add patch, fix GFlags messages
  
  PR:		ports/182069
  Submitted by:	nemysis (self)
  Approved by:	portmgr

Added:
  head/devel/py-gobject/files/patch-gio-gio-types.defs   (contents, props changed)
Modified:
  head/devel/py-gobject/Makefile
  head/devel/py-gobject/pkg-plist

Modified: head/devel/py-gobject/Makefile
==============================================================================
--- head/devel/py-gobject/Makefile	Mon Mar  3 21:57:53 2014	(r346973)
+++ head/devel/py-gobject/Makefile	Mon Mar  3 22:46:43 2014	(r346974)
@@ -16,19 +16,17 @@ MAINTAINER=	gnome@FreeBSD.org
 COMMENT=	Python bindings for GObject
 
 LICENSE=	LGPL21
-LICENSE_FILE=	${WRKSRC}/COPYING
 
 BUILD_DEPENDS=	g-ir-scanner:${PORTSDIR}/devel/gobject-introspection \
 		${LOCALBASE}/libdata/pkgconfig/pycairo.pc:${PORTSDIR}/graphics/py-cairo
-LIB_DEPENDS+=	ffi:${PORTSDIR}/devel/libffi
+LIB_DEPENDS+=	libffi.so:${PORTSDIR}/devel/libffi
 RUN_DEPENDS=	g-ir-scanner:${PORTSDIR}/devel/gobject-introspection \
 		${LOCALBASE}/libdata/pkgconfig/pycairo.pc:${PORTSDIR}/graphics/py-cairo
 
-USES=		pathfix pkgconfig
+USES=		gmake pathfix pkgconfig
 USE_XZ=		yes
-USE_GMAKE=	yes
 USE_GNOME=	glib20
-USE_PYTHON=	yes
+USE_PYTHON=	2
 GNU_CONFIGURE=	yes
 USE_LDCONFIG=	yes
 CONFIGURE_ARGS=	--disable-docs --disable-introspection --with-ffi
@@ -36,9 +34,13 @@ CONFIGURE_ARGS=	--disable-docs --disable
 CONFLICTS=	py*-gtk-0*
 PLIST_SUB=	PYTHON_VER="${PYTHON_VER}"
 
-NO_STAGE=	yes
 post-install:
 	@${PYTHON_CMD} ${PYTHON_LIBDIR}/compileall.py \
-		${PREFIX}/share/pygobject/2.0/codegen
+		${STAGEDIR}${PREFIX}/share/pygobject/2.0/codegen
+
+.for l in glib/_glib gobject/_gobject gtk-2.0/gio/_gio gtk-2.0/gio/unix
+	${STRIP_CMD} ${STAGEDIR}${PYTHON_SITELIBDIR}/${l}.so
+.endfor
+	${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libpyglib-2.0-python${PYTHON_VER}.so.0
 
 .include <bsd.port.mk>

Added: head/devel/py-gobject/files/patch-gio-gio-types.defs
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/devel/py-gobject/files/patch-gio-gio-types.defs	Mon Mar  3 22:46:43 2014	(r346974)
@@ -0,0 +1,29 @@
+--- gio/gio-types.defs.orig	2011-06-13 18:33:49.000000000 +0200
++++ gio/gio-types.defs	2013-09-13 01:14:09.000000000 +0200
+@@ -526,7 +526,7 @@
+   )
+ )
+ 
+-(define-enum MountMountFlags
++(define-flags MountMountFlags
+   (in-module "gio")
+   (c-name "GMountMountFlags")
+   (gtype-id "G_TYPE_MOUNT_MOUNT_FLAGS")
+@@ -545,7 +545,7 @@
+   )
+ )
+ 
+-(define-enum DriveStartFlags
++(define-flags DriveStartFlags
+   (in-module "gio")
+   (c-name "GDriveStartFlags")
+   (gtype-id "G_TYPE_DRIVE_START_FLAGS")
+@@ -770,7 +770,7 @@
+   )
+ )
+ 
+-(define-enum SocketMsgFlags
++(define-flags SocketMsgFlags
+   (in-module "gio")
+   (c-name "GSocketMsgFlags")
+   (gtype-id "G_TYPE_SOCKET_MSG_FLAGS")

Modified: head/devel/py-gobject/pkg-plist
==============================================================================
--- head/devel/py-gobject/pkg-plist	Mon Mar  3 21:57:53 2014	(r346973)
+++ head/devel/py-gobject/pkg-plist	Mon Mar  3 22:46:43 2014	(r346974)
@@ -1,9 +1,9 @@
 bin/pygobject-codegen-2.0
 include/pygtk-2.0/pyglib.h
 include/pygtk-2.0/pygobject.h
-lib/libpyglib-2.0-python%%PYTHON_VER%%.la
-lib/libpyglib-2.0-python%%PYTHON_VER%%.so
-lib/libpyglib-2.0-python%%PYTHON_VER%%.so.0
+lib/libpyglib-2.0-%%PYTHON_VERSION%%.la
+lib/libpyglib-2.0-%%PYTHON_VERSION%%.so
+lib/libpyglib-2.0-%%PYTHON_VERSION%%.so.0
 %%PYTHON_SITELIBDIR%%/glib/__init__.py
 %%PYTHON_SITELIBDIR%%/glib/__init__.pyc
 %%PYTHON_SITELIBDIR%%/glib/__init__.pyo
@@ -23,6 +23,9 @@ lib/libpyglib-2.0-python%%PYTHON_VER%%.s
 %%PYTHON_SITELIBDIR%%/gobject/propertyhelper.py
 %%PYTHON_SITELIBDIR%%/gobject/propertyhelper.pyc
 %%PYTHON_SITELIBDIR%%/gobject/propertyhelper.pyo
+%%PYTHON_SITELIBDIR%%/gtk-2.0/dsextras.py
+%%PYTHON_SITELIBDIR%%/gtk-2.0/dsextras.pyc
+%%PYTHON_SITELIBDIR%%/gtk-2.0/dsextras.pyo
 %%PYTHON_SITELIBDIR%%/gtk-2.0/gio/__init__.py
 %%PYTHON_SITELIBDIR%%/gtk-2.0/gio/__init__.pyc
 %%PYTHON_SITELIBDIR%%/gtk-2.0/gio/__init__.pyo
@@ -30,9 +33,6 @@ lib/libpyglib-2.0-python%%PYTHON_VER%%.s
 %%PYTHON_SITELIBDIR%%/gtk-2.0/gio/_gio.so
 %%PYTHON_SITELIBDIR%%/gtk-2.0/gio/unix.la
 %%PYTHON_SITELIBDIR%%/gtk-2.0/gio/unix.so
-%%PYTHON_SITELIBDIR%%/gtk-2.0/dsextras.py
-%%PYTHON_SITELIBDIR%%/gtk-2.0/dsextras.pyc
-%%PYTHON_SITELIBDIR%%/gtk-2.0/dsextras.pyo
 %%PYTHON_SITELIBDIR%%/pygtk.pth
 %%PYTHON_SITELIBDIR%%/pygtk.py
 %%PYTHON_SITELIBDIR%%/pygtk.pyc
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"