Bug 182153 - lang/spidermonkey17 fails configure
Summary: lang/spidermonkey17 fails configure
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Kubilay Kocak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-16 16:10 UTC by Vincent Hoffman-Kazlauskas
Modified: 2013-10-25 14:07 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Hoffman-Kazlauskas 2013-09-16 16:10:00 UTC
make fails for lang/spidermonkey17
root@bsdpkgbuild:/usr/ports/lang/spidermonkey17 # make
===>   spidermonkey17-1.7.0_1 depends on executable: gmake - found
===>   spidermonkey17-1.7.0_1 depends on shared library: nspr4.1 - found
===>  Configuring for spidermonkey17-1.7.0_1
/bin/cp /usr/ports/lang/spidermonkey17/work/js/src/config/Linux_All.mk  /usr/ports/lang/spidermonkey17/work/js/src/config/FreeBSD`/usr/bin/uname -r`.mk &&
Syntax error: end of file unexpected
*** Error code 2

Stop.
make[1]: stopped in /usr/ports/lang/spidermonkey17
*** Error code 1

Stop.
make: stopped in /usr/ports/lang/spidermonkey17

I cant see how its meant to work either, excerpt from Makefile
--------
do-configure:
        ${CP} ${WRKSRC}/config/Linux_All.mk \
                ${WRKSRC}/config/${OPSYS}`${UNAME} -r`.mk && \

do-install:

--------
I had a look at the spidermonkey170 port to compare but thats wildly different.

Fix: 

not sure.
How-To-Repeat: cd /usr/ports/lang/spidermonkey17 
make
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-09-16 16:10:08 UTC
Maintainer of lang/spidermonkey17,

Please note that PR ports/182153 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/182153

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-09-16 16:10:09 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Vincent Hoffman-Kazlauskas 2013-09-16 16:26:34 UTC
I looked though the svnweb and tracked down the commit which would have
broken this
http://svnweb.freebsd.org/ports/head/lang/spidermonkey17/Makefile?r1=140838&r2=140839&
which says 2005, however I have built this port more recently than that
so I'm a little confused.
for reference the patch to get it to build was:
--- Makefile.orig       2013-09-16 16:12:14.995523047 +0100
+++ Makefile    2013-09-16 16:12:37.526520356 +0100
@@ -52,6 +52,7 @@
 do-configure:
        ${CP} ${WRKSRC}/config/Linux_All.mk \
                ${WRKSRC}/config/${OPSYS}`${UNAME} -r`.mk && \
+        ${CP} ${WRKSRC}/Makefile.ref ${WRKSRC}/Makefile
 
 do-install:
        ${INSTALL_PROGRAM} ${WRKSRC}/${OPSYS}`${UNAME} -r`_DBG.OBJ/js \
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2013-10-25 13:31:32 UTC
Responsible Changed
From-To: freebsd-ports-bugs->koobs

I'll take it.
Comment 5 dfilter service freebsd_committer freebsd_triage 2013-10-25 13:50:53 UTC
Author: koobs
Date: Fri Oct 25 12:50:46 2013
New Revision: 331572
URL: http://svnweb.freebsd.org/changeset/ports/331572

Log:
  lang/spidermonkey17: Fix typo causing configure to fail
  
  - Remove spurious dangling && from configure invocation
  - While im here, pet portlint
  
  PR:		ports/182153
  PR:		ports/182197
  Submitted by:	swills
  Reported by:	Vincent Hoffman-Kazlauskas <vince@unsane.co.uk>
  Approved by:	maintainer timeout (1 month)

Modified:
  head/lang/spidermonkey17/Makefile   (contents, props changed)

Modified: head/lang/spidermonkey17/Makefile
==============================================================================
--- head/lang/spidermonkey17/Makefile	Fri Oct 25 12:42:00 2013	(r331571)
+++ head/lang/spidermonkey17/Makefile	Fri Oct 25 12:50:46 2013	(r331572)
@@ -39,7 +39,7 @@ JSH=		jsapi.h jsarena.h jsarray.h jsatom
 
 PLIST_FILES=	bin/js lib/libjs.so lib/libjs.so.1 ${JSH:S,^,include/,}
 WRKSRC=		${WRKDIR}/${SRC_DIR}
-EXTRACT_AFTER_ARGS= --exclude js/jsd
+EXTRACT_AFTER_ARGS=	--exclude js/jsd
 
 OPTIONS_DEFINE=	UTF8
 
@@ -52,7 +52,7 @@ CFLAGS+=	-DJS_C_STRINGS_ARE_UTF8
 
 do-configure:
 	${CP} ${WRKSRC}/config/Linux_All.mk \
-		${WRKSRC}/config/${OPSYS}`${UNAME} -r`.mk && \
+		${WRKSRC}/config/${OPSYS}`${UNAME} -r`.mk
 
 do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/${OPSYS}`${UNAME} -r`_DBG.OBJ/js \
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2013-10-25 14:07:23 UTC
State Changed
From-To: feedback->closed

Superceded by and resolved in ports/182197. Thanks Vincent!