Bug 182549 - devel/boost-libs fails to build on non-x86
Summary: devel/boost-libs fails to build on non-x86
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Kubilay Kocak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-01 15:20 UTC by Justin Hibbits
Modified: 2013-12-14 12:00 UTC (History)
0 users

See Also:

Attachments
file.diff (376 bytes, patch)
2013-10-01 15:20 UTC, Justin Hibbits 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Hibbits 2013-10-01 15:20:00 UTC 
devel/boost-libs fails to build its test suite on non-x86, due to not including osreldate.h, in the execution_monitor.  A fix was applied to the trunk, but never merged into the release branches.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-10-01 15:20:07 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->office

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Justin Hibbits 2013-12-14 07:23:56 UTC 
The original trac ticket and fix can be found at:
https://svn.boost.org/trac/boost/ticket/3897

The patch is only in trunk, it's not in the release branch.  If trunk
ever does branch again, it will be included in likely a later major
release (boost2, maybe?).

- Justin
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-12-14 11:53:22 UTC 
Author: koobs
Date: Sat Dec 14 11:53:15 2013
New Revision: 336438
URL: http://svnweb.freebsd.org/changeset/ports/336438

Log:
  devel/boost-libs: Backport fix building test framework on non-x86 platforms
  
  This change backports an upstream commit [1] to fix building of the test
  framework on non-x86 systems [2] due to not #include'ing osreldate.h prior
  to testing __FreeBSD_version.
  
  [1] https://svn.boost.org/trac/boost/changeset/62780
  [2] https://svn.boost.org/trac/boost/ticket/3897
  
  PR:		ports/182549
  Submitted by:	jhibbits
  Reviewed by:	bapt
  Approved by:	office@ (bapt)

Added:
  head/devel/boost-libs/files/patch-boost__test__impl__execution_monitor.ipp   (contents, props changed)

Added: head/devel/boost-libs/files/patch-boost__test__impl__execution_monitor.ipp
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/devel/boost-libs/files/patch-boost__test__impl__execution_monitor.ipp	Sat Dec 14 11:53:15 2013	(r336438)
@@ -0,0 +1,16 @@
+# Description: Backport fix building test suite on non-x86 platforms
+# PR: ports/182549
+# Upstream Issue: https://svn.boost.org/trac/boost/ticket/3897
+# Upstream Change: https://svn.boost.org/trac/boost/changeset/62780
+
+--- ./boost/test/impl/execution_monitor.ipp.orig	2013-12-14 18:22:41.772892518 +1100
++++ ./boost/test/impl/execution_monitor.ipp	2013-12-14 18:23:15.554395963 +1100
+@@ -156,6 +156,8 @@
+ 
+ #  if defined(__FreeBSD__)  
+ 
++#    include <osreldate.h>
++
+ #    ifndef SIGPOLL
+ #      define SIGPOLL SIGIO
+ #    endif
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2013-12-14 11:55:31 UTC 
Responsible Changed
From-To: office->koobs

I'll take it. Maintainer timeout (2 months)
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2013-12-14 11:55:50 UTC 
State Changed
From-To: open->closed

Committed. Thanks Justin!