The maintainer for this port prefers that the `make config` dialog is hidden by default. However, (in my opinion) this behavior is confusing and counter-intuitive. Users who do not wish to set options don't have to do anything differently; the options dialog is only shown when the user types `make config`. Users who do wish to set options, on the other hand, must type `make showconfig` to see the message warning users to set the correct property in make.conf. Most (including me) assume that a port doesn't have options after a `make config`. Please seriously consider changing the default behavior (the attached patch does this). If you don't like this change, you can cherry-pick the other changes with this patch which include cleaning up variables and petting portlint. Fix: Apply the attached patch. Patch attached with submission follows: How-To-Repeat: Attempt to set port options without "WITH_OPTIONS" set.
Responsible Changed From-To: freebsd-ports-bugs->obrien Over to maintainer (via the GNATS Auto Assign Tool)
Responsible Changed From-To: obrien->freebsd-ports-bugs Return to the heap
Author: bdrewery Date: Mon Dec 2 13:57:22 2013 New Revision: 335488 URL: http://svnweb.freebsd.org/changeset/ports/335488 Log: - Remove WITH_VIM_OPTIONS and respect ports framework PR: ports/182749 Submitted by: Kevin Zheng <kevinz5000@gmail.com> (based on) Requested by: many Modified: head/editors/vim/Makefile Modified: head/editors/vim/Makefile ============================================================================== --- head/editors/vim/Makefile Mon Dec 2 13:47:06 2013 (r335487) +++ head/editors/vim/Makefile Mon Dec 2 13:57:22 2013 (r335488) @@ -13,7 +13,7 @@ PORTNAME?= vim PATCHLEVEL= 1314 PORTVERSION= 7.3.${PATCHLEVEL} RELEASE= vim-${PORTVERSION:C/\.[0-9a-z]*$//} -PORTREVISION?= 0 +PORTREVISION?= 1 CATEGORIES?= editors MASTER_SITES= ${MASTER_SITE_VIM} DISTFILES= ${RELEASE}${EXTRACT_SUFX} @@ -35,16 +35,9 @@ SLAVEDIRS= editors/vim-lite NO_STAGE= yes .if !defined(LITE) -.if defined(WITH_OPTIONS) || defined(WITH_VIM_OPTIONS) .include "${.CURDIR}/../vim/options" OPTIONS_DEFAULT+= CSCOPE EXUBERANT_CTAGS PERL PYTHON RUBY \ TCL LUA X11 GTK2 -.else -VIM_PORT_SCRIPT_LANGS?= LUA PERL PYTHON RUBY TCL -VIM_PORT_OPTIONS= CSCOPE DOCS EXAMPLES EXUBERANT_CTAGS \ - ${VIM_PORT_SCRIPT_LANGS} -PORT_OPTIONS?= ${VIM_PORT_OPTIONS} -.endif .endif .include <bsd.port.options.mk> @@ -234,10 +227,7 @@ post-install: cd ${WRKDIR} ; ex < ex.script show-options: - @${MAKE} -DWITH_OPTIONS showconfig - @${ECHO_CMD} "" - @${ECHO_CMD} "Put \"WITH_OPTIONS=yes\" -or- \"WITH_VIM_OPTIONS=yes\"" - @${ECHO_CMD} "in your /etc/make.conf or /etc/ports.conf file to enable OPTIONS processing. + @${MAKE} showconfig .if defined(ONT_CHECKSUM) checksum: _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Responsible Changed From-To: freebsd-ports-bugs->bdrewery I'll take it.
State Changed From-To: open->closed OPTIONS now enabled by default