add BUILD_DEPENDS= gcc:${PORTSDIR}/lang/gcc as files/patch-aa has CC= gcc & as build breaks on FreeBSD 10.0-ALPHA4 that has clang not gcc Fix: apply patch appended http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/ports/gen/www/dummyflash/Makefile.REL=ALL.diff
Maintainer of www/dummyflash, Please note that PR ports/182834 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/182834 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
> I no longer use this port (I use a click-to-flash extension in Chrome = > instead), but I think the following diff is better. It doesn't depend on = > GCC, just uses whatever the makefile framework says to use. > > It also splits out the patches into separate files. Thanks Daniel, Hopefully someone can commit yours. Cheers, Julian -- Julian Stacey, BSD Unix Linux C Sys Eng Consultant, Munich http://berklix.com Reply below not above, like a play script. Indent old text with "> ". Send plain text. No quoted-printable, HTML, base64, multipart/alternative.
On 09/10/2013, at 10:51, Julian H. Stacey <jhs@berklix.com> wrote: >> I no longer use this port (I use a click-to-flash extension in Chrome = >> instead), but I think the following diff is better. It doesn't depend on = >> GCC, just uses whatever the makefile framework says to use. >> >> It also splits out the patches into separate files. > > Thanks Daniel, > Hopefully someone can commit yours. Me too, although I don't actually _use_ it so if you do you may wish to take it under your wing :) -- Daniel O'Connor software and network engineer for Genesis Software - http://www.gsoft.com.au "The nice thing about standards is that there are so many of them to choose from." -- Andrew Tanenbaum GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C
State Changed From-To: feedback->open Feedback received.
Responsible Changed From-To: freebsd-ports-bugs->thierry Take it.
Author: thierry Date: Wed Mar 5 14:47:32 2014 New Revision: 347114 URL: http://svnweb.freebsd.org/changeset/ports/347114 QAT: https://qat.redports.org/buildarchive/r347114/ Log: Fix the build with clang. PR: ports/182834 Submitted by: "Julian H. Stacey" <jhs (at) berklix.com> Rewritten by: maintainer Added: head/www/dummyflash/files/patch-UnixShell.c (contents, props changed) head/www/dummyflash/files/patch-makefile.freebsd (contents, props changed) Deleted: head/www/dummyflash/files/patch-aa Added: head/www/dummyflash/files/patch-UnixShell.c ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/www/dummyflash/files/patch-UnixShell.c Wed Mar 5 14:47:32 2014 (r347114) @@ -0,0 +1,26 @@ +--- PluginSDK30b5/examples/UnixTemplate/Source/UnixShell.c.orig 1996-07-12 15:10:28.000000000 +0930 ++++ PluginSDK30b5/examples/UnixTemplate/Source/UnixShell.c 2013-10-09 07:24:13.570473153 +1030 +@@ -48,7 +48,7 @@ + char* + NPP_GetMIMEDescription(void) + { +- return("mime/type:sample:Template Only"); ++ return("application/x-shockwave-flash:null flash:Dummy flash plugin"); + } + + NPError +@@ -58,12 +58,11 @@ + + switch (variable) { + case NPPVpluginNameString: +- *((char **)value) = "Template plugin"; ++ *((char **)value) = "Dummy flash plugin"; + break; + case NPPVpluginDescriptionString: + *((char **)value) = +- "This plugins handles nothing. This is only" +- " a template."; ++ "This is a dummy flash plugin"; + break; + default: + err = NPERR_GENERIC_ERROR; Added: head/www/dummyflash/files/patch-makefile.freebsd ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/www/dummyflash/files/patch-makefile.freebsd Wed Mar 5 14:47:32 2014 (r347114) @@ -0,0 +1,51 @@ +--- PluginSDK30b5/examples/UnixTemplate/Unix/makefile.freebsd.orig 2013-10-09 07:24:13.572467161 +1030 ++++ PluginSDK30b5/examples/UnixTemplate/Unix/makefile.freebsd 2013-10-09 07:27:13.288470186 +1030 +@@ -0,0 +1,48 @@ ++#!make ++################################################################################ ++# Copyright (c) 1996 Netscape Communications. All rights reserved. ++################################################################################ ++# ++# Template plugin makefile ++# ++# Platform: SunOS 4.1 ++# ++# The output of the make process will be nptemplate.so ++# Install this file either in ++# /usr/lib/netscape/plugins/ ++# (or) ++# ~/.netscape/plugins/ ++# (or) in any convenient directory and point environment variable ++# NPX_PLUGIN_PATH to point to the directory. It is advisable ++# that the plugins (.so) are the only files in that directory. ++# ++# This makefile contains some of our defines for the compiler: ++# ++# XP_UNIX This needs to get defined for npapi.h on unix platforms. ++# PLUGIN_TRACE Enable this define to get debug prints whenever the plugin ++# api gets control. ++ ++# PLUGIN_DEFINES= -DXP_UNIX -DPLUGIN_TRACE ++PLUGIN_DEFINES= -DXP_UNIX -I../../../include -I../Source/_gen -I${LOCALBASE}/include ++ ++OPTIMIZER= -g ++CFLAGS= $(OPTIMIZER) -fPIC $(PLUGIN_DEFINES) -I. -I$(ROOT)/usr/include ++ ++SRC= ../Source/UnixShell.c ../Source/stubs.c ++OBJ= UnixShell.o stubs.o ++ ++SHAREDTARGET=dummyflash.so ++ ++default all: $(SHAREDTARGET) ++ ++$(SHAREDTARGET): $(OBJ) ++ $(LD) -shared -o $(SHAREDTARGET) $(OBJ) $(LDFLAGS) ++ ++UnixShell.o: ../Source/UnixShell.c ++ $(CC) -c $(CFLAGS) ../Source/UnixShell.c ++ ++stubs.o: ../Source/stubs.c ++ $(CC) -c $(CFLAGS) ../Source/stubs.c ++ ++clean: ++ $(RM) $(OBJ) $(SHAREDTARGET) _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed, with maintainer's patch. Anyway, thanks for the report!