Bug 182848 - [maintainer update] [stagedir] multimedia/ffmpegthumbnailer
Summary: [maintainer update] [stagedir] multimedia/ffmpegthumbnailer
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: William Grzybowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-09 04:20 UTC by clutton
Modified: 2013-10-26 14:40 UTC (History)
0 users

See Also:


Attachments
file.diff (1.94 KB, patch)
2013-10-09 04:20 UTC, clutton
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description clutton 2013-10-09 04:20:00 UTC
I want to update my maintainer email (the old one is broken).
And I have a question: 

I've deleted the line
-	cd ${WRKSRC}/ && ${SETENV} ${MAKE_ENV} ${MAKE} install-pkgconfigDATA
was it correct?

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-10-09 04:20:08 UTC
Class Changed
From-To: maintainer-update->change-request

Fix category (submitter is not maintainer) (via the GNATS Auto Assign 
Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-10-09 04:20:09 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2013-10-09 04:20:09 UTC
Maintainer of multimedia/ffmpegthumbnailer,

Please note that PR ports/182848 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/182848

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 4 clutton 2013-10-09 04:37:41 UTC
The mentioned email is unavailable. Because the domain is dead.
It was my email...
Comment 5 William Grzybowski freebsd_committer freebsd_triage 2013-10-26 02:32:57 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wg

I'll take it.
Comment 6 dfilter service freebsd_committer freebsd_triage 2013-10-26 14:32:26 UTC
Author: wg
Date: Sat Oct 26 13:32:19 2013
New Revision: 331687
URL: http://svnweb.freebsd.org/changeset/ports/331687

Log:
  multimedia/ffmpegthumbnailer: allow staging
  
  - Allow staging [1]
  - Convert lib depends to new format
  - Drop empty PTHREAD_CFLAGS
  
  PR:		ports/182848 [1] (based on)
  Submitted by:	clutton <clutton zoho.com> (maintainer)
  Reviewed by:	danfe

Modified:
  head/multimedia/ffmpegthumbnailer/Makefile
  head/multimedia/ffmpegthumbnailer/pkg-plist

Modified: head/multimedia/ffmpegthumbnailer/Makefile
==============================================================================
--- head/multimedia/ffmpegthumbnailer/Makefile	Sat Oct 26 13:28:00 2013	(r331686)
+++ head/multimedia/ffmpegthumbnailer/Makefile	Sat Oct 26 13:32:19 2013	(r331687)
@@ -7,15 +7,15 @@ PORTREVISION=	2
 CATEGORIES=	multimedia graphics
 MASTER_SITES=	GOOGLE_CODE
 
-MAINTAINER=	mbsd@isgroup.com.ua
+MAINTAINER=	clutton@zoho.com
 COMMENT=	Lightweight video thumbnailer that can be used by file managers
 
-LIB_DEPENDS=	png15:${PORTSDIR}/graphics/png \
-		swscale:${PORTSDIR}/multimedia/ffmpeg \
-		jpeg:${PORTSDIR}/graphics/jpeg
+LIB_DEPENDS=	libpng15.so:${PORTSDIR}/graphics/png \
+		libswscale.so:${PORTSDIR}/multimedia/ffmpeg \
+		libjpeg.so:${PORTSDIR}/graphics/jpeg
 
-CPPFLAGS+=	${PTHREAD_CFLAGS} -I${LOCALBASE}/include
-LDFLAGS+=	${PTHREAD_LIBS} -L${LOCALBASE}/lib
+CPPFLAGS+=	-I${LOCALBASE}/include
+LDFLAGS+=	-pthread -L${LOCALBASE}/lib
 CONFIGURE_ARGS=	--with-pkgconfigdir=${PREFIX}/libdata/pkgconfig --enable-gio
 
 GNU_CONFIGURE=	yes
@@ -25,25 +25,17 @@ USE_LDCONFIG=	yes
 
 OPTIONS_DEFINE=	GNOME
 
-MAN1=		ffmpegthumbnailer.1
-
-NO_STAGE=	yes
 .include <bsd.port.options.mk>
 
 .if ${PORT_OPTIONS:MGNOME}
-PKGNAMESUFFIX+=	-gnome
 USE_GNOME+=	gconf2
 GCONF_SCHEMAS=	ffmpegthumbnailer.schemas
 .endif
 
 post-install:
-	cd ${WRKSRC}/ && ${SETENV} ${MAKE_ENV} ${MAKE} install-pkgconfigDATA
 .if ${PORT_OPTIONS:MGNOME}
-	${MKDIR} ${PREFIX}/etc/gconf/schemas
-	${INSTALL_DATA} ${FILESDIR}/${GCONF_SCHEMAS} ${PREFIX}/etc/gconf/schemas
-	@${SETENV} GCONF_CONFIG_SOURCE=xml:${GCONF_CONFIG_OPTIONS}:${PREFIX}/${GCONF_CONFIG_DIRECTORY} \
-		gconftool-2 --makefile-install-rule ${PREFIX}/etc/gconf/schemas/${GCONF_SCHEMAS} \
-		> /dev/null || ${TRUE}
+	@${MKDIR} ${STAGEDIR}${PREFIX}/etc/gconf/schemas
+	${INSTALL_DATA} ${FILESDIR}/${GCONF_SCHEMAS} ${STAGEDIR}${PREFIX}/etc/gconf/schemas
 .endif
 
 .include <bsd.port.mk>

Modified: head/multimedia/ffmpegthumbnailer/pkg-plist
==============================================================================
--- head/multimedia/ffmpegthumbnailer/pkg-plist	Sat Oct 26 13:28:00 2013	(r331686)
+++ head/multimedia/ffmpegthumbnailer/pkg-plist	Sat Oct 26 13:32:19 2013	(r331687)
@@ -10,4 +10,5 @@ lib/libffmpegthumbnailer.la
 lib/libffmpegthumbnailer.so
 lib/libffmpegthumbnailer.so.4
 libdata/pkgconfig/libffmpegthumbnailer.pc
+man/man1/ffmpegthumbnailer.1.gz
 @dirrm include/libffmpegthumbnailer
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 7 William Grzybowski freebsd_committer freebsd_triage 2013-10-26 14:32:27 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!