Bug 183014 - dns/inadyn-mt: Installs in illegal area
Summary: dns/inadyn-mt: Installs in illegal area
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: William Grzybowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-16 01:10 UTC by John Marino
Modified: 2013-10-16 13:50 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Marino freebsd_committer freebsd_triage 2013-10-16 01:10:00 UTC
This port is not constrained to /usr/local.  It tries to create its own directory in root:

=======================<phase: stage          >============================
===>  Staging for inadyn-mt-02.24.38
===>   Generating temporary packing list
Making install in src
test -z "/usr/local/bin" || ../Cfg/install-sh -c -d "/wrkdirs/dns/inadyn-mt/work/stage/usr/local/bin"
  /usr/bin/install -c inadyn-mt '/wrkdirs/dns/inadyn-mt/work/stage/usr/local/bin'
Making install in man
test -z "/usr/local/man/man5" || ../Cfg/install-sh -c -d "/wrkdirs/dns/inadyn-mt/work/stage/usr/local/man/man5"
 /usr/bin/install -c -m 644 inadyn-mt.conf.5 '/wrkdirs/dns/inadyn-mt/work/stage/usr/local/man/man5'
test -z "/usr/local/man/man8" || ../Cfg/install-sh -c -d "/wrkdirs/dns/inadyn-mt/work/stage/usr/local/man/man8"
 /usr/bin/install -c -m 644 inadyn-mt.8 '/wrkdirs/dns/inadyn-mt/work/stage/usr/local/man/man8'
/usr/bin/make  install-data-hook
mkdir /inadyn-mt
mkdir: /inadyn-mt: Read-only file system
*** Error code 1

(DragonFly poudriere has a read-only world which catches this error easily)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-10-16 01:10:07 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wg

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 William Grzybowski 2013-10-16 02:13:39 UTC
I cannot reproduce that issue on FreeBSD:

Making install in src
test -z "/usr/local/bin" || /bin/mkdir -p
"/usr/ports/dns/inadyn-mt/work/stage/usr/local/bin"
  install  -s -o root -g wheel -m 555 inadyn-mt
'/usr/ports/dns/inadyn-mt/work/stage/usr/local/bin'
Making install in man
test -z "/usr/local/man/man5" || /bin/mkdir -p
"/usr/ports/dns/inadyn-mt/work/stage/usr/local/man/man5"
 install  -o root -g wheel -m 444 inadyn-mt.conf.5
'/usr/ports/dns/inadyn-mt/work/stage/usr/local/man/man5'
test -z "/usr/local/man/man8" || /bin/mkdir -p
"/usr/ports/dns/inadyn-mt/work/stage/usr/local/man/man8"
 install  -o root -g wheel -m 444 inadyn-mt.8
'/usr/ports/dns/inadyn-mt/work/stage/usr/local/man/man8'
/usr/bin/make  install-data-hook
mkdir /usr/ports/dns/inadyn-mt/work/stage/usr/local/etc/inadyn-mt
mkdir /usr/ports/dns/inadyn-mt/work/stage/usr/local/etc/inadyn-mt/lang
cp ./lang/en.lng
/usr/ports/dns/inadyn-mt/work/stage/usr/local/etc/inadyn-mt/lang
install  -o root -g wheel -m 444
/usr/ports/dns/inadyn-mt/work/inadyn-mt.v.02.24.38/readme.html
/usr/ports/dns/inadyn-mt/work/inadyn-mt.v.02.24.38/AUTHORS
/usr/ports/dns/inadyn-mt/work/inadyn-mt.v.02.24.38/README
/usr/ports/dns/inadyn-mt/work/stage/usr/local/share/doc/inadyn-mt
install  -o root -g wheel -m 444
/usr/ports/dns/inadyn-mt/work/inadyn-mt.v.02.24.38/inadyn-mt.conf
/usr/ports/dns/inadyn-mt/work/stage/usr/local/share/examples/inadyn-mt


-- 
William Grzybowski
------------------------------------------
Curitiba/PR - Brasil
Comment 3 freebsd.contact 2013-10-16 07:57:58 UTC
On 10/16/2013 03:13, William Grzybowski wrote:
> I cannot reproduce that issue on FreeBSD:
> (snip)

The environment for DragonFly was read-only except for /usr/local, /etc,
/var.  Did you try in a similarly locked-down environment in FreeBSD?
If not, you aren't using the same conditions.

Maybe you can try to pre-create the directory in question with
permissions that make it impossible for the port to write over it, and
then you should see it.

Or just look at the makefile and identify where it's happening and
change it.

John
Comment 4 William Grzybowski 2013-10-16 12:47:58 UTC
On Wed, Oct 16, 2013 at 3:57 AM, John Marino <freebsd.contact@marino.st> wrote:
> On 10/16/2013 03:13, William Grzybowski wrote:
>> I cannot reproduce that issue on FreeBSD:
>> (snip)
>
> The environment for DragonFly was read-only except for /usr/local, /etc,
> /var.  Did you try in a similarly locked-down environment in FreeBSD?
> If not, you aren't using the same conditions.
>
> Maybe you can try to pre-create the directory in question with
> permissions that make it impossible for the port to write over it, and
> then you should see it.
>
> Or just look at the makefile and identify where it's happening and
> change it.

It is not happening. I cannot reproduce the issue.
I'll accept any patches.

Thank you.



-- 
William Grzybowski
------------------------------------------
Curitiba/PR - Brasil
Comment 5 freebsd.contact 2013-10-16 12:53:42 UTC
On 10/16/2013 13:47, William Grzybowski wrote:
> 
> It is not happening. I cannot reproduce the issue.
> I'll accept any patches.
> 
> Thank you.
> 
> 

two questions:
1) What exactly did you try?
2) Did you look at the install code?

You have a log that clearly shows "it's happening".  There has to be
code that is causing those messages.

(I hope you aren't waving this off as a "DragonFly" thing.  Failure to
reproduce it on FreeBSD doesn't mean it's not occurring...)

John
Comment 6 William Grzybowski 2013-10-16 13:02:32 UTC
On Wed, Oct 16, 2013 at 8:53 AM, John Marino <freebsd.contact@marino.st> wrote:
> On 10/16/2013 13:47, William Grzybowski wrote:
>>
>> It is not happening. I cannot reproduce the issue.
>> I'll accept any patches.
>>
>> Thank you.
>>
>>
>
> two questions:
> 1) What exactly did you try?

Built in my 9.2-RELEASE box.
Built in redports for 8.X and 9.X both i386 and amd64

> 2) Did you look at the install code?

Of course.

> You have a log that clearly shows "it's happening".  There has to be
> code that is causing those messages.

I also have a log that shows it is not happenning, how am I supposed
to fix a bug that I cannot reproduce in any environment I have?

> (I hope you aren't waving this off as a "DragonFly" thing.  Failure to
> reproduce it on FreeBSD doesn't mean it's not occurring...)

This package is even being used in FreeNAS (nanobsd with readonly /),
there isn't anything in illegal area.


-- 
William Grzybowski
------------------------------------------
Curitiba/PR - Brasil
Comment 7 freebsd.contact 2013-10-16 13:07:47 UTC
On 10/16/2013 14:02, William Grzybowski wrote:
> On Wed, Oct 16, 2013 at 8:53 AM, John Marino <freebsd.contact@marino.st> wrote:
>> On 10/16/2013 13:47, William Grzybowski wrote:
>>>
>>> It is not happening. I cannot reproduce the issue.
>>> I'll accept any patches.
>>>
>>> Thank you.
>>>
>>>
>>
>> two questions:
>> 1) What exactly did you try?
> 
> Built in my 9.2-RELEASE box.
> Built in redports for 8.X and 9.X both i386 and amd64

None of those will create a read-only environment.
You also didn't try precreating the directory as I suggested.
If those things worked, you would have seen this already, right?


> 
>> 2) Did you look at the install code?
> 
> Of course.
> 
>> You have a log that clearly shows "it's happening".  There has to be
>> code that is causing those messages.
> 
> I also have a log that shows it is not happenning, how am I supposed
> to fix a bug that I cannot reproduce in any environment I have?

But you can't just pretend the log doesn't exist.  There has to be
explanation for it.  Until we understand what causes the messages, how
can we say it's not a problem?  or that the problem doesn't pertain the
FreeBSD?

> 
>> (I hope you aren't waving this off as a "DragonFly" thing.  Failure to
>> reproduce it on FreeBSD doesn't mean it's not occurring...)
> 
> This package is even being used in FreeNAS (nanobsd with readonly /),
> there isn't anything in illegal area.

Well, maybe not.  Or maybe it's being installed as a package while the
violation occurs only during the building phase (very likely actually).

John
Comment 8 dfilter service freebsd_committer freebsd_triage 2013-10-16 13:16:21 UTC
Author: wg
Date: Wed Oct 16 12:16:14 2013
New Revision: 330499
URL: http://svnweb.freebsd.org/changeset/ports/330499

Log:
  dns/inadyn-mt: fix wrong install path
  
  - Fix wrong install path
  
  PR:		ports/183014

Modified:
  head/dns/inadyn-mt/Makefile

Modified: head/dns/inadyn-mt/Makefile
==============================================================================
--- head/dns/inadyn-mt/Makefile	Wed Oct 16 11:27:24 2013	(r330498)
+++ head/dns/inadyn-mt/Makefile	Wed Oct 16 12:16:14 2013	(r330499)
@@ -17,7 +17,7 @@ USE_RC_SUBR=	inadyn-mt
 GNU_CONFIGURE=	yes
 
 CONFIGURE_ARGS=	--disable-sound
-CONFIGURE_ENV+=	INSTALL_PREFIX="${STAGEDIR}${PREFIX}/etc"
+MAKE_ARGS+=	INSTALL_PREFIX="${STAGEDIR}${PREFIX}/etc"
 
 PORTDOCS=	readme.html AUTHORS README
 PORTEXAMPLES=	*
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 9 William Grzybowski 2013-10-16 13:19:29 UTC
On Wed, Oct 16, 2013 at 9:07 AM, John Marino <freebsd.contact@marino.st> wrote:
> On 10/16/2013 14:02, William Grzybowski wrote:
>> On Wed, Oct 16, 2013 at 8:53 AM, John Marino <freebsd.contact@marino.st> wrote:
>>> On 10/16/2013 13:47, William Grzybowski wrote:
>>>>
>>>> It is not happening. I cannot reproduce the issue.
>>>> I'll accept any patches.
>>>>
>>>> Thank you.
>>>>
>>>>
>>>
>>> two questions:
>>> 1) What exactly did you try?
>>
>> Built in my 9.2-RELEASE box.
>> Built in redports for 8.X and 9.X both i386 and amd64
>
> None of those will create a read-only environment.
> You also didn't try precreating the directory as I suggested.
> If those things worked, you would have seen this already, right?

If you knew how to reproduce the problem and how to fix it, why didn't
you just did so?

>>> 2) Did you look at the install code?
>>
>> Of course.
>>
>>> You have a log that clearly shows "it's happening".  There has to be
>>> code that is causing those messages.
>>
>> I also have a log that shows it is not happenning, how am I supposed
>> to fix a bug that I cannot reproduce in any environment I have?
>
> But you can't just pretend the log doesn't exist.  There has to be
> explanation for it.  Until we understand what causes the messages, how
> can we say it's not a problem?  or that the problem doesn't pertain the
> FreeBSD?

Please try r330499 and lets be done with it.


-- 
William Grzybowski
------------------------------------------
Curitiba/PR - Brasil
Comment 10 freebsd.contact 2013-10-16 13:43:32 UTC
On 10/16/2013 14:19, William Grzybowski wrote:
> On Wed, Oct 16, 2013 at 9:07 AM, John Marino <freebsd.contact@marino.st> wrote:
>> None of those will create a read-only environment.
>> You also didn't try precreating the directory as I suggested.
>> If those things worked, you would have seen this already, right?
> 
> If you knew how to reproduce the problem and how to fix it, why didn't
> you just did so?

I neither reproduced the problem on FreeBSD, nor did I know how to fix
it.  I was only suggesting ways to provoke it without having verified
that it worked.


> Please try r330499 and lets be done with it.

Yes, I confirm that the changed results in the port building
successfully now, thanks!

John
Comment 11 William Grzybowski freebsd_committer freebsd_triage 2013-10-16 13:45:39 UTC
State Changed
From-To: open->closed

Committed. Thanks!