Bug 183144 - x11-wm/compiz-plugins-main: compiz broken on 11-current
Summary: x11-wm/compiz-plugins-main: compiz broken on 11-current
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Tijl Coosemans
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-21 04:50 UTC by andy
Modified: 2013-10-28 10:00 UTC (History)
0 users

See Also:


Attachments
file.diff (14.12 KB, patch)
2013-10-21 04:50 UTC, andy
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description andy 2013-10-21 04:50:00 UTC
compiz-plugins-main needs several patches on current.  It compiles and installs successfully, but when you start compiz there are no window decorations or borders.  Starting compiz on the command line produces the following error message:

/usr/local/lib/compiz/libanimation.so: Undefined symbol "animGetI"

Fix: Attached patch was written by Dimitry Andric.  I confirm the patches fix the problem for me, compiz is working normally.  (Thanks for the fix Dimitry!)

The message from Dimitry is archived here:
http://www.mail-archive.com/freebsd-ports@freebsd.org/msg45807.html

"Please try applying the attached patch (easiest is to use svn patch from
the root of your ports tree).  This fixes a number of problems with
inline functions in compiz-plugins-main."

Index: x11-wm/compiz-plugins-main/files/patch-include__compiz-animation.h

Dimitry broke the single patch into 4 patches that I put into x11-wm/compiz-plugins-main/files and reinstalled.  I tried to attach the 4 separate files but the form would not let me, so I attached the single patch.  I can upload the separate patches somewhere if necessary, please let me know.



Patch attached with submission follows:
How-To-Repeat: Install compiz, execute the following command:
#! /bin/sh
compiz --replace --sm-disable --ignore-desktop-hints ccp &
gtk-window-decorator --replace &
Comment 1 Tijl Coosemans freebsd_committer freebsd_triage 2013-10-23 14:28:14 UTC
State Changed
From-To: open->feedback
Comment 2 Tijl Coosemans freebsd_committer freebsd_triage 2013-10-23 14:28:14 UTC
Responsible Changed
From-To: freebsd-ports-bugs->tijl

Track.
Comment 3 Tijl Coosemans freebsd_committer freebsd_triage 2013-10-23 14:33:03 UTC
Hi,

Can you test the following:
- Remove the files/ directory again (or move it out of the way).
- Add the following line to the Makefile (where other USE_* variables
  are defined.)

USE_CSTD=	gnu89
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-10-28 09:58:22 UTC
Author: tijl
Date: Mon Oct 28 09:58:14 2013
New Revision: 331840
URL: http://svnweb.freebsd.org/changeset/ports/331840

Log:
  Add USE_CSTD=gnu89 to fix a runtime issue.  The code expects gnu89
  semantics for the inline keyword.
  
  PR:		ports/183144
  Tested by:	AN <andy@neu.net>

Modified:
  head/x11-wm/compiz-plugins-main/Makefile

Modified: head/x11-wm/compiz-plugins-main/Makefile
==============================================================================
--- head/x11-wm/compiz-plugins-main/Makefile	Mon Oct 28 09:58:03 2013	(r331839)
+++ head/x11-wm/compiz-plugins-main/Makefile	Mon Oct 28 09:58:14 2013	(r331840)
@@ -3,7 +3,7 @@
 
 PORTNAME=	compiz-plugins-main
 PORTVERSION=	0.8.4
-PORTREVISION=	4
+PORTREVISION=	5
 CATEGORIES=	x11-wm
 MASTER_SITES=	http://releases.compiz.org/${PORTVERSION}/
 
@@ -20,6 +20,7 @@ GNU_CONFIGURE=	yes
 USE_GL=		yes
 USE_BZIP2=	yes
 USES=		gettext gmake pathfix pkgconfig
+USE_CSTD=	gnu89
 USE_GNOME=	intltool
 USE_XORG=	glproto
 USE_LDCONFIG=	yes
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Tijl Coosemans freebsd_committer freebsd_triage 2013-10-28 09:58:50 UTC
State Changed
From-To: feedback->closed

Committed in r331840.