Bug 183160 - [PATCH] audio/mp3info: Fix WITH=GTK2, Stagify, Use new options.
Summary: [PATCH] audio/mp3info: Fix WITH=GTK2, Stagify, Use new options.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Sylvio Cesar Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-21 17:40 UTC by Mathieu Arnold
Modified: 2013-11-06 12:20 UTC (History)
1 user (show)

See Also:


Attachments
mp3info-0.8.5.patch (1.38 KB, patch)
2013-10-21 17:40 UTC, Mathieu Arnold
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Arnold freebsd_committer freebsd_triage 2013-10-21 17:40:00 UTC
- Fix WITH=GTK2
- Stagify
- Use new options framework.

Port maintainer (sylvio@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_8 (mode: change, diff: ports)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-10-21 17:40:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sylvio

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Mathieu Arnold freebsd_committer freebsd_triage 2013-11-06 12:14:48 UTC
State Changed
From-To: open->closed

Committed.
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-11-06 12:14:55 UTC
Author: mat
Date: Wed Nov  6 12:14:48 2013
New Revision: 332970
URL: http://svnweb.freebsd.org/changeset/ports/332970

Log:
  - Fix WITH=GTK2
  - Stagify
  - Use new options framework.
  
  maintainer timeout.
  
  PR:		ports/183160
  Submitted by:	mat

Modified:
  head/audio/mp3info/Makefile

Modified: head/audio/mp3info/Makefile
==============================================================================
--- head/audio/mp3info/Makefile	Wed Nov  6 12:12:45 2013	(r332969)
+++ head/audio/mp3info/Makefile	Wed Nov  6 12:14:48 2013	(r332970)
@@ -21,33 +21,26 @@ PORTDOCS=	ChangeLog README mp3info.txt
 OPTIONS_DEFINE=	GTK2
 GTK2_DESC=	Enable to have the gmp3info
 
-PLIST_FILES=	bin/mp3info \
-		%%WITH_GTK%%bin/gmp3info
+GTK2_USES=		pkgconfig
+GTK2_USE=		GNOME=gtk20
+GTK2_ALL_TARGET=	gmp3info
+GTK2_PLIST_FILES=	bin/gmp3info
 
-MAN1=		mp3info.1
-NO_STAGE=	yes
+PLIST_FILES=	bin/mp3info man/man1/mp3info.1.gz
 
 ALL_TARGET=	doc mp3info
 
 .include <bsd.port.options.mk>
 
+do-install:
+	${INSTALL_PROGRAM} ${WRKSRC}/mp3info ${STAGEDIR}${PREFIX}/bin
+	${INSTALL_MAN} ${WRKSRC}/mp3info.1 ${STAGEDIR}${PREFIX}/man/man1
 .if ${PORT_OPTIONS:MGTK2}
-USE_GNOME+=	gtk20
-ALL_TARGET+=	gmp3info
-MAKE_ARGS=	install-gmp3info
-PLIST_SUB+=	WITH_GTK=""
-.else
-PLIST_SUB+=	WITH_GTK="@comment "
+	${INSTALL_PROGRAM} ${WRKSRC}/gmp3info ${STAGEDIR}${PREFIX}/bin
 .endif
-
-do-install:
-	${INSTALL_PROGRAM} ${WRKSRC}/mp3info ${PREFIX}/bin
-	${INSTALL_MAN} ${WRKSRC}/mp3info.1 ${PREFIX}/man/man1
-.if !defined(NOPORTDOCS)
-	@${MKDIR} ${DOCSDIR}
-.for docs in ${PORTDOCS}
-	${INSTALL_DATA} ${WRKSRC}/${docs} ${DOCSDIR}
-.endfor
+.if ${PORT_OPTIONS:MDOCS}
+	@${MKDIR} ${STAGEDIR}${DOCSDIR}
+	cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} ${STAGEDIR}${DOCSDIR}
 .endif
 
 .include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"