Bug 183175 - [PATCH] textproc/the_silver_searcher: Convert to staging
Summary: [PATCH] textproc/the_silver_searcher: Convert to staging
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Mathieu Arnold
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-22 09:10 UTC by Mathieu Arnold
Modified: 2013-10-22 11:20 UTC (History)
1 user (show)

See Also:


Attachments
the_silver_searcher-0.17.patch (2.03 KB, patch)
2013-10-22 09:10 UTC, Mathieu Arnold
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Arnold freebsd_committer freebsd_triage 2013-10-22 09:10:00 UTC
- Convert to staging
- Use new LIB_DEPENDS format
- convert some spaces to tabs to shut portlint up

Port maintainer (gslin@gslin.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_8 (mode: change, diff: ports)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-10-22 09:10:07 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-10-22 09:10:07 UTC
Maintainer of textproc/the_silver_searcher,

Please note that PR ports/183175 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/183175

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Mathieu Arnold freebsd_committer freebsd_triage 2013-10-22 09:14:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->mat

Take
Comment 4 gslin 2013-10-22 10:45:33 UTC
Thanks, but I think MAN1 should not be removed according to:

http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-manpages.html

I'm okay about the rest part.

On Tue, Oct 22, 2013 at 08:10:07AM +0000, Edwin Groothuis wrote:
> Maintainer of textproc/the_silver_searcher,
> 
> Please note that PR ports/183175 has just been submitted.
> 
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
> 
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/183175
> 
> -- 
> Edwin Groothuis via the GNATS Auto Assign Tool
> edwin@FreeBSD.org

-- 
* Gea-Suan Lin  (public key: Using https://keyserver.pgp.com/ to search)
* If you cannot convince them, confuse them.           -- Harry S Truman
Comment 5 Mathieu Arnold freebsd_committer freebsd_triage 2013-10-22 11:07:20 UTC
+--On 22 octobre 2013 10:00:01 +0000 Gea-Suan Lin <gslin@gslin.org> wrote:
|  Thanks, but I think MAN1 should not be removed according to:
|  
|  http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefi
| le-manpages.html  
|  I'm okay about the rest part.

The handbook is not quite up-to-date with staging, but we definitively are
dropping the MANX macros and listing the man pages in the plist.

I'll commit the patch, thanks.

-- 
Mathieu Arnold
Comment 6 Mathieu Arnold freebsd_committer freebsd_triage 2013-10-22 11:11:04 UTC
State Changed
From-To: feedback->closed

Committed, thanks!
Comment 7 dfilter service freebsd_committer freebsd_triage 2013-10-22 11:11:08 UTC
Author: mat
Date: Tue Oct 22 10:11:00 2013
New Revision: 331247
URL: http://svnweb.freebsd.org/changeset/ports/331247

Log:
  - Convert to staging
  - Use new LIB_DEPENDS format
  - convert some spaces to tabs to shut portlint up
  
  PR:		ports/183175
  Submitted by:	mat
  Approved by:	maintainer

Modified:
  head/textproc/the_silver_searcher/Makefile
  head/textproc/the_silver_searcher/pkg-descr
  head/textproc/the_silver_searcher/pkg-plist

Modified: head/textproc/the_silver_searcher/Makefile
==============================================================================
--- head/textproc/the_silver_searcher/Makefile	Tue Oct 22 09:53:35 2013	(r331246)
+++ head/textproc/the_silver_searcher/Makefile	Tue Oct 22 10:11:00 2013	(r331247)
@@ -9,7 +9,7 @@ CATEGORIES=	textproc
 MAINTAINER=	gslin@gslin.org
 COMMENT=	A code-searching tool similar to ack but faster
 
-LIB_DEPENDS=	pcre:${PORTSDIR}/devel/pcre
+LIB_DEPENDS=	libpcre.so:${PORTSDIR}/devel/pcre
 
 USE_GITHUB=	yes
 GH_ACCOUNT=	ggreer
@@ -21,15 +21,12 @@ AUTOMAKE_ARGS+=	--add-missing
 GNU_CONFIGURE=	yes
 CONFIGURE_ARGS=	LZMA_LIBS=-llzma
 .if exists(/usr/include/lzma.h)
-CONFIGURE_ARGS+= LZMA_CFLAGS=-I/usr/include
+CONFIGURE_ARGS+=	LZMA_CFLAGS=-I/usr/include
 .else
-LIB_DEPENDS+=	lzma:${PORTSDIR}/archivers/xz
-CONFIGURE_ARGS+= LZMA_CFLAGS=-I${LOCALBASE}/include
+LIB_DEPENDS+=	liblzma.so:${PORTSDIR}/archivers/xz
+CONFIGURE_ARGS+=	LZMA_CFLAGS=-I${LOCALBASE}/include
 .endif
 USE_AUTOTOOLS=	aclocal autoconf autoheader automake
 USES=		pkgconfig
 
-MAN1=		ag.1
-
-NO_STAGE=	yes
 .include <bsd.port.mk>

Modified: head/textproc/the_silver_searcher/pkg-descr
==============================================================================
--- head/textproc/the_silver_searcher/pkg-descr	Tue Oct 22 09:53:35 2013	(r331246)
+++ head/textproc/the_silver_searcher/pkg-descr	Tue Oct 22 10:11:00 2013	(r331247)
@@ -1,4 +1,4 @@
 An attempt to make something better than ack, which itself is better than
 grep.
 
-WWW:	https://github.com/ggreer/the_silver_searcher
+WWW: https://github.com/ggreer/the_silver_searcher

Modified: head/textproc/the_silver_searcher/pkg-plist
==============================================================================
--- head/textproc/the_silver_searcher/pkg-plist	Tue Oct 22 09:53:35 2013	(r331246)
+++ head/textproc/the_silver_searcher/pkg-plist	Tue Oct 22 10:11:00 2013	(r331247)
@@ -1,4 +1,5 @@
 bin/ag
+man/man1/ag.1.gz
 share/the_silver_searcher/completions/ag.bashcomp.sh
 @dirrm share/the_silver_searcher/completions
 @dirrm share/the_silver_searcher
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"