Bug 183197 - [PATCH] textproc/sgmlformat: Fix with perl >= 5.16
Summary: [PATCH] textproc/sgmlformat: Fix with perl >= 5.16
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jun Kuriyama
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-22 12:00 UTC by Mathieu Arnold
Modified: 2013-11-06 12:40 UTC (History)
1 user (show)

See Also:

Attachments
sgmlformat-1.7_3.patch (1.48 KB, patch)
2013-10-22 12:00 UTC, Mathieu Arnold 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Arnold freebsd_committer freebsd_triage 2013-10-22 12:00:00 UTC 
newgetopt.pl was deprecated in 5.14, so, it doesn't work any more with 5.16+.
As Getopt::Long has been there for ages (and is in all supported perls in the
port tree,) this seemed the easiest way to fix it.

Port maintainer (kuriyama@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_8 (mode: change, diff: ports)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-10-22 12:00:08 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->kuriyama

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Mathieu Arnold freebsd_committer freebsd_triage 2013-11-06 12:30:51 UTC 
State Changed
From-To: open->closed

Committed, thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-11-06 12:30:57 UTC 
Author: mat
Date: Wed Nov  6 12:30:49 2013
New Revision: 332981
URL: http://svnweb.freebsd.org/changeset/ports/332981

Log:
  newgetopt.pl was deprecated in 5.14, so, it doesn't work any more with 5.16+.
  As Getopt::Long has been there for ages (and is in all supported perls in the
  port tree,) this seemed the easiest way to fix it.
  
  maintainer timeout
  PR:		ports/183197
  Submitted by:	mat

Modified:
  head/textproc/sgmlformat/Makefile
  head/textproc/sgmlformat/files/patch-sgmlfmt.pl

Modified: head/textproc/sgmlformat/Makefile
==============================================================================
--- head/textproc/sgmlformat/Makefile	Wed Nov  6 12:28:58 2013	(r332980)
+++ head/textproc/sgmlformat/Makefile	Wed Nov  6 12:30:49 2013	(r332981)
@@ -3,7 +3,7 @@
 
 PORTNAME=	sgmlformat
 PORTVERSION=	1.7
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	textproc print
 MASTER_SITES=	${MASTER_SITE_LOCAL}
 MASTER_SITE_SUBDIR=	kuriyama

Modified: head/textproc/sgmlformat/files/patch-sgmlfmt.pl
==============================================================================
--- head/textproc/sgmlformat/files/patch-sgmlfmt.pl	Wed Nov  6 12:28:58 2013	(r332980)
+++ head/textproc/sgmlformat/files/patch-sgmlfmt.pl	Wed Nov  6 12:30:49 2013	(r332981)
@@ -1,5 +1,14 @@
---- sgmlfmt/sgmlfmt.pl.orig	Tue Sep 15 21:05:47 1998
-+++ sgmlfmt/sgmlfmt.pl	Tue Sep  4 15:27:32 2001
+--- sgmlfmt/sgmlfmt.pl.orig	1998-09-15 23:05:47.000000000 +0200
++++ sgmlfmt/sgmlfmt.pl	2013-10-22 12:52:49.000000000 +0200
+@@ -32,7 +32,7 @@
+ # project.  
+ 
+ 
+-require 'newgetopt.pl';
++use Getopt::Long;
+ 
+ #
+ # Where to find DTDs and related files
 @@ -151,19 +151,15 @@
      open (outfile, ">$fileroot.trf");
      &sgmlparse(infile, "roff");
@@ -24,3 +33,12 @@
      unlink("${fileroot}.trf");
  }
  
+@@ -655,7 +651,7 @@
+ 
+ sub main {
+     # Check arguments
+-    if (!&NGetOpt('d=s', 'f=s', 'links', 'i:s@', 'hdr=s', 'ftr=s', 'e=s')) {
++    if (!GetOptions('d=s', 'f=s', 'links', 'i:s@', 'hdr=s', 'ftr=s', 'e=s')) {
+ 	&usage;
+ 	exit 1;
+     }
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"