Bug 183504 - security/sssd: Fix krb5-config detection on 8.3-RELEASE (1386,amd64)
Summary: security/sssd: Fix krb5-config detection on 8.3-RELEASE (1386,amd64)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: William Grzybowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-30 22:30 UTC by lukas.slebodnik
Modified: 2013-11-01 10:50 UTC (History)
0 users

See Also:


Attachments
file.diff (3.18 KB, patch)
2013-10-30 22:30 UTC, lukas.slebodnik
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description lukas.slebodnik 2013-10-30 22:30:00 UTC
Wrong krb5-config was detected on FreeBSD 8.3
  checking for krb5-config... /usr/bin/krb5-config
  checking for working krb5-config... yes
And therefore different krb5.h header file was used in configuration phase and building phase. Result of this wrong detection was compilation error
./src/util/sss_krb5.h:98: error: conflicting types for 'krb5_expire_callback_func'
/usr/local/include/krb5/krb5.h:6920: error: previous declaration of 'krb5_expire_callback_func' was here

Log files from failed build.
http://beefy2.isc.freebsd.org/bulk/83amd64-default/2013-10-30_01h02m50s/logs/sssd-1.9.5.log
http://beefy1.isc.freebsd.org/bulk/83i386-default/2013-10-30_01h01m05s/logs/sssd-1.9.5.log

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-11-01 02:38:00 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wg

wg@ wants this submitter's PRs (via the GNATS Auto Assign Tool)
Comment 2 William Grzybowski freebsd_committer freebsd_triage 2013-11-01 10:44:04 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-11-01 10:44:06 UTC
Author: wg
Date: Fri Nov  1 10:43:53 2013
New Revision: 332351
URL: http://svnweb.freebsd.org/changeset/ports/332351

Log:
  security/sssd: fix krb5 detection on 8.3
  
  PR:		ports/183504
  Submitted by:	Lukas Slebodnik <lukas.slebodnik intrak.sk> (maintainer)

Added:
  head/security/sssd/files/patch-src__external__krb5.m4   (contents, props changed)
  head/security/sssd/files/patch-src__external__pac_responder.m4   (contents, props changed)
  head/security/sssd/files/patch-src__responder__pac__pacsrv_utils.c   (contents, props changed)

Added: head/security/sssd/files/patch-src__external__krb5.m4
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/security/sssd/files/patch-src__external__krb5.m4	Fri Nov  1 10:43:53 2013	(r332351)
@@ -0,0 +1,25 @@
+From b7947258702e250dbf569bb9cd74f1e73f0c94bb Mon Sep 17 00:00:00 2001
+From: Lukas Slebodnik <lukas.slebodnik@intrak.sk>
+Date: Wed, 30 Oct 2013 08:53:42 +0100
+Subject: [PATCH 1/4] patch-src__external__krb5.m4
+
+---
+ src/external/krb5.m4 | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git src/external/krb5.m4 src/external/krb5.m4
+index 71239c9..63c8ece 100644
+--- src/external/krb5.m4
++++ src/external/krb5.m4
+@@ -9,7 +9,7 @@ if test x$KRB5_CFLAGS != x; then
+     KRB5_PASSED_CFLAGS=$KRB5_CFLAGS
+ fi
+ 
+-AC_PATH_PROG(KRB5_CONFIG, krb5-config)
++AC_PATH_PROG(KRB5_CONFIG, krb5-config, [], [/usr/local/bin:$PATH])
+ AC_MSG_CHECKING(for working krb5-config)
+ if test -x "$KRB5_CONFIG"; then
+   KRB5_CFLAGS="`$KRB5_CONFIG --cflags`"
+-- 
+1.8.0
+

Added: head/security/sssd/files/patch-src__external__pac_responder.m4
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/security/sssd/files/patch-src__external__pac_responder.m4	Fri Nov  1 10:43:53 2013	(r332351)
@@ -0,0 +1,25 @@
+From b52128bc333fd4717a96950ef8fb4171f25fabcf Mon Sep 17 00:00:00 2001
+From: Lukas Slebodnik <lukas.slebodnik@intrak.sk>
+Date: Wed, 30 Oct 2013 08:54:41 +0100
+Subject: [PATCH 2/4] patch-src__external__pac_responder.m4
+
+---
+ src/external/pac_responder.m4 | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git src/external/pac_responder.m4 src/external/pac_responder.m4
+index 49d5cbb..2b4ca5c 100644
+--- src/external/pac_responder.m4
++++ src/external/pac_responder.m4
+@@ -14,7 +14,7 @@ then
+     PKG_CHECK_MODULES(NDR_KRB5PAC, ndr_krb5pac, ndr_krb5pac_ok=yes,
+         AC_MSG_WARN([Cannot build pac responder without libndr_krb5pac]))
+ 
+-    AC_PATH_PROG(KRB5_CONFIG, krb5-config)
++    AC_PATH_PROG(KRB5_CONFIG, krb5-config, [], [/usr/local/bin:$PATH])
+     AC_MSG_CHECKING(for supported MIT krb5 version)
+     KRB5_VERSION="`$KRB5_CONFIG --version`"
+     case $KRB5_VERSION in
+-- 
+1.8.0
+

Added: head/security/sssd/files/patch-src__responder__pac__pacsrv_utils.c
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/security/sssd/files/patch-src__responder__pac__pacsrv_utils.c	Fri Nov  1 10:43:53 2013	(r332351)
@@ -0,0 +1,23 @@
+From 93a41acb0f1434d1638cc796c4529a135d61409d Mon Sep 17 00:00:00 2001
+From: Lukas Slebodnik <lukas.slebodnik@intrak.sk>
+Date: Wed, 30 Oct 2013 10:49:27 +0100
+Subject: [PATCH 4/4] patch-src__responder__pac__pacsrv_utils.c
+
+---
+ src/responder/pac/pacsrv_utils.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git src/responder/pac/pacsrv_utils.c src/responder/pac/pacsrv_utils.c
+index 3ac7b84..6052432 100644
+--- src/responder/pac/pacsrv_utils.c
++++ src/responder/pac/pacsrv_utils.c
+@@ -18,6 +18,7 @@
+    You should have received a copy of the GNU General Public License
+    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
++#include <sys/types.h>
+ #include <stdbool.h>
+ #include <util/data_blob.h>
+ #include <gen_ndr/security.h>
+-- 
+1.8.0
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"