Bug 183703 - Poudriere build failure for net/unison
Summary: Poudriere build failure for net/unison
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-05 23:20 UTC by Kevin Zheng
Modified: 2013-11-07 23:00 UTC (History)
0 users

See Also:


Attachments
unison.diff (2.35 KB, patch)
2013-11-06 15:45 UTC, Guido Falsi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Zheng 2013-11-05 23:20:00 UTC
The build for net/unison in Poudriere fails with the following message:

(if [ -f unison-text ]; then ./unison-text -doc install > INSTALLATION; fi)
gmake tags
bash: not found
gmake[1]: Entering directory `/wrkdirs/usr/ports/net/unison/work/unison-2.40.102'
if [ -f `which etags` ]; then \
    etags *.mli */*.mli *.ml */*.ml */*.m *.c */*.c *.txt \
          ; fi 
etags: not found
gmake[1]: [tags] Error 127 (ignored)
gmake[1]: Leaving directory `/wrkdirs/usr/ports/net/unison/work/unison-2.40.102'
gmake: Leaving directory `/wrkdirs/usr/ports/net/unison/work/unison-2.40.102'
===========================================================================
=======================<phase: run-depends    >============================
===>   unison-2.40.102_1 depends on executable: lablgtk2 - found
===>   unison-2.40.102_1 depends on executable: update-desktop-database - found
===========================================================================
=======================<phase: stage          >============================
===>  Staging for unison-2.40.102_1
===>   Generating temporary packing list
install  -s -o root -g wheel -m 555 /wrkdirs/usr/ports/net/unison/work/unison-2.40.102/unison /wrkdirs/usr/ports/net/unison/work/stage/usr/local/bin
cd /wrkdirs/usr/ports/net/unison/work/unison-2.40.102 && install  -o root -g wheel -m 444  /wrkdirs/usr/ports/net/unison/work/stage/usr/local/share/doc/unison
usage: install [-bCcpSsUv] [-f flags] [-g group] [-m mode] [-o owner]
               [-M log] [-D dest] [-h hash] [-T tags]
               [-B suffix] [-l linkflags] [-N dbdir]
               file1 file2
       install [-bCcpSsUv] [-f flags] [-g group] [-m mode] [-o owner]
               [-M log] [-D dest] [-h hash] [-T tags]
               [-B suffix] [-l linkflags] [-N dbdir]
               file1 ... fileN directory
       install -dU [-vU] [-g group] [-m mode] [-N dbdir] [-o owner]
               [-M log] [-D dest] [-h hash] [-T tags]
               directory ...
*** [post-install] Error code 64

Stop in /usr/ports/net/unison.
===>  Cleaning for unison-2.40.102_1
build of /usr/ports/net/unison ended at Tue Nov  5 02:01:05 CST 2013
build time: 00:01:08
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-11-05 23:20:10 UTC
Responsible Changed
From-To: freebsd-ports-bugs->madpilot

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2013-11-06 15:45:05 UTC
Hi,

Thanks for your report.

 From he error message it looks like you're trying to compile unison 
with the DOCS option disabled. Can you confirm this?

If that's the case, please test the attached patch (relative to the net 
directory, will touch all the unison ports, which all share the same 
problem) and report back?

CCing mandree so he can check and approve, if it works, the patch 
against unison232.

-- 
Guido Falsi <madpilot@FreeBSD.org>
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2013-11-06 15:46:01 UTC
State Changed
From-To: open->feedback

Ask for subitter's feedback.
Comment 4 Kevin Zheng 2013-11-06 18:36:19 UTC
Hi Guido,

Yes, I am indeed building without the DOCS option set. At the moment I'm
unable to test the patch; I will follow up later today.

Thanks,
Kevin Zheng
Comment 5 Kevin Zheng 2013-11-06 23:52:51 UTC
Hi there,

On 11/06/2013 09:45, Guido Falsi wrote:
> From the error message it looks like you're trying to compile unison with
> the DOCS option disabled. Can you confirm this?

That is correct; I have the DOCS option unset.

> If that's the case, please test the attached patch (relative to the net
> directory, will touch all the unison ports, which all share the same
> problem) and report back?

I've applied the patch to my ports tree on poudriere and now net/unison
builds perfectly fine.

Thanks,
Kevin Zheng
Comment 6 dfilter service freebsd_committer freebsd_triage 2013-11-07 20:01:23 UTC
Author: mandree
Date: Thu Nov  7 20:01:15 2013
New Revision: 333150
URL: http://svnweb.freebsd.org/changeset/ports/333150

Log:
  - Fix build with DOCS option disabled [1]
  - Remove dependency on desktop-file-utils, we do not install MIME types.
  
  PR:		183703 [1]
  Submitted by:	madpilot [1]

Modified:
  head/net/unison232/Makefile

Modified: head/net/unison232/Makefile
==============================================================================
--- head/net/unison232/Makefile	Thu Nov  7 19:57:29 2013	(r333149)
+++ head/net/unison232/Makefile	Thu Nov  7 20:01:15 2013	(r333150)
@@ -3,7 +3,7 @@
 
 PORTNAME=	unison
 PORTVERSION=	2.32.52
-PORTREVISION=	4
+PORTREVISION=	5
 CATEGORIES=	net
 MASTER_SITES=	http://www.cis.upenn.edu/~bcpierce/unison/download/releases/${DISTNAME}/
 PKGNAMESUFFIX=	232
@@ -24,17 +24,15 @@ MAKE_ARGS=	CFLAGS=""
 
 MAKE_JOBS_UNSAFE=	yes
 
-OPTIONS_DEFINE= DOCS X11
-OPTIONS_DEFAULT=	DOCS X11
-
-.include <bsd.port.options.mk>
-
-.if ${PORT_OPTIONS:MDOCS}
 DOCS=		BUGS.txt NEWS README
 DOCSDIR=	${PREFIX}/share/doc/${PORTNAME}${PKGNAMESUFFIX}
 EXTRA_DOCS=	${PORTNAME}-${PORTVERSION}-manual.html \
 		${PORTNAME}-${PORTVERSION}-manual.pdf ${PORTNAME}-${PORTVERSION}-manual.ps
-.endif
+
+OPTIONS_DEFINE=		DOCS X11
+OPTIONS_DEFAULT=	DOCS X11
+
+.include <bsd.port.options.mk>
 
 .if ${PORT_OPTIONS:MX11}
 MAKE_ARGS+=	UISTYLE=gtk2
@@ -45,7 +43,6 @@ BUILD_DEPENDS+=	ocamlc:${PORTSDIR}/lang/
 RUN_DEPENDS+=	lablgtk2:${PORTSDIR}/x11-toolkits/ocaml-lablgtk2
 PATCH_DEPENDS+=	${BUILD_DEPENDS}
 CONFLICTS+=	ocaml-nox11*
-USE_GNOME=	desktopfileutils
 SUB_FILES+=	${PORTNAME}.desktop
 PLIST_FILES+=	share/pixmaps/${PORTNAME}${PKGNAMESUFFIX}.png
 .else
@@ -78,7 +75,6 @@ post-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME}-text ${STAGEDIR}${PREFIX}/bin/${PORTNAME}${PKGNAMESUFFIX}-text
 	${MKDIR} ${STAGEDIR}${DESKTOPDIR}
 	${INSTALL_DATA} ${WRKDIR}/${PORTNAME}.desktop ${STAGEDIR}${DESKTOPDIR}/${PORTNAME}${PKGNAMESUFFIX}.desktop
-	-update-desktop-database > /dev/null
 	@${INSTALL_DATA} ${WRKSRC}/win32rc/U_4_48x48x32.png ${STAGEDIR}${PREFIX}/share/pixmaps/${PORTNAME}${PKGNAMESUFFIX}.png
 .endif
 
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 7 dfilter service freebsd_committer freebsd_triage 2013-11-07 22:51:09 UTC
Author: madpilot
Date: Thu Nov  7 22:51:01 2013
New Revision: 333161
URL: http://svnweb.freebsd.org/changeset/ports/333161

Log:
  - Fix build with DOCS option disabled [1]
  - Remove dependency on desktop-file-utils, we do not install MIME
    types. [2]
  
  PR:		ports/183703 [1]
  Submitted by:	Me [1]
  Noticed by:	mandree [2]

Modified:
  head/net/unison-devel/Makefile
  head/net/unison/Makefile

Modified: head/net/unison-devel/Makefile
==============================================================================
--- head/net/unison-devel/Makefile	Thu Nov  7 22:35:19 2013	(r333160)
+++ head/net/unison-devel/Makefile	Thu Nov  7 22:51:01 2013	(r333161)
@@ -3,7 +3,7 @@
 
 PORTNAME=	unison
 PORTVERSION=	2.45.28
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	net
 MASTER_SITES=	http://www.cis.upenn.edu/~bcpierce/unison/download/releases/${DISTNAME}/
 PKGNAMESUFFIX=	-devel
@@ -22,6 +22,10 @@ WANT_GNOME=	yes
 MAKE_ARGS=	CFLAGS=""
 CONFLICTS=	unison-[0-9]* unison-nox11-[0-9]*
 
+DOCS=		BUGS.txt NEWS README
+EXTRA_DOCS=	unison-${PORTVERSION}-manual.html \
+		unison-${PORTVERSION}-manual.pdf unison-${PORTVERSION}-manual.ps
+
 OPTIONS_DEFINE=	DOCS X11
 OPTIONS_DEFAULT=	DOCS X11
 
@@ -30,12 +34,6 @@ ALL_TARGET=	unison all
 
 .include <bsd.port.options.mk>
 
-.if ${PORT_OPTIONS:MDOCS}
-DOCS=		BUGS.txt NEWS README
-EXTRA_DOCS=	unison-${PORTVERSION}-manual.html \
-		unison-${PORTVERSION}-manual.pdf unison-${PORTVERSION}-manual.ps
-.endif
-
 .if ${PORT_OPTIONS:MX11}
 MAKE_ARGS+=	UISTYLE=gtk2
 PLIST_SUB+=	TEXT=""
@@ -45,7 +43,6 @@ BUILD_DEPENDS+=	ocamlc:${PORTSDIR}/lang/
 RUN_DEPENDS+=	lablgtk2:${PORTSDIR}/x11-toolkits/ocaml-lablgtk2
 PATCH_DEPENDS+=	${BUILD_DEPENDS}
 CONFLICTS+=	ocaml-nox11*
-USE_GNOME=	desktopfileutils
 SUB_FILES+=	${PORTNAME}.desktop
 PLIST_FILES+=	share/pixmaps/${PORTNAME}.png
 .else
@@ -82,7 +79,6 @@ post-install:
 	@${INSTALL_PROGRAM} ${WRKSRC}/unison-text ${STAGEDIR}${PREFIX}/bin
 	@${MKDIR} ${STAGEDIR}${DESKTOPDIR}
 	@${INSTALL_DATA} ${WRKDIR}/${PORTNAME}.desktop ${STAGEDIR}${DESKTOPDIR}
-	@-update-desktop-database > /dev/null
 	@${INSTALL_DATA} ${WRKSRC}/win32rc/U_4_48x48x32.png ${STAGEDIR}${PREFIX}/share/pixmaps/${PORTNAME}.png
 .endif
 

Modified: head/net/unison/Makefile
==============================================================================
--- head/net/unison/Makefile	Thu Nov  7 22:35:19 2013	(r333160)
+++ head/net/unison/Makefile	Thu Nov  7 22:51:01 2013	(r333161)
@@ -3,7 +3,7 @@
 
 PORTNAME=	unison
 PORTVERSION=	2.40.102
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	net
 MASTER_SITES=	http://www.cis.upenn.edu/~bcpierce/unison/download/releases/${DISTNAME}/
 DISTFILES=	${EXTRACT_ONLY} ${EXTRA_DOCS}
@@ -24,17 +24,15 @@ CONFLICTS?=	unison-devel-[0-9]* unison-n
 MAKE_JOBS_UNSAFE=	yes
 ALL_TARGET=	unison all
 
+DOCS=		BUGS.txt NEWS README
+EXTRA_DOCS=	unison-${PORTVERSION}-manual.html \
+		unison-${PORTVERSION}-manual.pdf unison-${PORTVERSION}-manual.ps
+
 OPTIONS_DEFINE= DOCS X11
 OPTIONS_DEFAULT?=        DOCS X11
 
 .include <bsd.port.options.mk>
 
-.if ${PORT_OPTIONS:MDOCS}
-DOCS=		BUGS.txt NEWS README
-EXTRA_DOCS=	unison-${PORTVERSION}-manual.html \
-		unison-${PORTVERSION}-manual.pdf unison-${PORTVERSION}-manual.ps
-.endif
-
 .if ${PORT_OPTIONS:MX11}
 MAKE_ARGS+=	UISTYLE=gtk2
 PLIST_SUB+=	TEXT=""
@@ -44,7 +42,6 @@ BUILD_DEPENDS+=	ocamlc:${PORTSDIR}/lang/
 RUN_DEPENDS+=	lablgtk2:${PORTSDIR}/x11-toolkits/ocaml-lablgtk2
 PATCH_DEPENDS+=	${BUILD_DEPENDS}
 CONFLICTS+=	ocaml-nox11*
-USE_GNOME=	desktopfileutils
 SUB_FILES+=	${PORTNAME}.desktop
 PLIST_FILES+=	share/pixmaps/${PORTNAME}.png
 .else
@@ -78,7 +75,6 @@ post-install:
 	@${INSTALL_PROGRAM} ${WRKSRC}/unison-text ${STAGEDIR}${PREFIX}/bin
 	@${MKDIR} ${STAGEDIR}${DESKTOPDIR}
 	@${INSTALL_DATA} ${WRKDIR}/${PORTNAME}.desktop ${STAGEDIR}${DESKTOPDIR}
-	@-update-desktop-database > /dev/null
 	@${INSTALL_DATA} ${WRKSRC}/win32rc/U_4_48x48x32.png ${STAGEDIR}${PREFIX}/share/pixmaps/${PORTNAME}.png
 .endif
 
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 8 Guido Falsi freebsd_committer freebsd_triage 2013-11-07 22:51:22 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!