Bug 183921 - [maintainer update] devel/etcd port updated with fix and new feature
Summary: [maintainer update] devel/etcd port updated with fix and new feature
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: William Grzybowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-13 10:40 UTC by Bartek Rutkowski
Modified: 2013-11-13 12:20 UTC (History)
0 users

See Also:

Attachments
file.diff (720 bytes, patch)
2013-11-13 10:40 UTC, Bartek Rutkowski 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bartek Rutkowski freebsd_committer freebsd_triage 2013-11-13 10:40:00 UTC 
This update does two things:

* corrects the package prefix to 'coreos-' instead of 'coreos'
* adds option to build a commandline tool from devel/etcdctl

WARNING - this update relies on devel/etcdctl which is not yet in ports, and was submitted in http://www.freebsd.org/cgi/query-pr.cgi?pr=183845 - that should be accepted before commiting this update to devel/etcd

Fix: Patch attached.

Patch attached with submission follows:
How-To-Repeat: Apply the patch to the Makefile, test the port, commit the change.
Comment 1 William Grzybowski freebsd_committer freebsd_triage 2013-11-13 12:01:37 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->wg

I'll take it.
Comment 2 William Grzybowski freebsd_committer freebsd_triage 2013-11-13 12:11:38 UTC 
State Changed
From-To: open->closed

Committed. Thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-11-13 12:11:38 UTC 
Author: wg
Date: Wed Nov 13 12:11:30 2013
New Revision: 333678
URL: http://svnweb.freebsd.org/changeset/ports/333678

Log:
  devel/etcd: fix pkg prefix and add option
  
  - Fix pkg name prefix to include a dash
  - Add an option to install etcdctl
  
  PR:		ports/183921
  Submitted by:	maintainer

Modified:
  head/devel/etcd/Makefile

Modified: head/devel/etcd/Makefile
==============================================================================
--- head/devel/etcd/Makefile	Wed Nov 13 12:01:18 2013	(r333677)
+++ head/devel/etcd/Makefile	Wed Nov 13 12:11:30 2013	(r333678)
@@ -2,8 +2,9 @@
 
 PORTNAME=	etcd
 PORTVERSION=	0.1.2
+PORTREVISION=	1
 CATEGORIES=	devel
-PKGNAMEPREFIX=	coreos
+PKGNAMEPREFIX=	coreos-
 
 MAINTAINER=	ports@robakdesign.com
 COMMENT=	Highly-available key value store and service discovery
@@ -19,17 +20,18 @@ PLIST_FILES=	bin/${PORTNAME}
 
 PORTDOCS=	README.md
 
-NO_BUILD=	yes
-
-OPTIONS_DEFINE=	DOCS
+OPTIONS_DEFINE=	DOCS ETCDCTL
 DOCS_DESC=	Install etcd README file
 
+ETCDCTL_DESC=	Install etcdctl commandline tool
+ETCDCTL_RUN_DEPENDS=	etcdctl:${PORTSDIR}/devel/etcdctl
+
 post-patch:
 	@${REINPLACE_CMD} -e 's|$$VER|${DISTVERSION}|' ${WRKSRC}/scripts/release-version
 	@${REINPLACE_CMD} -e '/VER=/d' ${WRKSRC}/scripts/release-version
 
-pre-install:
-	@(cd ${WRKSRC}; ${SH} build)
+do-build:
+	cd ${WRKSRC}; ${SH} build
 
 do-install:
 	${MKDIR} ${STAGEDIR}${DOCSDIR}
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"