Bug 183956 - lang/clang32 update default C++ library to libc++ on FreeBSD 10 and higher
Summary: lang/clang32 update default C++ library to libc++ on FreeBSD 10 and higher
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Brooks Davis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-14 16:40 UTC by Daniel Peyrolon
Modified: 2013-11-15 01:40 UTC (History)
0 users

See Also:


Attachments
file.diff (3.69 KB, patch)
2013-11-14 16:40 UTC, Daniel Peyrolon
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Peyrolon freebsd_committer freebsd_triage 2013-11-14 16:40:00 UTC
Apply the clang portion of r255321 from base switching the default C++ library to libc++ on 10+.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-11-14 16:40:07 UTC
Responsible Changed
From-To: freebsd-ports-bugs->brooks

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-11-15 01:35:25 UTC
Author: brooks
Date: Fri Nov 15 01:35:17 2013
New Revision: 333812
URL: http://svnweb.freebsd.org/changeset/ports/333812

Log:
  Apply the clang portion of r255321 from base switching the default C++
  library to libc++ on 10+.
  
  PR:		ports/183956
  Submitted by:	dpl

Added:
  head/lang/clang32/files/patch-tools_clang_lib_Driver_ToolChains.cpp   (contents, props changed)
  head/lang/clang32/files/patch-tools_clang_lib_Driver_ToolChains.h   (contents, props changed)
Modified:
  head/lang/clang32/Makefile

Modified: head/lang/clang32/Makefile
==============================================================================
--- head/lang/clang32/Makefile	Fri Nov 15 01:30:05 2013	(r333811)
+++ head/lang/clang32/Makefile	Fri Nov 15 01:35:17 2013	(r333812)
@@ -2,7 +2,7 @@
 
 PORTNAME=	clang
 DISTVERSION=	3.2
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	lang devel
 MASTER_SITES=	http://llvm.org/releases/${PORTVERSION}/
 PKGNAMESUFFIX=	${LLVM_SUFFIX}

Added: head/lang/clang32/files/patch-tools_clang_lib_Driver_ToolChains.cpp
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/lang/clang32/files/patch-tools_clang_lib_Driver_ToolChains.cpp	Fri Nov 15 01:35:17 2013	(r333812)
@@ -0,0 +1,44 @@
+
+$FreeBSD$
+
+--- tools/clang/lib/Driver/ToolChains.cpp.orig
++++ tools/clang/lib/Driver/ToolChains.cpp
+@@ -1950,6 +1950,38 @@
+   }
+ }
+ 
++ToolChain::CXXStdlibType
++FreeBSD::GetCXXStdlibType(const ArgList &Args) const {
++  if (Arg *A = Args.getLastArg(options::OPT_stdlib_EQ)) {
++    StringRef Value = A->getValue();
++    if (Value == "libc++")
++      return ToolChain::CST_Libcxx;
++    if (Value == "libstdc++")
++      return ToolChain::CST_Libstdcxx;
++    getDriver().Diag(diag::err_drv_invalid_stdlib_name)
++      << A->getAsString(Args);
++  }
++
++  return getTriple().getOSMajorVersion() >= 10 ? ToolChain::CST_Libcxx :
++         ToolChain::CST_Libstdcxx;
++}
++
++void FreeBSD::AddClangCXXStdlibIncludeArgs(const ArgList &DriverArgs,
++                                          ArgStringList &CC1Args) const {
++  if (DriverArgs.hasArg(options::OPT_nostdlibinc) ||
++      DriverArgs.hasArg(options::OPT_nostdincxx))
++    return;
++
++  if (GetCXXStdlibType(DriverArgs) == ToolChain::CST_Libcxx)
++    addSystemInclude(DriverArgs, CC1Args,
++                     getDriver().SysRoot + "/usr/include/c++/v1");
++  else
++    addSystemInclude(DriverArgs, CC1Args,
++                     getDriver().SysRoot + "/usr/include/c++/4.2");
++  return;
++
++}
++
+ /// NetBSD - NetBSD tool chain which can call as(1) and ld(1) directly.
+ 
+ NetBSD::NetBSD(const Driver &D, const llvm::Triple& Triple, const ArgList &Args)

Added: head/lang/clang32/files/patch-tools_clang_lib_Driver_ToolChains.h
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/lang/clang32/files/patch-tools_clang_lib_Driver_ToolChains.h	Fri Nov 15 01:35:17 2013	(r333812)
@@ -0,0 +1,20 @@
+
+$FreeBSD$
+
+--- tools/clang/lib/Driver/ToolChains.h.orig
++++ tools/clang/lib/Driver/ToolChains.h
+@@ -463,9 +463,14 @@
+ public:
+   FreeBSD(const Driver &D, const llvm::Triple& Triple, const ArgList &Args);
+ 
++  virtual CXXStdlibType GetCXXStdlibType(const ArgList &Args) const;
++
+   virtual bool IsMathErrnoDefault() const { return false; }
+   virtual bool IsObjCNonFragileABIDefault() const { return true; }
+ 
++  virtual void AddClangCXXStdlibIncludeArgs(const ArgList &DriverArgs,
++                                            ArgStringList &CC1Args) const;
++
+   virtual Tool &SelectTool(const Compilation &C, const JobAction &JA,
+                            const ActionList &Inputs) const;
+ };
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Brooks Davis freebsd_committer freebsd_triage 2013-11-15 01:35:29 UTC
State Changed
From-To: open->closed

Committed.  Thanks!