Bug 184115 - [PATCH] net-mgmt/flow-tools-ng: new OPTIONS framework
Summary: [PATCH] net-mgmt/flow-tools-ng: new OPTIONS framework
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-20 10:50 UTC by Muhammad Moinur Rahman
Modified: 2013-11-20 19:20 UTC (History)
1 user (show)

See Also:


Attachments
flow-tools-ng-0.68.5.1.patch (3.59 KB, patch)
2013-11-20 10:50 UTC, Muhammad Moinur Rahman
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-11-20 10:50:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sunpoet

sunpoet@ wants this submitter's PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-11-20 10:50:09 UTC
Maintainer of net-mgmt/flow-tools-ng,

Please note that PR ports/184115 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/184115

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2013-11-20 10:50:10 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 c.kworr 2013-11-20 12:23:17 UTC
Hi all!

1. Dup of http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/183782
2. Tested with different option combinations - works for me.
3. NO_STAGE is not needed here.

-- 
Sphinx of black quartz, judge my vow.
Comment 5 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2013-11-20 15:07:41 UTC
Hi,

Just one point. As this port needs to write /etc/passwd so I believe
STAGING will not work and hence NO_STAGE should be added. Let me your
thoughts.

Br,
Muhammad


On Wed, Nov 20, 2013 at 6:23 PM, Volodymyr Kostyrko <c.kworr@gmail.com>wrote:

> Hi all!
>
> 1. Dup of http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/183782
> 2. Tested with different option combinations - works for me.
> 3. NO_STAGE is not needed here.
>
> --
> Sphinx of black quartz, judge my vow.
>
Comment 6 c.kworr 2013-11-20 15:29:40 UTC
20.11.2013 17:07, Muhammad Moinur Rahman wrote:
> Just one point. As this port needs to write /etc/passwd so I believe
> STAGING will not work and hence NO_STAGE should be added. Let me your
> thoughts.

Port doesn't change /etc/passwd, it just instructs package manager which 
users/groups should be created/reused.

-- 
Sphinx of black quartz, judge my vow.
Comment 7 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2013-11-20 17:30:05 UTC
So you want to say that it is not a violation of STAGE framework. Although
POUDRIERE throws an error. :(


On Wed, Nov 20, 2013 at 9:29 PM, Volodymyr Kostyrko <c.kworr@gmail.com>wrote:

> 20.11.2013 17:07, Muhammad Moinur Rahman wrote:
>
>> Just one point. As this port needs to write /etc/passwd so I believe
>> STAGING will not work and hence NO_STAGE should be added. Let me your
>> thoughts.
>>
>
> Port doesn't change /etc/passwd, it just instructs package manager which
> users/groups should be created/reused.
>
>
> --
> Sphinx of black quartz, judge my vow.
>
Comment 8 Po-Chuan Hsieh freebsd_committer freebsd_triage 2013-11-20 19:12:55 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 9 dfilter service freebsd_committer freebsd_triage 2013-11-20 19:12:55 UTC
Author: sunpoet
Date: Wed Nov 20 19:12:47 2013
New Revision: 334443
URL: http://svnweb.freebsd.org/changeset/ports/334443

Log:
  - Add LICENSE
  - Convert to new options framework
  - Convert to new options helper
  - While I'm here, sort PLIST
  
  PR:		ports/184115
  Submitted by:	Muhammad Moinur Rahman <5u623l20@gmail.com>
  Approved by:	Volodymyr Kostyrko <c.kworr@gmail.com> (maintainer)

Modified:
  head/net-mgmt/flow-tools-ng/Makefile   (contents, props changed)
  head/net-mgmt/flow-tools-ng/pkg-plist   (contents, props changed)

Modified: head/net-mgmt/flow-tools-ng/Makefile
==============================================================================
--- head/net-mgmt/flow-tools-ng/Makefile	Wed Nov 20 19:10:14 2013	(r334442)
+++ head/net-mgmt/flow-tools-ng/Makefile	Wed Nov 20 19:12:47 2013	(r334443)
@@ -10,6 +10,19 @@ PKGNAMESUFFIX=	-ng
 MAINTAINER=	c.kworr@gmail.com
 COMMENT=	Suite of tools and library to work with netflow data
 
+LICENSE=	BSD
+
+OPTIONS_DEFINE=	MYSQL OPENSSL PGSQL
+PGSQL_CONFIGURE_OFF=	--without-postgresql
+PGSQL_CONFIGURE_ON=	--with-postgresql
+PGSQL_USE=		PGSQL=yes
+MYSQL_CONFIGURE_OFF=	--without-mysql
+MYSQL_CONFIGURE_ON=	--with-mysql="${PREFIX}"
+MYSQL_USE=		MYSQL=yes
+OPENSSL_CONFIGURE_OFF=	--without-openssl
+OPENSSL_CONFIGURE_ON=	--with-openssl="${OPENSSLBASE}"
+OPENSSL_USE=		OPENSSL=yes
+
 CONFLICTS=	flow-tools-[0-9]*
 
 USE_PYTHON_RUN=	yes
@@ -44,28 +57,8 @@ FLOW_CAPTURE_UID=	174
 FLOW_CAPTURE_GID=	174
 FLOW_CAPTURE_PIDDIR=	${VARDIR}/run/flow-capture
 
-.if defined(WITH_PGSQL)
-CONFIGURE_ARGS+=--with-postgresql
-USE_PGSQL=	yes
-.else
-CONFIGURE_ARGS+=--without-postgresql
-.endif
-
-.if defined(WITH_MYSQL)
-CONFIGURE_ARGS+=--with-mysql="${PREFIX}"
-USE_MYSQL=	yes
-.else
-CONFIGURE_ARGS+=--without-mysql
-.endif
-
-.if defined(WITH_OPENSSL)
-USE_OPENSSL=	Yes
-CONFIGURE_ARGS+=--with-openssl="${OPENSSLBASE}"
-.else
-CONFIGURE_ARGS+=--without-openssl
-.endif
-
 NO_STAGE=	yes
+
 post-patch:
 	@${REINPLACE_CMD}\
 	 -e 's|@sysconfdir@/sym/|${PREFIX}/share/flow-tools/|' \

Modified: head/net-mgmt/flow-tools-ng/pkg-plist
==============================================================================
--- head/net-mgmt/flow-tools-ng/pkg-plist	Wed Nov 20 19:10:14 2013	(r334442)
+++ head/net-mgmt/flow-tools-ng/pkg-plist	Wed Nov 20 19:12:47 2013	(r334443)
@@ -1,44 +1,44 @@
 bin/flow-capture
 bin/flow-cat
-bin/flow-stat
-bin/flow-print
 bin/flow-dscan
-bin/flow-send
-bin/flow-receive
-bin/flow-gen
 bin/flow-expire
-bin/flow-filter
 bin/flow-export
+bin/flow-fanout
+bin/flow-filter
+bin/flow-gen
 bin/flow-header
-bin/flow-split
-bin/flow-xlate
-bin/flow-merge
 bin/flow-import
-bin/flow-fanout
-bin/flow-tag
+bin/flow-log2rrd
+bin/flow-mask
+bin/flow-merge
 bin/flow-nfilter
+bin/flow-print
+bin/flow-receive
 bin/flow-report
-bin/flow-mask
-bin/flow-log2rrd
-bin/flow-rptfmt
 bin/flow-rpt2rrd
-etc/flow-tools/map.cfg
-etc/flow-tools/tag.cfg
+bin/flow-rptfmt
+bin/flow-send
+bin/flow-split
+bin/flow-stat
+bin/flow-tag
+bin/flow-xlate
+etc/flow-tools/asn.sym
 etc/flow-tools/filter.cfg
-etc/flow-tools/stat.cfg
-etc/flow-tools/mask.cfg
-etc/flow-tools/xlate.cfg
 etc/flow-tools/ip-prot.sym
 etc/flow-tools/ip-type.sym
-etc/flow-tools/tcp-port.sym
-etc/flow-tools/asn.sym
+etc/flow-tools/map.cfg
+etc/flow-tools/mask.cfg
+etc/flow-tools/stat.cfg
+etc/flow-tools/tag.cfg
 etc/flow-tools/tag.sym
+etc/flow-tools/tcp-port.sym
+etc/flow-tools/xlate.cfg
 include/ftlib.h
 include/ftqueue.h
-lib/libft.so.0
-lib/libft.so
-lib/libft.la
 lib/libft.a
+lib/libft.la
+lib/libft.so
+lib/libft.so.0
 %%DATADIR%%/asn2c
 %%DATADIR%%/gasn
 %%DATADIR%%/gprot
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"