Building the port multimedia/tstools on my 6-way SMP system breaks in various, non-reproducible ways, most of the time. Apparently it is not able to work correctly with multiple make jobs. For example: cc obj/pcapreport.o -o bin/pcapreport -g -lm -Llib -ltstools obj/pcapreport.o: In function `main': pcapreport.c:(.text+0x453): undefined reference to `ethernet_packet_from_pcap' gmake: *** [bin/pcapreport] Error 1 Or: cc obj/ts2es.o -o bin/ts2es -g -lm -Llib -ltstools obj/esfilter.o: In function `main': esfilter.c:(.text+0x126e): undefined reference to `tswrite_open' gmake: *** [bin/esfilter] Error 1 Or various other ways. Sometimes the build succeeds (about 24% of the time). Adding the following line to the Makefile fixes it: MAKE_JOBS_UNSAFE= yes With that line, the port builds fine reproducible on all systems that I've tried. Fix: Add this line to the port's Makefile: MAKE_JOBS_UNSAFE= yes How-To-Repeat: Try to build multimedia/tstools on a 6-way SMP system. However, whether the problem occurs or not seems to depend on the number of cores, and maybe it also depends on timing and other things. Sometimes it even succeeds on the same system. On my 6-way system (AMD Phenom II X6) the problem occured about 75% of the time. On a 2-way system (Intel Atom) that I've tried, however, the port built just fine on three consecutive attempts.
Maintainer of multimedia/tstools, Please note that PR ports/184210 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/184210 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
On Sun, 24 Nov 2013 12:40:08 UT Edwin Groothuis <edwin@FreeBSD.ORG> wrote: > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/184210 > I have no problem with this suggested fix. Please commit it. -jr
State Changed From-To: feedback->open Maintainer approved.
Author: jadawin Date: Wed Nov 27 15:05:34 2013 New Revision: 335020 URL: http://svnweb.freebsd.org/changeset/ports/335020 Log: - Mark MAKE_JOBS_UNSAFE=yes - While here support STAGEDIR PR: ports/184210 Submitted by: Oliver Fromme <oliver.fromme@secnetix.de> Approved by: maintainer Modified: head/multimedia/tstools/Makefile (contents, props changed) Modified: head/multimedia/tstools/Makefile ============================================================================== --- head/multimedia/tstools/Makefile Wed Nov 27 14:58:29 2013 (r335019) +++ head/multimedia/tstools/Makefile Wed Nov 27 15:05:34 2013 (r335020) @@ -13,6 +13,8 @@ COMMENT= MPEG transport, program, and el LICENSE= MPL +MAKE_JOBS_UNSAFE= yes + USES= gmake MAKE_ARGS= CC="${CC}" CFLAGS="${CFLAGS}" @@ -22,15 +24,14 @@ PORTDOCS= * OPTIONS_DEFINE= DOCS -NO_STAGE= yes .include <bsd.port.options.mk> do-install: - ${CP} ${WRKSRC}/bin/* ${PREFIX}/bin - ${CP} ${WRKSRC}/lib/* ${PREFIX}/lib + ${CP} ${WRKSRC}/bin/* ${STAGEDIR}${PREFIX}/bin + ${CP} ${WRKSRC}/lib/* ${STAGEDIR}${PREFIX}/lib .if ${PORT_OPTIONS:MDOCS} - @${MKDIR} ${DOCSDIR} - ${CP} ${WRKSRC}/docs/* ${DOCSDIR} + @${MKDIR} ${STAGEDIR}${DOCSDIR} + ${CP} ${WRKSRC}/docs/* ${STAGEDIR}${DOCSDIR} .endif .include <bsd.port.mk> _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed, with minor changes. Thanks!