Bug 184775 - revision 336423 breaks math/numpy build
Summary: revision 336423 breaks math/numpy build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Kubilay Kocak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-15 13:00 UTC by rsmith
Modified: 2014-07-02 01:14 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description rsmith 2013-12-15 13:00:00 UTC
	
* It is not allowed to have shell commands without a target in a Makefile
* The last ECHO_MSG is missing its closing quotation mark.

Fix: 

Revert 336423
How-To-Repeat: 	
root@slackbox:/usr/ports/math/py-numpy # make
"Makefile", line 60: Need an operator
"Makefile", line 61: Need an operator
"Makefile", line 62: Need an operator
"Makefile", line 63: Need an operator
"Makefile", line 64: Need an operator
"Makefile", line 65: Need an operator
make: fatal errors encountered -- cannot continue
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2013-12-15 13:15:42 UTC
Responsible Changed
From-To: freebsd-ports-bugs->koobs

I'll take it, my pointyhat.
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-12-15 13:20:12 UTC
Author: koobs
Date: Sun Dec 15 13:20:00 2013
New Revision: 336526
URL: http://svnweb.freebsd.org/changeset/ports/336526

Log:
  math/py-numpy: Add missing ending quotation to ECHO_MSG
  
  Add a missing ending quotation from the last ECHO_MSG command added in r336423.
  
  PR:		ports/184775
  Reported by:	Roland Smith <rsmith@xs4all.nl>

Modified:
  head/math/py-numpy/Makefile

Modified: head/math/py-numpy/Makefile
==============================================================================
--- head/math/py-numpy/Makefile	Sun Dec 15 13:04:55 2013	(r336525)
+++ head/math/py-numpy/Makefile	Sun Dec 15 13:20:00 2013	(r336526)
@@ -62,7 +62,7 @@ BUILD_DEPENDS+=	${LOCALBASE}/lib/libalap
 @${ECHO_MSG} "for numpy to function correctly. Ensure it is"
 @${ECHO_MSG} "selected in the configuration dialog when prompted, or"
 @${ECHO_MSG} "Ctrl-C now and reinstall the atlas port with the option"
-@${ECHO_MSG} "enabled.
+@${ECHO_MSG} "enabled."
 sleep 5
 .else
 LIB_DEPENDS+=	lapack.4:${PORTSDIR}/math/lapack \
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-12-15 15:02:37 UTC
Author: koobs
Date: Sun Dec 15 15:02:30 2013
New Revision: 336541
URL: http://svnweb.freebsd.org/changeset/ports/336541

Log:
  math/py-numpy: Remove Atlas WITH_STATIC notification using ECHO_MSG
  
  Shell commands can't be used in a Makefile without a target. Remove the atlas
  WITH_STATIC messaging until a more suitable mechanism can be found.
  
  PR:		ports/184775
  Reported by:	Roland Smith <rsmith@xs4all.nl>

Modified:
  head/math/py-numpy/Makefile

Modified: head/math/py-numpy/Makefile
==============================================================================
--- head/math/py-numpy/Makefile	Sun Dec 15 14:32:28 2013	(r336540)
+++ head/math/py-numpy/Makefile	Sun Dec 15 15:02:30 2013	(r336541)
@@ -56,14 +56,6 @@ DISTFILES+=	${FP_ARCH}/fenv.c?p=203441:f
 
 .if ${PORT_OPTIONS:MATLAS}
 LIB_DEPENDS+=	atlas.2:${PORTSDIR}/math/atlas
-BUILD_DEPENDS+=	${LOCALBASE}/lib/libalapack.a
-@${ECHO_MSG}
-@${ECHO_MSG} "Atlas *must* be built with the WITH_STATIC option"
-@${ECHO_MSG} "for numpy to function correctly. Ensure it is"
-@${ECHO_MSG} "selected in the configuration dialog when prompted, or"
-@${ECHO_MSG} "Ctrl-C now and reinstall the atlas port with the option"
-@${ECHO_MSG} "enabled."
-sleep 5
 .else
 LIB_DEPENDS+=	lapack.4:${PORTSDIR}/math/lapack \
 		blas.2:${PORTSDIR}/math/blas
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Shane 2013-12-16 00:23:12 UTC
Just an idea for a better solution --

.if ${PORT_OPTIONS:MATLAS}
LIB_DEPENDS+=	libatlas.so:${PORTSDIR}/math/atlas
.if !exists(${LOCALBASE}/lib/libalapack.a)
IGNORE=	atlas needs to be built with STATIC for numpy to function properly
.endif
.else
LIB_DEPENDS+=	liblapack.so:${PORTSDIR}/math/lapack \
		libblas.so:${PORTSDIR}/math/blas
.endif
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2014-07-02 01:14:22 UTC
(In reply to FreeBSD from comment #4)
> Just an idea for a better solution --
> 
> .if ${PORT_OPTIONS:MATLAS}
> LIB_DEPENDS+=	libatlas.so:${PORTSDIR}/math/atlas
> .if !exists(${LOCALBASE}/lib/libalapack.a)
> IGNORE=	atlas needs to be built with STATIC for numpy to function properly
> .endif
> .else
> LIB_DEPENDS+=	liblapack.so:${PORTSDIR}/math/lapack \
> 		libblas.so:${PORTSDIR}/math/blas
> .endif

This was the original cause of bug 178094, who's resolution resulted in this issue report :)

Resolving since the impact of this issue report has been addressed.