Bug 184874 - graphics/gtimelapse: Fix build with clang
Summary: graphics/gtimelapse: Fix build with clang
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-16 18:10 UTC by tkato432
Modified: 2013-12-20 18:50 UTC (History)
0 users

See Also:


Attachments
file.diff (2.00 KB, patch)
2013-12-16 18:10 UTC, tkato432
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description tkato432 2013-12-16 18:10:20 UTC
- Fix build with clang
- Add DESKTOP_ENTRIES

New file:
files/patch-src__gtimelapse.cpp
Comment 1 Pawel Pekala freebsd_committer freebsd_triage 2013-12-20 18:25:22 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pawel

I'll take it.
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-12-20 18:34:27 UTC
Author: pawel
Date: Fri Dec 20 18:34:20 2013
New Revision: 337065
URL: http://svnweb.freebsd.org/changeset/ports/337065

Log:
  - Fix build with clang
  - Add DESKTOP_ENTRIES
  - Port supports staging
  
  PR:		ports/184874
  Submitted by:	KATO Tsuguru <tkato432@yahoo.com>

Added:
  head/graphics/gtimelapse/files/
  head/graphics/gtimelapse/files/patch-src__gtimelapse.cpp   (contents, props changed)
Modified:
  head/graphics/gtimelapse/Makefile   (contents, props changed)

Modified: head/graphics/gtimelapse/Makefile
==============================================================================
--- head/graphics/gtimelapse/Makefile	Fri Dec 20 18:30:53 2013	(r337064)
+++ head/graphics/gtimelapse/Makefile	Fri Dec 20 18:34:20 2013	(r337065)
@@ -3,24 +3,28 @@
 
 PORTNAME=	gtimelapse
 DISTVERSION=	0.1
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	graphics
 MASTER_SITES=	SF/${PORTNAME}/Relase	# yes, this is not a typo (here)
 
 MAINTAINER=	ports@FreeBSD.org
-COMMENT=	An application for capturing images to generate timelapse videos
+COMMENT=	Application for capturing images to generate timelapse videos
 
 LICENSE=	GPLv2
 
-LIB_DEPENDS=	gphoto2.2:${PORTSDIR}/graphics/libgphoto2
+LIB_DEPENDS=	libgphoto2.so:${PORTSDIR}/graphics/libgphoto2
+
+WRKSRC=		${WRKDIR}/${PORTNAME}
 
-GNU_CONFIGURE=	yes
-CONFIGURE_ARGS=	--with-wx-config=${WX_CONFIG}
 USES=		pkgconfig
 USE_WX=		2.8+
-WRKSRC=		${WRKDIR}/${PORTNAME}
+WX_CONF_ARGS=	absolute
+USE_AUTOTOOLS=	libtoolize aclocal automake autoconf
+LIBTOOLIZE_ARGS=--copy --force
+AUTOMAKE_ARGS=	--add-missing --copy
 
 PLIST_FILES=	bin/${PORTNAME}
 
-NO_STAGE=	yes
+DESKTOP_ENTRIES="gTimelapse" "" "" "${PORTNAME}" "Graphics;GTK;" ""
+
 .include <bsd.port.mk>

Added: head/graphics/gtimelapse/files/patch-src__gtimelapse.cpp
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/graphics/gtimelapse/files/patch-src__gtimelapse.cpp	Fri Dec 20 18:34:20 2013	(r337065)
@@ -0,0 +1,25 @@
+--- src/gtimelapse.cpp.orig
++++ src/gtimelapse.cpp
+@@ -155,7 +155,11 @@
+ 					//cout << "type: RADIO" << endl;
+ 					//cout << "current: " << current << endl;
+ 
++#ifdef __clang__
++					wxString *choices = new wxString[cnt];
++#else
+ 					wxString choices[cnt];
++#endif
+ 					
+ 					for ( i=0; i<cnt; i++) {
+ 						const char *choice;
+@@ -165,6 +169,10 @@
+ 						choices[i] = mystring;
+ 					}
+ 			
++#ifdef __clang__
++					delete [] choices;
++#endif
++
+ 					wxString title(label, wxConvUTF8);
+ 					wxString default_choice(current, wxConvUTF8);
+ 					wxString choice_label(uselabel, wxConvUTF8);
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Pawel Pekala freebsd_committer freebsd_triage 2013-12-20 18:34:29 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-12-20 18:43:25 UTC
Author: mat
Date: Fri Dec 20 18:43:17 2013
New Revision: 337068
URL: http://svnweb.freebsd.org/changeset/ports/337068

Log:
  MFH: r337065
  
  - Fix build with clang
  - Add DESKTOP_ENTRIES
  - Port supports staging
  
  PR:		ports/184874
  Submitted by:	KATO Tsuguru <tkato432@yahoo.com>
  Approved by:	portmgr (implicit)

Added:
  branches/2014Q1/graphics/gtimelapse/files/
     - copied from r337065, head/graphics/gtimelapse/files/
Modified:
  branches/2014Q1/graphics/gtimelapse/Makefile   (contents, props changed)
Directory Properties:
  branches/2014Q1/   (props changed)

Modified: branches/2014Q1/graphics/gtimelapse/Makefile
==============================================================================
--- branches/2014Q1/graphics/gtimelapse/Makefile	Fri Dec 20 18:41:56 2013	(r337067)
+++ branches/2014Q1/graphics/gtimelapse/Makefile	Fri Dec 20 18:43:17 2013	(r337068)
@@ -3,24 +3,28 @@
 
 PORTNAME=	gtimelapse
 DISTVERSION=	0.1
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	graphics
 MASTER_SITES=	SF/${PORTNAME}/Relase	# yes, this is not a typo (here)
 
 MAINTAINER=	ports@FreeBSD.org
-COMMENT=	An application for capturing images to generate timelapse videos
+COMMENT=	Application for capturing images to generate timelapse videos
 
 LICENSE=	GPLv2
 
-LIB_DEPENDS=	gphoto2.2:${PORTSDIR}/graphics/libgphoto2
+LIB_DEPENDS=	libgphoto2.so:${PORTSDIR}/graphics/libgphoto2
+
+WRKSRC=		${WRKDIR}/${PORTNAME}
 
-GNU_CONFIGURE=	yes
-CONFIGURE_ARGS=	--with-wx-config=${WX_CONFIG}
 USES=		pkgconfig
 USE_WX=		2.8+
-WRKSRC=		${WRKDIR}/${PORTNAME}
+WX_CONF_ARGS=	absolute
+USE_AUTOTOOLS=	libtoolize aclocal automake autoconf
+LIBTOOLIZE_ARGS=--copy --force
+AUTOMAKE_ARGS=	--add-missing --copy
 
 PLIST_FILES=	bin/${PORTNAME}
 
-NO_STAGE=	yes
+DESKTOP_ENTRIES="gTimelapse" "" "" "${PORTNAME}" "Graphics;GTK;" ""
+
 .include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"