Since the commiter switched to a custom install, the permissions were wrong. The binary must have the setuid bit to allow scoring. bin/nsnake will be installed as games:games and setuid set. Then we create /var/db/nsnake for saving best scores. Fix: I'm currently new to staging so I hope this looks correct.
Maintainer of games/nsnake, Please note that PR ports/184920 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/184920 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
2013/12/17 Edwin Groothuis <edwin@freebsd.org>: > Maintainer of games/nsnake, > > Please note that PR ports/184920 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/184920 > > -- > Edwin Groothuis via the GNATS Auto Assign Tool > edwin@FreeBSD.org Since I'm the maintainer I agree. -- Demelier David
State Changed From-To: feedback->open This is actually a MAINTAINER-UPDATE
Responsible Changed From-To: freebsd-ports-bugs->marino I'll take it.
Author: marino Date: Sun Jan 19 18:16:46 2014 New Revision: 340328 URL: http://svnweb.freebsd.org/changeset/ports/340328 QAT: https://qat.redports.org/buildarchive/r340328/ Log: games/nsnake: games/nsnake: fix permissions and fix score file Support stage too. PR: ports/184920 Approved by: maintainer timeout Added: head/games/nsnake/pkg-plist (contents, props changed) Modified: head/games/nsnake/Makefile Modified: head/games/nsnake/Makefile ============================================================================== --- head/games/nsnake/Makefile Sun Jan 19 18:04:35 2014 (r340327) +++ head/games/nsnake/Makefile Sun Jan 19 18:16:46 2014 (r340328) @@ -3,6 +3,7 @@ PORTNAME= nsnake PORTVERSION= 1.4 +PORTREVISION= 1 CATEGORIES= games MASTER_SITES= http://releases.malikania.fr/nsnake/ EXTRACT_SUFX= .tgz @@ -13,12 +14,8 @@ COMMENT= Snake game written in C and ncu LICENSE= MIT OPTIONS_DEFINE= DOCS +OPTIONS_SUB= yes -MAN6= ${PORTNAME}.6 -PORTDOCS= CHANGELOG -PLIST_FILES= bin/${PORTNAME} - -NO_STAGE= yes .include <bsd.port.options.mk> do-build: @@ -26,11 +23,11 @@ do-build: do-install: (cd ${WRKSRC} \ - && ${INSTALL_PROGRAM} ${PORTNAME} ${PREFIX}/bin \ - && ${INSTALL_MAN} ${PORTNAME}.6 ${MANPREFIX}/man/man6) + && ${INSTALL_PROGRAM} ${PORTNAME} ${STAGEDIR}${PREFIX}/bin \ + && ${INSTALL_MAN} ${PORTNAME}.6 ${STAGEDIR}${MANPREFIX}/man/man6) .if ${PORT_OPTIONS:MDOCS} - @${MKDIR} ${DOCSDIR} - (cd ${WRKSRC} && ${INSTALL_DATA} CHANGELOG ${DOCSDIR}) + @${MKDIR} ${STAGEDIR}${DOCSDIR} + (cd ${WRKSRC} && ${INSTALL_DATA} CHANGELOG ${STAGEDIR}${DOCSDIR}) .endif .include <bsd.port.mk> Added: head/games/nsnake/pkg-plist ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/games/nsnake/pkg-plist Sun Jan 19 18:16:46 2014 (r340328) @@ -0,0 +1,10 @@ +@owner games +@group games +@mode 4555 +bin/nsnake +man/man6/nsnake.6.gz +%%DOCS%%%%DOCSDIR%%/CHANGELOG +%%DOCS%%@dirrm %%DOCSDIR%% +@mode +@exec mkdir -p /var/db/nsnake +@exec chown games:games /var/db/nsnake _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed, with minor changes. Thanks! This actually was not a maintainer update, but it did time out so I took care of it rather than change the status again.