Bug 184973 - conflicts with db clients deps in net/turnserver port
Summary: conflicts with db clients deps in net/turnserver port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-18 17:10 UTC by arnaud.houdelette
Modified: 2014-07-28 19:03 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description arnaud.houdelette 2013-12-18 17:10:01 UTC
net/turnserver ports use both USE_MYSQL / USE_PGSQL and LIB_DEPENDS for databases dependencies : 

USE_MYSQL=      yes
LIB_DEPENDS+=   mysqlclient:${PORTSDIR}/databases/mysql55-client
..

USE_PGSQL=      yes
LIB_DEPENDS+=   pq:${PORTSDIR}/databases/postgresql90-client

doing so causes conflicts when not using default database clients (ie. mariadb).

Fix: 

remove following lines from Makefile :

LIB_DEPENDS+=   mysqlclient:${PORTSDIR}/databases/mysql55-client

LIB_DEPENDS+=   pq:${PORTSDIR}/databases/postgresql90-client
How-To-Repeat: Try to build port with WITH_MYSQL=55m
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-12-18 17:32:17 UTC
Maintainer of net/turnserver,

Please note that PR ports/184973 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/184973

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-12-18 17:32:18 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 mom040267 2014-05-14 07:04:21 UTC
I am the maintainer of the package net/turnserver. I noticed that there is
a problem report in regard to my package.

I checked the proposed fix and I approve it.

Please go ahead with the fix. I am going to upgrade soon to the new
upstream version, and this bug holds the upgrade.

Thanks
Oleg
Comment 4 John Marino freebsd_committer freebsd_triage 2014-07-26 10:33:58 UTC
maintainer approved this.
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-07-28 19:01:01 UTC
A commit references this bug:

Author: marino
Date: Mon Jul 28 19:00:10 UTC 2014
New revision: 363230
URL: http://svnweb.freebsd.org/changeset/ports/363230

Log:
  net/turnserver: Resolve potential db client conflicts

  The libevent2 commit to this port achieved half of the changes outlined
  in the PR.

  PR:		184973
  Submitted by:	Arnaud Houdelette
  Approved by:	maintainer (Oleg Moskalenko)

Changes:
  head/net/turnserver/Makefile
Comment 6 John Marino freebsd_committer freebsd_triage 2014-07-28 19:03:04 UTC
Thanks!