Bug 185369 - [bsd.pkgng.mk] _FORCE_POST_PATTERNS no longer works with pkg 1.2.4_1
Summary: [bsd.pkgng.mk] _FORCE_POST_PATTERNS no longer works with pkg 1.2.4_1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-31 14:00 UTC by Antoine Brodin
Modified: 2014-01-17 17:35 UTC (History)
0 users

See Also:

Attachments
forcepost-staged.diff (683 bytes, patch)
2014-01-01 15:20 UTC, Antoine Brodin 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Brodin freebsd_committer freebsd_triage 2013-12-31 14:00:00 UTC 
actions listed in _FORCE_POST_PATTERNS take place in pre-deinstall and not in post-deinstall

from +MANIFEST:
"pre-deinstall":"/usr/local/bin/update-desktop-database -q > /dev/null || /usr/bin/true\n/usr/local/bin/update-mime-database /usr/local/share/mime\n...

% make -V_FORCE_POST_PATTERNS
rmdir kldxref mkfontscale mkfontdir fc-cache  fonts.dir fonts.scale gtk-update-icon-cache  gio-querymodules  gtk-query-immodules  ldconfig  load-octave-pkg  update-desktop-database update-mime-database  gdk-pixbuf-query-loaders catalog.ports  glib-compile-schemas
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-12-31 14:00:08 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

bsd.pkgng.mk is portmgr territory (via the GNATS Auto Assign Tool)
Comment 2 Antoine Brodin freebsd_committer freebsd_triage 2014-01-01 15:20:55 UTC 
Testing shows that this only affects staged ports.
do-package happens before fake-pkg on those.
The attached patch fixes the problem
Comment 3 dfilter service freebsd_committer freebsd_triage 2014-01-17 17:22:58 UTC 
Author: antoine
Date: Fri Jan 17 17:22:50 2014
New Revision: 340084
URL: http://svnweb.freebsd.org/changeset/ports/340084
QAT: https://qat.redports.org/buildarchive/r340084/

Log:
  Handle _FORCE_POST_PATTERNS for staged ports
  
  PR:		ports/185369
  Reviewed by:	bapt
  With hat:	portmgr

Modified:
  head/Mk/bsd.pkgng.mk

Modified: head/Mk/bsd.pkgng.mk
==============================================================================
--- head/Mk/bsd.pkgng.mk	Fri Jan 17 17:10:01 2014	(r340083)
+++ head/Mk/bsd.pkgng.mk	Fri Jan 17 17:22:50 2014	(r340084)
@@ -246,7 +246,7 @@ do-package: ${TMPPLIST}
 	@for cat in ${CATEGORIES}; do \
 		${RM} -f ${PACKAGES}/$$cat/${PKGNAMEPREFIX}${PORTNAME}*${PKG_SUFX} ; \
 	done
-	@if ${PKG_CREATE} ${PKG_CREATE_ARGS} -o ${PKGREPOSITORY} ${PKGNAME}; then \
+	@if ${SETENV} FORCE_POST="${_FORCE_POST_PATTERNS}" ${PKG_CREATE} ${PKG_CREATE_ARGS} -o ${PKGREPOSITORY} ${PKGNAME}; then \
 		if [ -n "${WITH_PKGNG}" ]; then \
 			if [ "${PKGORIGIN}" = "ports-mgmt/pkg" -o "${PKGORIGIN}" = "ports-mgmt/pkg-devel" ]; then \
 				if [ ! -d ${PKGLATESTREPOSITORY} ]; then \
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Antoine Brodin freebsd_committer freebsd_triage 2014-01-17 17:34:54 UTC 
State Changed
From-To: open->closed

Patch committed to head