Bug 185404 - [Patch] fix security/cryptlib build failure
Summary: [Patch] fix security/cryptlib build failure
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Alex Dupre
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-02 02:40 UTC by Stephen Hurd
Modified: 2014-01-21 16:40 UTC (History)
0 users

See Also:


Attachments
file.diff (314 bytes, patch)
2014-01-02 02:40 UTC, Stephen Hurd
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen Hurd freebsd_committer freebsd_triage 2014-01-02 02:40:00 UTC
Since the cryptlib build system explicity uses "make" for recursive makes, this causes the submakes to fail on some platforms with a cryptic "make[2]: don't know how to make w. Stop" error caused by gmake passing custom arguments to make(1).

Fix: Use system make.  Patch attached.

Patch attached with submission follows:
How-To-Repeat: Attempt to build.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-01-02 02:40:14 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ale

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2014-01-21 16:33:34 UTC
Author: ale
Date: Tue Jan 21 16:33:26 2014
New Revision: 340618
URL: http://svnweb.freebsd.org/changeset/ports/340618
QAT: https://qat.redports.org/buildarchive/r340618/

Log:
  Remove gmake dependency and stagify.
  
  PR:		ports/185404
  Submitted by:	Stephen Hurd <shurd@sasktel.net>

Modified:
  head/security/cryptlib/Makefile

Modified: head/security/cryptlib/Makefile
==============================================================================
--- head/security/cryptlib/Makefile	Tue Jan 21 16:18:52 2014	(r340617)
+++ head/security/cryptlib/Makefile	Tue Jan 21 16:33:26 2014	(r340618)
@@ -12,10 +12,11 @@ COMMENT=		Powerful security programming 
 
 ONLY_FOR_ARCHS=		i386 amd64
 
+OPTIONS_DEFINE=		DOCS
+
 USE_ZIP=		yes
 EXTRACT_BEFORE_ARGS=	-aq
 NO_WRKSUBDIR=		yes
-USES=			gmake
 MAKEFILE=		makefile
 ALL_TARGET=		default FreeBSD shared
 USE_LDCONFIG=		yes
@@ -27,9 +28,6 @@ PLIST_FILES=		include/cryptlib.h \
 
 PORTDOCS=		README
 
-NO_STAGE=	yes
-.include <bsd.port.pre.mk>
-
 post-patch:
 	@${REINPLACE_CMD} -e 's/%%CFLAGS%%/${CFLAGS}/' ${WRKSRC}/makefile
 	@${REINPLACE_CMD} -e 's/%%PTHREAD_CFLAGS%%/${PTHREAD_CFLAGS}/' ${WRKSRC}/makefile
@@ -37,15 +35,13 @@ post-patch:
 
 do-install:
 	${INSTALL_DATA} ${WRKSRC}/libcl.a ${WRKSRC}/libcl.so.${PORTVERSION} \
-		${PREFIX}/lib
-	${LN} -sf ${PREFIX}/lib/libcl.so.${PORTVERSION} ${PREFIX}/lib/libcl.so.3
-	${LN} -sf ${PREFIX}/lib/libcl.so.3 ${PREFIX}/lib/libcl.so
-	${INSTALL_DATA} ${WRKSRC}/cryptlib.h ${PREFIX}/include
+		${STAGEDIR}${PREFIX}/lib
+	${LN} -sf ${PREFIX}/lib/libcl.so.${PORTVERSION} ${STAGEDIR}${PREFIX}/lib/libcl.so.3
+	${LN} -sf ${PREFIX}/lib/libcl.so.3 ${STAGEDIR}${PREFIX}/lib/libcl.so
+	${INSTALL_DATA} ${WRKSRC}/cryptlib.h ${STAGEDIR}${PREFIX}/include
 
-.if !defined(NOPORTDOCS)
 post-install:
-	${MKDIR} ${DOCSDIR}
-	${INSTALL_DATA} ${WRKSRC}/README ${DOCSDIR}
-.endif
+	${MKDIR} ${STAGEDIR}${DOCSDIR}
+	${INSTALL_DATA} ${WRKSRC}/README ${STAGEDIR}${DOCSDIR}
 
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Alex Dupre freebsd_committer freebsd_triage 2014-01-21 16:33:40 UTC
State Changed
From-To: open->closed

Committed, thanks!