Bug 185405 - [Patch] sysutils/fonteditfs fix build when no GCC installed
Summary: [Patch] sysutils/fonteditfs fix build when no GCC installed
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-02 02:50 UTC by Stephen Hurd
Modified: 2014-01-25 14:43 UTC (History)
0 users

See Also:


Attachments
file.diff (884 bytes, patch)
2014-01-02 02:50 UTC, Stephen Hurd
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen Hurd freebsd_committer freebsd_triage 2014-01-02 02:50:00 UTC
sysutils/fonteditfs fails when no GCC is installed because "gcc" is hardcoded as the compiler.

Fix: Patch attached.  Use ${CC}

Patch attached with submission follows:
How-To-Repeat: Build without gcc.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-01-02 02:50:07 UTC
Maintainer of sysutils/fonteditfs,

Please note that PR ports/185405 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/185405

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2014-01-02 02:50:08 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 uri 2014-01-07 11:40:42 UTC
I approve the patch.


On Thu, Jan 2, 2014 at 4:50 AM, Edwin Groothuis <edwin@freebsd.org> wrote:

> Maintainer of sysutils/fonteditfs,
>
> Please note that PR ports/185405 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/185405
>
> --
> Edwin Groothuis via the GNATS Auto Assign Tool
> edwin@FreeBSD.org
>
Comment 4 John Marino freebsd_committer freebsd_triage 2014-01-19 14:48:59 UTC
State Changed
From-To: feedback->open

Maintainer has approved.
Comment 5 John Marino freebsd_committer freebsd_triage 2014-01-25 13:59:04 UTC
Responsible Changed
From-To: freebsd-ports-bugs->marino

I'll take it.
Comment 6 dfilter service freebsd_committer freebsd_triage 2014-01-25 14:38:54 UTC
Author: marino
Date: Sat Jan 25 14:38:47 2014
New Revision: 341040
URL: http://svnweb.freebsd.org/changeset/ports/341040
QAT: https://qat.redports.org/buildarchive/r341040/

Log:
  sysutils/fonteditfs: Fix on FreeBSD 10+, support stage
  
  PR:		ports/185405
  Submitted by;	Stephen Hurd
  Approved by:	maintainer (Uri Shaked)
  Staged by:	marino@

Modified:
  head/sysutils/fonteditfs/Makefile
  head/sysutils/fonteditfs/files/patch-Makefile

Modified: head/sysutils/fonteditfs/Makefile
==============================================================================
--- head/sysutils/fonteditfs/Makefile	Sat Jan 25 13:41:26 2014	(r341039)
+++ head/sysutils/fonteditfs/Makefile	Sat Jan 25 14:38:47 2014	(r341040)
@@ -6,17 +6,15 @@ PORTVERSION=	1.2
 CATEGORIES=	sysutils
 MASTER_SITES=	SF
 DISTNAME=	fnteditfs-${PORTVERSION}
-EXTRACT_SUFX=.tgz
+EXTRACT_SUFX=	.tgz
 
 MAINTAINER=	uri@keves.org
 COMMENT=	Full screen syscons font editor
 
-MAN1=		fnteditfs.1
-PLIST_FILES=	bin/fnteditfs
+PLIST_FILES=	bin/fnteditfs man/man1/fnteditfs.1.gz
 
-NO_STAGE=	yes
 post-patch:
-	@${REINPLACE_CMD} -e 's|__PREFIX__|${PREFIX}|g ; \
+	@${REINPLACE_CMD} -e 's|__PREFIX__|${STAGEDIR}${PREFIX}|g ; \
 		s|__INSTALL_MAN__|${INSTALL_MAN}|g ; \
 		s|__INSTALL_SCRIPT__|${INSTALL_SCRIPT}|g' ${WRKSRC}/Makefile
 

Modified: head/sysutils/fonteditfs/files/patch-Makefile
==============================================================================
--- head/sysutils/fonteditfs/files/patch-Makefile	Sat Jan 25 13:41:26 2014	(r341039)
+++ head/sysutils/fonteditfs/files/patch-Makefile	Sat Jan 25 14:38:47 2014	(r341040)
@@ -1,6 +1,6 @@
---- Makefile.orig	2003-09-20 12:17:34.000000000 -0300
-+++ Makefile	2009-08-29 14:56:21.000000000 -0300
-@@ -2,12 +2,7 @@
+--- Makefile.orig	2003-09-20 08:17:34.000000000 -0700
++++ Makefile	2014-01-01 12:27:59.000000000 -0800
+@@ -2,14 +2,9 @@
  # - TODO: MAKE NEATER ONE 
  # This makefile should work under most POSIX OSes (at least FreeBSD)
  
@@ -12,8 +12,11 @@
 -
 +all: fnteditfs
  fnteditfs: fnteditfs.o font.o stack.o
- 	gcc -o fnteditfs fnteditfs.o font.o stack.o -lcurses
+-	gcc -o fnteditfs fnteditfs.o font.o stack.o -lcurses
++	${CC} -o fnteditfs fnteditfs.o font.o stack.o -lcurses
  	strip fnteditfs
+ 
+ fnteditfs.o: fnteditfs.c font.h stack.h
 @@ -17,8 +12,8 @@
  stack.o: stack.c stack.h
  
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 7 John Marino freebsd_committer freebsd_triage 2014-01-25 14:43:17 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!