Bug 185610 - [PATCH] irc/inspircd: GNUTLS option needs pkgconfig
Summary: [PATCH] irc/inspircd: GNUTLS option needs pkgconfig
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Mark Felder
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-09 15:20 UTC by Tim Bishop
Modified: 2014-01-11 17:30 UTC (History)
1 user (show)

See Also:

Attachments
inspircd-2.0.14.patch (299 bytes, patch)
2014-01-09 15:20 UTC, Tim Bishop 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Bishop freebsd_committer freebsd_triage 2014-01-09 15:20:00 UTC 
When the GNUTLS option is enabled the configure script uses pkg-config
to locate the GnuTLS libraries. I haven't checked if other options
require it too, but if not I suppose pkgconfig could be added to USES
only when the GNUTLS option is used, rather than always.

Port maintainer (feld@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_11 (mode: change, diff: SVN)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-01-09 15:20:08 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->feld

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2014-01-11 17:23:17 UTC 
Author: feld
Date: Sat Jan 11 17:23:09 2014
New Revision: 339439
URL: http://svnweb.freebsd.org/changeset/ports/339439

Log:
  Fix SQLITE and GNUTLS build options which were missing pkgconfig
  
  PR:		ports/185610
  Approved by:	swills (mentor)

Modified:
  head/irc/inspircd/Makefile

Modified: head/irc/inspircd/Makefile
==============================================================================
--- head/irc/inspircd/Makefile	Sat Jan 11 16:56:28 2014	(r339438)
+++ head/irc/inspircd/Makefile	Sat Jan 11 17:23:09 2014	(r339439)
@@ -93,6 +93,7 @@ PLIST_SUB+=	PGSQL="@comment "
 .endif
 
 .if ${PORT_OPTIONS:MSQLITE}
+USES+=	pkgconfig
 USE_SQLITE=	3
 EXTRAS:=${EXTRAS},m_sqlite3.cpp
 PLIST_SUB+=	SQLITE=""
@@ -101,8 +102,9 @@ PLIST_SUB+=	SQLITE="@comment "
 .endif
 
 .if ${PORT_OPTIONS:MGNUTLS}
-LIB_DEPENDS+=	gnutls:${PORTSDIR}/security/gnutls \
-		gcrypt:${PORTSDIR}/security/libgcrypt
+USES+=	pkgconfig
+LIB_DEPENDS+=	libgnutls.so:${PORTSDIR}/security/gnutls \
+		libgcrypt.so:${PORTSDIR}/security/libgcrypt
 CONFIGURE_ARGS+=	--enable-gnutls
 EXTRAS:=${EXTRAS},m_ssl_gnutls.cpp
 PLIST_SUB+=	GNUTLS=""
@@ -120,7 +122,7 @@ PLIST_SUB+=	OPENSSL="@comment "
 .endif
 
 .if ${PORT_OPTIONS:MPCRE}
-LIB_DEPENDS+=	pcre:${PORTSDIR}/devel/pcre
+LIB_DEPENDS+=	libpcre.so:${PORTSDIR}/devel/pcre
 EXTRAS:=${EXTRAS},m_regex_pcre.cpp
 PLIST_SUB+=	PCRE=""
 .else
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Mark Felder freebsd_committer freebsd_triage 2014-01-11 17:23:57 UTC 
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!