Bug 185738 - multimedia/oggvideotools non-integer framerate
Summary: multimedia/oggvideotools non-integer framerate
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Thomas Zander
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-13 08:20 UTC by Sergey Chernikov
Modified: 2014-01-26 12:30 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Chernikov 2014-01-13 08:20:00 UTC
When trying to pass denominator in the '-f' argument of oggTranscode it just appends it to numerator.

Fix: 

I've contacted the author of oggvideotools and according to him the fix is the following:
# diff work/oggvideotools-0.8a/src/cmdlineextractor.h.orig  work/oggvideotools-0.8a/src/cmdlineextractor.h
23c23
< const std::string validChars ( "0123456789,x" );
---
> const std::string validChars ( "0123456789,x:" );

I've applied it and tested (successfully).
How-To-Repeat: run
oggTranscode -f nnn:dd in.ogv out.ogv
Comment 1 Thomas Zander freebsd_committer freebsd_triage 2014-01-24 23:06:10 UTC
Responsible Changed
From-To: freebsd-ports-bugs->riggs

I'll take it.
Comment 2 dfilter service freebsd_committer freebsd_triage 2014-01-26 09:02:02 UTC
Author: riggs
Date: Sun Jan 26 09:01:55 2014
New Revision: 341157
URL: http://svnweb.freebsd.org/changeset/ports/341157
QAT: https://qat.redports.org/buildarchive/r341157/

Log:
  Fix runtime issue: Non-integer frame rates could not be handled
  - Fix incorrect handling of input arguments (new patch file patch-src_cmdlineextractor.h)
    Submitter proposed fix after talking to upstream author
  - Bump PORTREVISION
  
  PR:		ports/185738
  Submitted by:	Sergey Chernikov (no e-mail address)
  Approved by:	thierry (mentor)
  MFH:		2014Q1

Added:
  head/multimedia/oggvideotools/files/patch-src_cmdlineextractor.h   (contents, props changed)
Modified:
  head/multimedia/oggvideotools/Makefile

Modified: head/multimedia/oggvideotools/Makefile
==============================================================================
--- head/multimedia/oggvideotools/Makefile	Sun Jan 26 08:41:31 2014	(r341156)
+++ head/multimedia/oggvideotools/Makefile	Sun Jan 26 09:01:55 2014	(r341157)
@@ -3,7 +3,7 @@
 
 PORTNAME=	oggvideotools
 PORTVERSION=	0.8a
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	multimedia
 MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/${DISTNAME}
 

Added: head/multimedia/oggvideotools/files/patch-src_cmdlineextractor.h
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/multimedia/oggvideotools/files/patch-src_cmdlineextractor.h	Sun Jan 26 09:01:55 2014	(r341157)
@@ -0,0 +1,11 @@
+--- src/cmdlineextractor.h.orig	2010-05-30 21:11:10.000000000 +0200
++++ src/cmdlineextractor.h	2014-01-25 18:46:51.620972183 +0100
+@@ -20,7 +20,7 @@
+ #include "oggComment.h"
+ #include "blendElement.h"
+ 
+-const std::string validChars ( "0123456789,x" );
++const std::string validChars ( "0123456789,x:" );
+ const std::string
+ validTextChars ( "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789 /\\.,=;:-_" );
+ 
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Thomas Zander freebsd_committer freebsd_triage 2014-01-26 09:07:18 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2014-01-26 12:25:47 UTC
Author: riggs
Date: Sun Jan 26 12:25:40 2014
New Revision: 341166
URL: http://svnweb.freebsd.org/changeset/ports/341166
QAT: https://qat.redports.org/buildarchive/r341166/

Log:
  MFH: r341157
  
  Fix runtime issue: Non-integer frame rates could not be handled
  - Fix incorrect handling of input arguments (new patch file patch-src_cmdlineextractor.h)
    Submitter proposed fix after talking to upstream author
  - Bump PORTREVISION
  
  PR:		ports/185738
  Submitted by:	Sergey Chernikov (s.bilberry@gmail.com)
  Approved by:	portmgr (antoine), thierry (mentor)

Added:
  branches/2014Q1/multimedia/oggvideotools/files/patch-src_cmdlineextractor.h
     - copied unchanged from r341157, head/multimedia/oggvideotools/files/patch-src_cmdlineextractor.h
Modified:
  branches/2014Q1/multimedia/oggvideotools/Makefile
Directory Properties:
  branches/2014Q1/   (props changed)

Modified: branches/2014Q1/multimedia/oggvideotools/Makefile
==============================================================================
--- branches/2014Q1/multimedia/oggvideotools/Makefile	Sun Jan 26 12:17:39 2014	(r341165)
+++ branches/2014Q1/multimedia/oggvideotools/Makefile	Sun Jan 26 12:25:40 2014	(r341166)
@@ -3,7 +3,7 @@
 
 PORTNAME=	oggvideotools
 PORTVERSION=	0.8a
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	multimedia
 MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/${DISTNAME}
 

Copied: branches/2014Q1/multimedia/oggvideotools/files/patch-src_cmdlineextractor.h (from r341157, head/multimedia/oggvideotools/files/patch-src_cmdlineextractor.h)
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ branches/2014Q1/multimedia/oggvideotools/files/patch-src_cmdlineextractor.h	Sun Jan 26 12:25:40 2014	(r341166, copy of r341157, head/multimedia/oggvideotools/files/patch-src_cmdlineextractor.h)
@@ -0,0 +1,11 @@
+--- src/cmdlineextractor.h.orig	2010-05-30 21:11:10.000000000 +0200
++++ src/cmdlineextractor.h	2014-01-25 18:46:51.620972183 +0100
+@@ -20,7 +20,7 @@
+ #include "oggComment.h"
+ #include "blendElement.h"
+ 
+-const std::string validChars ( "0123456789,x" );
++const std::string validChars ( "0123456789,x:" );
+ const std::string
+ validTextChars ( "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789 /\\.,=;:-_" );
+ 
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"