Bug 185758 - [UPDATE] games/abe, fix issues reported by portlint
Summary: [UPDATE] games/abe, fix issues reported by portlint
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rusmir Dusko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-13 20:40 UTC by hardy.schumacher
Modified: 2014-01-19 19:50 UTC (History)
0 users

See Also:


Attachments
file.diff (436 bytes, patch)
2014-01-13 20:40 UTC, hardy.schumacher
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description hardy.schumacher 2014-01-13 20:40:00 UTC
Portlint reported issues related to missing entries required by new options framework.

Fix: Patch attached with submission follows:
How-To-Repeat: n/a
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-01-19 17:09:30 UTC
Responsible Changed
From-To: freebsd-ports-bugs->nemysis

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Rusmir Dusko freebsd_committer freebsd_triage 2014-01-19 19:44:28 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2014-01-19 19:48:49 UTC
Author: nemysis
Date: Sun Jan 19 19:48:41 2014
New Revision: 340345
URL: http://svnweb.freebsd.org/changeset/ports/340345
QAT: https://qat.redports.org/buildarchive/r340345/

Log:
  - Change Desktop entry file
  - Add REINPLACE_CMD, fix src/MapIO.c
  - Break lines around 80 characters
  
  PR:		ports/185758
  Submitted by:	Hardy Schumacher <hardy.schumacher@gmx.de>

Modified:
  head/games/abe/Makefile

Modified: head/games/abe/Makefile
==============================================================================
--- head/games/abe/Makefile	Sun Jan 19 19:24:56 2014	(r340344)
+++ head/games/abe/Makefile	Sun Jan 19 19:48:41 2014	(r340345)
@@ -26,8 +26,8 @@ MAKE_ARGS=	ACLOCAL="${TRUE}" AUTOCONF="$
 
 PORTDOCS=	AUTHORS ChangeLog README
 
-DESKTOP_ENTRIES="Abe's Amazing Avanture" "${COMMENT}" "${PORTNAME}" \
-		"${PORTNAME}" "Game;ArcadeGame;" false
+DESKTOP_ENTRIES="Abe's Amazing Avanture" "" "${PORTNAME}" \
+		"${PORTNAME}" "Game;ArcadeGame;" ""
 
 OPTIONS_DEFINE=	DOCS GOD_MODE OPTIMIZED_CFLAGS
 OPTIONS_DEFAULT=	GOD_MODE OPTIMIZED_CFLAGS
@@ -37,21 +37,25 @@ GOD_MODE_DESC=	Enable God Mode (toggle w
 
 post-patch:
 .if ${PORT_OPTIONS:MGOD_MODE} || ! ${PORT_OPTIONS:MOPTIMIZED_CFLAGS}
-.   if ${PORT_OPTIONS:MGOD_MODE}
+. if ${PORT_OPTIONS:MGOD_MODE}
 	@${REINPLACE_CMD} -e 's|#define GOD_MODE 0|#define GOD_MODE 1|' \
 		${WRKSRC}/src/Game.h
-.   endif
-.   if ! ${PORT_OPTIONS:MOPTIMIZED_CFLAGS}
+. endif
+. if ! ${PORT_OPTIONS:MOPTIMIZED_CFLAGS}
 	@${REINPLACE_CMD} -e 's|-O2||g ; \
 		s|-fomit-frame-pointer||g ; \
 		s|-ffast-math||g ; \
 		s|-fexpensive-optimizations||g' \
 		${CONFIGURE_WRKSRC}/${CONFIGURE_SCRIPT}
-.   endif
+. endif
 .endif
 
+	@${REINPLACE_CMD} -e 's|%u|%zu|' \
+	${WRKSRC}/src/MapIO.c
+
 post-install:
-	${INSTALL_DATA} ${_DISTDIR}/${PORTNAME}.png ${STAGEDIR}${PREFIX}/share/pixmaps/
+	${INSTALL_DATA} ${_DISTDIR}/${PORTNAME}.png \
+		${STAGEDIR}${PREFIX}/share/pixmaps/
 
 .for d in images maps sounds
 	@(cd ${WRKSRC} && ${COPYTREE_SHARE} ${d} ${STAGEDIR}${DATADIR})
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"