mp-letter Deletion of ^M in Makefiles Converting from NO_STAGE to staged mp-a4 Converting from NO_STAGE to staged Port maintainer (obrien@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 0.99_11 (mode: change, diff: ports)
Responsible Changed From-To: freebsd-ports-bugs->obrien Over to maintainer (via the GNATS Auto Assign Tool)
same here, encoded patches. These are important because they enable stage support which saves them from deletion, can you reformat and resubmit the patches?
Created attachment 145065 [details] mp-letter.patch
Created attachment 145066 [details] mp-a4.patch
I don't really like the stage solution on mp-letter. For one, DESTDIR is already defined so it should have been used instead of redefining STAGEDIR. secondly, the changes to Makefile.dist are so extensive, it makes more sense to move the installation to a "do-install" target in the makefile I think. The MASTER_SITES are go, so I had to change it to LOCAL/obrien
A commit references this bug: Author: marino Date: Mon Jul 28 11:05:20 UTC 2014 New revision: 363130 URL: http://svnweb.freebsd.org/changeset/ports/363130 Log: stage print/mp-letter & print/mp-a4 Also update MASTER_SITES which have disappeared and moving it to LOCAL/obrien. Includes various cleanups like removal of DOS endings in the makefile. PR: 185989 Submitted by: takefu (airport.fm) Approved by: maintainer timeout (6 months), staging blanket Changes: head/print/mp-a4/Makefile head/print/mp-letter/Makefile head/print/mp-letter/files/patch-Makefile.dist head/print/mp-letter/files/patch-aa head/print/mp-letter/files/patch-ab head/print/mp-letter/files/patch-ae head/print/mp-letter/files/patch-header.cc head/print/mp-letter/files/patch-input.cc head/print/mp-letter/files/patch-main.cc head/print/mp-letter/files/patch-print.cc head/print/mp-letter/files/patch-print.hh head/print/mp-letter/pkg-plist
A commit references this bug: Author: marino Date: Mon Jul 28 11:10:31 UTC 2014 New revision: 363132 URL: http://svnweb.freebsd.org/changeset/ports/363132 Log: print/mp-letter: Remove leftover MAKE_ARGS The definition of STAGEDIR isn't necessary, it was left over from an earlier version of stage support. PR: 185989 Changes: head/print/mp-letter/Makefile
Okay, I met you halfway. I kept the install target in the vendor makefile, but I simplified it considerably while also using the standard DESTDIR instead of the custom STAGEDIR.