Here is a cleanup regarding this port: - staging - remove useless DOCs Fix: Patch attached with submission follows:
Hi Can you please review the attached patch? Thanks. -- Alex
On Mon, Jan 27, 2014 at 7:53 AM, Alex Kozlov <spam@rm-rf.kiev.ua> wrote: > Hi > > Can you please review the attached patch? > Thanks. > > Hi Alex, did you modify it ? (because I'm the author of this "maintainer-update" PR). Regards, Olivier
On Mon, Jan 27, 2014 at 08:39:41AM +0100, Olivier Cochard-Labbé wrote: > On Mon, Jan 27, 2014 at 7:53 AM, Alex Kozlov <spam@rm-rf.kiev.ua> wrote: > > Can you please review the attached patch? > > Thanks. > > > > Hi Alex, > did you modify it ? (because I'm the author of this "maintainer-update" PR). Yes, I've fixed mode in plist: http://redports.org/~ak0/20140127060301-21904-172399/shellinabox-2.14_3.log , wrap overly long lines and removed whitespaces at eol in pkg-descr, used options helpers to simplify port and also make a few cosmetic changes. -- Alex
On Mon, Jan 27, 2014 at 8:57 AM, Alex Kozlov <spam@rm-rf.kiev.ua> wrote: > > Yes, I've fixed mode in plist: > http://redports.org/~ak0/20140127060301-21904-172399/shellinabox-2.14_3.log, > wrap overly long lines and removed whitespaces at eol in pkg-descr, > used options helpers to simplify port and also make a few cosmetic changes. > great: Then it's okay. Thanks, Olivier
Responsible Changed From-To: freebsd-ports-bugs->ak I'll take it.
State Changed From-To: open->closed Committed. Thanks!