Bug 186478 - [patch update] security/sslscan linker fix (adding -lcrypto)
Summary: [patch update] security/sslscan linker fix (adding -lcrypto)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-05 11:50 UTC by Kurt Jaeger
Modified: 2014-05-02 18:38 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (545 bytes, patch)
2014-02-05 11:50 UTC, Kurt Jaeger
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kurt Jaeger 2014-02-05 11:50:00 UTC
	building sslscan fails with a linker error:

[...]
/usr/bin/ld:  : invalid DSO for symbol `BN_num_bits' definition
//usr/local/lib/libcrypto.so.8: could not read symbols: Bad value
cc: error: linker command failed with exit code 1 (use -v to see invocation)
[...]

Adding -lcrypto fixes this.

How-To-Repeat: 	cd /usr/ports/security/sslscan
	make
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-02-05 11:50:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wg

wg@ wants this submitter's PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2014-02-05 11:50:09 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2014-02-05 11:50:09 UTC
Maintainer of security/sslscan,

Please note that PR ports/186478 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/186478

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 4 Matthieu Bouthors 2014-02-06 17:18:23 UTC
Hello,

patch is ok for me. Compilation seems to fail only on FreeBSD 10 but patch
does not cause trouble on previous version like 9.x. I've tested on a
couple of boxes without any trouble. May you commit it in order to allow
FreeBSD 10 users to use this port ?

Best regards,
Matthieu


On Wed, Feb 5, 2014 at 12:50 PM, Edwin Groothuis <edwin@freebsd.org> wrote:

> Maintainer of security/sslscan,
>
> Please note that PR ports/186478 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/186478
>
> --
> Edwin Groothuis via the GNATS Auto Assign Tool
> edwin@FreeBSD.org
>
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2014-04-26 16:28:34 UTC
Responsible Changed
From-To: wg->pi

I'll take it.
Comment 6 dfilter service freebsd_committer freebsd_triage 2014-05-02 18:23:57 UTC
Author: pi
Date: Fri May  2 17:23:53 2014
New Revision: 352830
URL: http://svnweb.freebsd.org/changeset/ports/352830
QAT: https://qat.redports.org/buildarchive/r352830/

Log:
  security/sslscan: linker fix for 10.0 (adding -lcrypto), staging,
                          pkg-descr reformatted (shorter lines)
  
  PR:             ports/186478
  Submitted by:   pi
  Approved by:    jadawin (mentor)

Added:
  head/security/sslscan/pkg-plist   (contents, props changed)
Modified:
  head/security/sslscan/Makefile
  head/security/sslscan/files/patch-Makefile
  head/security/sslscan/pkg-descr

Modified: head/security/sslscan/Makefile
==============================================================================
--- head/security/sslscan/Makefile	Fri May  2 17:07:03 2014	(r352829)
+++ head/security/sslscan/Makefile	Fri May  2 17:23:53 2014	(r352830)
@@ -10,10 +10,8 @@ EXTRACT_SUFX=	.tgz
 MAINTAINER=	matthieu@labs.fr
 COMMENT=	SSLScan is a fast SSL port scanner
 
-MAKE_ARGS=	CC="${CC}" CFLAGS="-I${LOCALBASE}/include" LDFLAGS="-L${LOCALBASE}/lib"
+LICENSE=	GPLv3
 
-MAN1=	sslscan.1
-PLIST_FILES=	bin/sslscan
+MAKE_ARGS=	STAGEDIR=${STAGEDIR} CC="${CC}" CFLAGS="-I${LOCALBASE}/include" LDFLAGS="-L${LOCALBASE}/lib"
 
-NO_STAGE=	yes
 .include <bsd.port.mk>

Modified: head/security/sslscan/files/patch-Makefile
==============================================================================
--- head/security/sslscan/files/patch-Makefile	Fri May  2 17:07:03 2014	(r352829)
+++ head/security/sslscan/files/patch-Makefile	Fri May  2 17:23:53 2014	(r352830)
@@ -4,13 +4,13 @@
  SRCS = sslscan.c
 -BINPATH = /usr/bin/
 -MANPATH = /usr/share/man/
-+BINPATH = ${PREFIX}/bin/
-+MANPATH = ${PREFIX}/man
++BINPATH = ${STAGEDIR}${PREFIX}/bin/
++MANPATH = ${STAGEDIR}${PREFIX}/man
 +CC =	${CC}
  
  all:
 -	gcc -g -Wall -lssl -o sslscan $(SRCS) $(LDFLAGS) $(CFLAGS)
-+	${CC} -g -Wall -lssl -o sslscan $(SRCS) $(LDFLAGS) $(CFLAGS)
++	${CC} -g -Wall -lssl -lcrypto -o sslscan $(SRCS) $(LDFLAGS) $(CFLAGS)
  
  install:
 -	cp sslscan $(BINPATH)

Modified: head/security/sslscan/pkg-descr
==============================================================================
--- head/security/sslscan/pkg-descr	Fri May  2 17:07:03 2014	(r352829)
+++ head/security/sslscan/pkg-descr	Fri May  2 17:23:53 2014	(r352830)
@@ -1,4 +1,6 @@
-SSLScan is a fast SSL port scanner. SSLScan connects to SSL ports and determines
-what ciphers are supported, which are the servers prefered ciphers, which SSL
-protocols are supported and returns the SSL certificate. Client certificates and
-private key can be configured and output is to text / XML.
+SSLScan is a fast SSL port scanner. SSLScan connects to SSL ports
+and determines what ciphers are supported, which are the servers
+prefered ciphers, which SSL protocols are supported and returns the
+SSL certificate. Client certificates and private key can be configured
+and output is to text / XML.
+

Added: head/security/sslscan/pkg-plist
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/security/sslscan/pkg-plist	Fri May  2 17:23:53 2014	(r352830)
@@ -0,0 +1,2 @@
+bin/sslscan
+man/man1/sslscan.1.gz
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 7 Kurt Jaeger freebsd_committer freebsd_triage 2014-05-02 18:38:49 UTC
State Changed
From-To: feedback->closed

Committed, with minor changes. Thanks!