Fix building of games/blockout when gcc is not installed. Fix: Patch attached with submission follows: How-To-Repeat: http://beefy1.isc.freebsd.org/bulk/head-i386-default/2014-02-06_18h13m58s/logs/blockout-2.4_2.log
Responsible Changed From-To: freebsd-ports-bugs->wen I'll take it.
Hi gang, I also experienced this bug today on FreeBSD 10-RELEASE (i386) and was about to write up a PR myself when I noticed this one. Alas; the patch didn't work for me so I did some digging as well. First I realized you could replace gcc and g++ with respectively clang and clang++. Then I read the Porters handbook, learned that setting either CC or CXX is considered bad practice so commented out. In the mean time I also discovered that the attached patch was actually a new version of files/patch-Makefile. Alas; I did some hacking of my own in the mean time. Hopefully this can also help, at the very least it was fun to setup (learned a /lot/ about diff & patch in the process). You can find a patch attached which will change files/patch-Makefile (in games/blockout obviously) so that it comments out all references to gcc and g++. Figured I might as well sent it; someone less familiar with all this has only to use "patch < blockout.patch" in the games/blockout directory and then it'll build successfully on FreeBSD 10. Kind regards, Peter
Author: wen Date: Fri Mar 28 13:29:58 2014 New Revision: 349419 URL: http://svnweb.freebsd.org/changeset/ports/349419 QAT: https://qat.redports.org/buildarchive/r349419/ Log: - Fix build on head PR: 186577 Submitted by: S <devel@stasyan.com> (maintainer) Added: head/games/blockout/files/patch-ImageLib_src_Makefile (contents, props changed) Modified: head/games/blockout/files/patch-Makefile Added: head/games/blockout/files/patch-ImageLib_src_Makefile ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/games/blockout/files/patch-ImageLib_src_Makefile Fri Mar 28 13:29:58 2014 (r349419) @@ -0,0 +1,13 @@ +--- ImageLib/src/Makefile.orig 2014-02-09 13:14:33.000000000 +0700 ++++ ImageLib/src/Makefile 2014-02-09 13:15:28.000000000 +0700 +@@ -32,8 +32,8 @@ + + #--------------------------------------------------------------------- + +-CXX = g++ +-CC = gcc ++#CXX = g++ ++#CC = gcc + + CXXFLAGS = -O2 -Dlinux -c -I. + CFLAGS = -O2 -Dlinux -c -I. Modified: head/games/blockout/files/patch-Makefile ============================================================================== --- head/games/blockout/files/patch-Makefile Fri Mar 28 13:24:35 2014 (r349418) +++ head/games/blockout/files/patch-Makefile Fri Mar 28 13:29:58 2014 (r349419) @@ -1,5 +1,5 @@ ---- BlockOut/Makefile.orig 2009-08-06 14:55:56.000000000 +0700 -+++ BlockOut/Makefile 2009-08-06 15:39:07.000000000 +0700 +--- BlockOut/Makefile.orig 2008-01-10 00:29:06.000000000 +0600 ++++ BlockOut/Makefile 2014-02-09 13:17:22.000000000 +0700 @@ -34,17 +34,17 @@ #--------------------------------------------------------------------- @@ -9,7 +9,8 @@ +SDL_ROOT = /usr/local +IMGLIB_ROOT = ../ImageLib/src - CXX = g++ +-CXX = g++ ++#CXX = g++ CXXFLAGS = -g -D_DEBUG -Dlinux -c \ - -I$(SDL_ROOT)/include/SDL -I$(IMGLIB_ROOT) -I. _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!