Bug 186779 - building graphics/libopenraw fails
Summary: building graphics/libopenraw fails
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Tijl Coosemans
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-14 22:30 UTC by TsurutaniNaoki
Modified: 2014-03-19 19:30 UTC (History)
1 user (show)

See Also:


Attachments
patch-configure (576 bytes, text/plain; charset=us-ascii)
2014-03-17 16:58 UTC, spry
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description TsurutaniNaoki 2014-02-14 22:30:00 UTC
	building graphics/libopenraw fails.

Fix: 

I have no idea.
	linking /usr/local/lib/libboost_unit_test_framework.so.1.55.0 as
	/usr/local/lib/libboost_unit_test_framework-d.so can avoid this problem,
	but it is not sane...
How-To-Repeat: 	% make
	...
	===>  Found saved configuration for libopenraw-0.0.8_4
	===> Fetching all distfiles required by libopenraw-0.0.8_6 for building
	===>  Extracting for libopenraw-0.0.8_6
	=> SHA256 Checksum OK for libopenraw-0.0.8.tar.gz.
	===>  Patching for libopenraw-0.0.8_6
	===>  Applying FreeBSD patches for libopenraw-0.0.8_6
	===>   libopenraw-0.0.8_6 depends on executable: pkgconf - found
	===>   libopenraw-0.0.8_6 depends on file: /usr/local/bin/intltool-extract - found
	===>   libopenraw-0.0.8_6 depends on shared library: libboost_thread.so - found
	 - found
	===>   libopenraw-0.0.8_6 depends on shared library: libjpeg.so - found
	 - found
	===>   libopenraw-0.0.8_6 depends on shared library: libatk-1.0.so - found
	 - found
	===>   libopenraw-0.0.8_6 depends on shared library: libglib-2.0.so - found
	 - found
	===>   libopenraw-0.0.8_6 depends on shared library: libpcre.so - found
	 - found
	===>   libopenraw-0.0.8_6 depends on shared library: libgtk-x11-2.0.so - found
	 - found
	===>   libopenraw-0.0.8_6 depends on shared library: libxml2.so - found
	 - found
	===>   libopenraw-0.0.8_6 depends on shared library: libpango-1.0.so - found
	 - found
	===>  Configuring for libopenraw-0.0.8_6
	configure: loading site script /usr/ports/Templates/config.site
	checking for a BSD-compatible install... /usr/bin/install -c -o root -g wheel
	checking whether build environment is sane... yes
	checking for a thread-safe mkdir -p... (cached) /bin/mkdir -p
	checking for gawk... (cached) /usr/bin/awk
	checking whether make sets $(MAKE)... yes
	checking whether to enable maintainer-specific portions of Makefiles... no
	checking for gcc... cc
	checking for C compiler default output file name... a.out
	checking whether the C compiler works... yes
	checking whether we are cross compiling... no
	checking for suffix of executables...
	checking for suffix of object files... o
	checking whether we are using the GNU C compiler... yes
	checking whether cc accepts -g... yes
	checking for cc option to accept ISO C89... none needed
	checking for style of include used by make... GNU
	checking dependency style of cc... gcc3
	checking how to run the C preprocessor... cpp
	checking whether we are using the GNU C++ compiler... yes
	checking whether c++ accepts -g... yes
	checking dependency style of c++... gcc3
	checking for a BSD-compatible install... /usr/bin/install -c -o root -g wheel
	checking build system type... i386-portbld-freebsd8.4
	checking host system type... i386-portbld-freebsd8.4
	checking for a sed that does not truncate output... (cached) /usr/bin/sed
	checking for grep that handles long lines and -e... (cached) /usr/bin/grep
	checking for egrep... (cached) /usr/bin/egrep
	checking for fgrep... (cached) /usr/bin/fgrep
	checking for ld used by cc... /usr/bin/ld
	checking if the linker (/usr/bin/ld) is GNU ld... yes
	checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
	checking the name lister (/usr/bin/nm -B) interface... BSD nm
	checking whether ln -s works... yes
	checking the maximum length of command line arguments... (cached) 262144
	checking whether the shell understands some XSI constructs... yes
	checking whether the shell understands "+="... no
	checking for /usr/bin/ld option to reload object files... -r
	checking for objdump... objdump
	checking how to recognize dependent libraries... pass_all
	checking for ar... ar
	checking for strip... strip
	checking for ranlib... ranlib
	checking command to parse /usr/bin/nm -B output from cc object... ok
	checking for ANSI C header files... (cached) yes
	checking for sys/types.h... (cached) yes
	checking for sys/stat.h... (cached) yes
	checking for stdlib.h... (cached) yes
	checking for string.h... (cached) yes
	checking for memory.h... (cached) yes
	checking for strings.h... (cached) yes
	checking for inttypes.h... (cached) yes
	checking for stdint.h... (cached) yes
	checking for unistd.h... (cached) yes
	checking for dlfcn.h... (cached) yes
	checking whether we are using the GNU C++ compiler... (cached) yes
	checking whether c++ accepts -g... (cached) yes
	checking dependency style of c++... (cached) gcc3
	checking how to run the C++ preprocessor... c++ -E
	checking for objdir... .libs
	checking if cc supports -fno-rtti -fno-exceptions... no
	checking for cc option to produce PIC... -fPIC -DPIC
	checking if cc PIC flag -fPIC -DPIC works... yes
	checking if cc static flag -static works... yes
	checking if cc supports -c -o file.o... yes
	checking if cc supports -c -o file.o... (cached) yes
	checking whether the cc linker (/usr/bin/ld) supports shared libraries... yes
	checking whether -lc should be explicitly linked in... no
	checking dynamic linker characteristics... freebsd8.4 ld.so
	checking how to hardcode library paths into programs... immediate
	checking whether stripping libraries is possible... yes
	checking if libtool supports shared libraries... yes
	checking whether to build shared libraries... yes
	checking whether to build static libraries... yes
	checking for ld used by c++... /usr/bin/ld
	checking if the linker (/usr/bin/ld) is GNU ld... yes
	checking whether the c++ linker (/usr/bin/ld) supports shared libraries... yes
	checking for c++ option to produce PIC... -fPIC -DPIC
	checking if c++ PIC flag -fPIC -DPIC works... yes
	checking if c++ static flag -static works... yes
	checking if c++ supports -c -o file.o... yes
	checking if c++ supports -c -o file.o... (cached) yes
	checking whether the c++ linker (/usr/bin/ld) supports shared libraries... yes
	checking dynamic linker characteristics... freebsd8.4 ld.so
	checking how to hardcode library paths into programs... immediate
	checking for Boost headers version >= 1.33.0... /usr/local/include
	checking for Boost's header version... 1_55
	checking for the toolset name used by Boost for c++... gcc42
	checking boost/test/unit_test.hpp usability... yes
	checking boost/test/unit_test.hpp presence... yes
	checking for boost/test/unit_test.hpp... yes
	checking for the Boost unit_test_framework library... no
	configure: error: Could not find the flags to link with Boost unit_test_framework
	===>  Script "configure" failed unexpectedly.
	Please report the problem to ports@FreeBSD.org [maintainer] and attach the
	"/usr/local/work/usr/ports/graphics/libopenraw/work/libopenraw-0.0.8/config.log"
	including the output of the failure of your make command. Also, it might be
	a good idea to provide an overview of all packages installed on your system
	(e.g. a /usr/sbin/pkg_info -Ea).
	*** Error code 1
	 
	Stop in /usr/ports/graphics/libopenraw.
	*** Error code 1
Comment 1 alexz52 2014-02-25 17:53:16 UTC
Some followup information:

On previous good compile from some months ago using older boost libs, the 
configure script shows the following:

configure:15975: c++ -o conftest -O2 -pipe -fno-strict-aliasing 
-I/usr/local/include -I/usr/local/include  -L/usr/local/lib -L/usr/local/lib 
conftest.o /usr/local/lib/libboost_unit_test_framework.a  >&5

Which succeeds (exit status 0)

In the current version this generates a lot of errors and does not succeed 
(exit status 1):

local symbol 0: discarded in section 
`.text._ZN5boost23basic_wrap_stringstreamIcED2Ev' from 
/usr/local/lib/libboost_unit_test_framework.a(unit_test_log.o)



Note that at no point does the configure script look for
libboost_unit_test_framework.so, the closest being something like
libboost_unit_test_framework-gcc42.so.
Comment 2 alexz52 2014-02-25 18:27:26 UTC
There is a bug in the openraw configure script.  It clearly intends to find a 
naked .so library but its test for whether it has seen a library before (and 
skip testing) always matches the naked library even when it has not been 
tested.  (The name of the naked library is a substring on any of the augmented 
names that are looked for, so is always skipped.)

The following crude patch allows the configure stage to complete but does not 
explain the errors in the .a library.  Compilation then succeeds, and (in my 
case) the build of gimp also completes.

--- configure.orig      2014-02-25 18:15:28.000000000 +0000
+++ configure   2014-02-25 18:11:09.000000000 +0000
@@ -15936,9 +15936,9 @@
      boost_unit_test_framework$boost_tag_$boost_ver_
    do
      # Avoid testing twice the same lib
-    case $boost_failed_libs in #(
-      *@$boost_lib@*) continue;;
-    esac
+#    case $boost_failed_libs in #(
+#      *@$boost_lib@*) continue;;
+#    esac
      # If with_boost is empty, we'll search in /lib first, which is not quite
      # right so instead we'll try to a location based on where the headers are.
      boost_tmp_lib=$with_boost
Comment 3 TsurutaniNaoki 2014-02-28 03:13:17 UTC
This seems fine to me.
Thank you for your report and patch.
Comment 4 spry 2014-03-17 16:58:02 UTC
And herein is the patch by Alex Zbyslaw <alexz52@blueyonder.co.uk> ready
to be placed under graphics/libopenraw/files/

It works for me, too.


-- 
Technicality, n.:
	In an English court a man named Home was tried for slander in
	having accused a neighbor of murder.  His exact words were: "Sir
	Thomas Holt hath taken a cleaver and stricken his cook upon the
	head, so that one side of his head fell on one shoulder and the
	other side upon the other shoulder."  The defendant was
	acquitted by instruction of the court, the learned judges
	holding that the words did not charge murder, for they did not
	affirm the death of the cook, that being only an inference.
		-- Ambrose Bierce, "The Devil's Dictionary"
Comment 5 Tijl Coosemans freebsd_committer freebsd_triage 2014-03-19 16:24:01 UTC
Responsible Changed
From-To: freebsd-ports-bugs->tijl

Take.
Comment 6 dfilter service freebsd_committer freebsd_triage 2014-03-19 19:27:07 UTC
Author: tijl
Date: Wed Mar 19 19:26:59 2014
New Revision: 348647
URL: http://svnweb.freebsd.org/changeset/ports/348647
QAT: https://qat.redports.org/buildarchive/r348647/

Log:
  - Update libopenraw to 0.0.9.
  - Fix build on FreeBSD 8.x by adding compiler:c++11-lang.
    (Use same compiler/linker as Boost.) [1]
  - Chase library version change.
  - Consistently use OPENRAW as option name.
  
  PR:		ports/186779 [1]

Modified:
  head/deskutils/xfce4-tumbler/Makefile
  head/graphics/gegl/Makefile
  head/graphics/gthumb/Makefile
  head/graphics/libopenraw/Makefile
  head/graphics/libopenraw/distinfo
  head/graphics/libopenraw/pkg-plist

Modified: head/deskutils/xfce4-tumbler/Makefile
==============================================================================
--- head/deskutils/xfce4-tumbler/Makefile	Wed Mar 19 19:18:15 2014	(r348646)
+++ head/deskutils/xfce4-tumbler/Makefile	Wed Mar 19 19:26:59 2014	(r348647)
@@ -3,6 +3,7 @@
 
 PORTNAME=	tumbler
 PORTVERSION=	0.1.30
+PORTREVISION=	1
 CATEGORIES=	deskutils xfce
 MASTER_SITES=	${MASTER_SITE_XFCE}
 MASTER_SITE_SUBDIR=	src/xfce/${PORTNAME}/${PORTVERSION:R}
@@ -28,7 +29,7 @@ CONFIGURE_ARGS=	--enable-xdg-cache \
 		--disable-gtk-doc-html
 
 OPTIONS_DEFINE=	DOCS NLS PIXBUF FONTS JPEG FFMPEG POPPLER \
-	GSTREAMER ODF RAW COVER
+		GSTREAMER ODF OPENRAW COVER
 OPTIONS_DEFAULT=	PIXBUF FONTS JPEG POPPLER ODF
 FONTS_DESC=	Fonts thumbnailer plugin
 COVER_DESC=	Open Movie Database thumbnailer plugin
@@ -150,7 +151,7 @@ CONFIGURE_ARGS+=--disable-odf-thumbnaile
 PLIST_SUB+=	ODF="@comment "
 .endif
 
-.if ${PORT_OPTIONS:MRAW}
+.if ${PORT_OPTIONS:MOPENRAW}
 .if ! ${PORT_OPTIONS:MPIXBUF}
 USE_GNOME+=	gdkpixbuf2
 CONFIGURE_ARGS+=--enable-pixbuf-thumbnailer

Modified: head/graphics/gegl/Makefile
==============================================================================
--- head/graphics/gegl/Makefile	Wed Mar 19 19:18:15 2014	(r348646)
+++ head/graphics/gegl/Makefile	Wed Mar 19 19:26:59 2014	(r348647)
@@ -3,7 +3,7 @@
 
 PORTNAME=	gegl
 PORTVERSION=	0.2.0
-PORTREVISION=	5
+PORTREVISION=	6
 CATEGORIES=	graphics
 MASTER_SITES=	ftp://ftp.gimp.org/pub/gegl/0.2/
 
@@ -125,7 +125,7 @@ PLIST_SUB+=	OPENEXR="@comment "
 .endif
 
 .if ${PORT_OPTIONS:MOPENRAW}
-LIB_DEPENDS+=	openraw:${PORTSDIR}/graphics/libopenraw
+LIB_DEPENDS+=	libopenraw.so:${PORTSDIR}/graphics/libopenraw
 PLIST_SUB+=	OPENRAW=""
 .else
 CONFIGURE_ARGS+=--without-libopenraw

Modified: head/graphics/gthumb/Makefile
==============================================================================
--- head/graphics/gthumb/Makefile	Wed Mar 19 19:18:15 2014	(r348646)
+++ head/graphics/gthumb/Makefile	Wed Mar 19 19:26:59 2014	(r348647)
@@ -3,7 +3,7 @@
 
 PORTNAME=	gthumb
 PORTVERSION=	2.14.1
-PORTREVISION=	5
+PORTREVISION=	6
 CATEGORIES=	graphics
 MASTER_SITES=	GNOME
 DIST_SUBDIR=	gnome2
@@ -37,7 +37,6 @@ OPTIONS_DEFINE=	EXIV2 CLUTTER GSTREAMER 
 OPTIONS_DEFAULT=	EXIV2 CLUTTER GSTREAMER OPENRAW SOUP BRASERO YELP
 CLUTTER_DESC=	Fancy slideshows
 GSTREAMER_DESC=	Video playback
-OPENRAW_DESC=	Support for camera RAW files
 SOUP_DESC=	Web services uploaders
 BRASERO_DESC=	Write galleries to CD/DVD (large dependency)
 YELP_DESC=	Viewer for built-in help system
@@ -73,7 +72,7 @@ PLIST_SUB+=	GSTREAMER="@comment "
 .endif
 
 .if ${PORT_OPTIONS:MOPENRAW}
-LIB_DEPENDS+=	openrawgnome.6:${PORTSDIR}/graphics/libopenraw
+LIB_DEPENDS+=	libopenrawgnome.so:${PORTSDIR}/graphics/libopenraw
 CONFIGURE_ARGS+=--enable-libopenraw
 .else
 CONFIGURE_ARGS+=--disable-libopenraw

Modified: head/graphics/libopenraw/Makefile
==============================================================================
--- head/graphics/libopenraw/Makefile	Wed Mar 19 19:18:15 2014	(r348646)
+++ head/graphics/libopenraw/Makefile	Wed Mar 19 19:26:59 2014	(r348647)
@@ -2,8 +2,7 @@
 # $FreeBSD$
 
 PORTNAME=	libopenraw
-PORTVERSION=	0.0.8
-PORTREVISION=	6
+PORTVERSION=	0.0.9
 CATEGORIES=	graphics
 MASTER_SITES=	http://libopenraw.freedesktop.org/download/
 
@@ -13,7 +12,7 @@ COMMENT=	Library for camera RAW files de
 LIB_DEPENDS=	libboost_thread.so:${PORTSDIR}/devel/boost-libs \
 		libjpeg.so:${PORTSDIR}/graphics/jpeg
 
-USES=		pkgconfig
+USES=		compiler:c++11-lang libtool pkgconfig tar:bzip2
 USE_GNOME=	libxml2
 USE_LDCONFIG=	yes
 GNU_CONFIGURE=	yes
@@ -26,7 +25,7 @@ OPTIONS_DEFAULT=	GNOME
 
 OPTIONS_SUB=	yes
 GNOME_CONFIGURE_ENABLE=	gnome
-GNOME_USE=	GNOME=gtk20
+GNOME_USE=	GNOME=glib20,gdkpixbuf2
 
 post-patch:
 	@${REINPLACE_CMD} -e 's|{libdir}/pkgconfig|{prefix}/libdata/pkgconfig|' ${WRKSRC}/configure

Modified: head/graphics/libopenraw/distinfo
==============================================================================
--- head/graphics/libopenraw/distinfo	Wed Mar 19 19:18:15 2014	(r348646)
+++ head/graphics/libopenraw/distinfo	Wed Mar 19 19:26:59 2014	(r348647)
@@ -1,2 +1,2 @@
-SHA256 (libopenraw-0.0.8.tar.gz) = b79e6eb1654ba9a831163f3a3057bd573765cbe1ae84be841d19f487d2fe25bd
-SIZE (libopenraw-0.0.8.tar.gz) = 557539
+SHA256 (libopenraw-0.0.9.tar.bz2) = 49fd1adf0a0228c7a17a79bf98d8d03664195feae1e50f4ddd1b20162626e18f
+SIZE (libopenraw-0.0.9.tar.bz2) = 478687

Modified: head/graphics/libopenraw/pkg-plist
==============================================================================
--- head/graphics/libopenraw/pkg-plist	Wed Mar 19 19:18:15 2014	(r348646)
+++ head/graphics/libopenraw/pkg-plist	Wed Mar 19 19:26:59 2014	(r348647)
@@ -11,17 +11,19 @@ include/libopenraw-1.0/libopenraw/rawfil
 include/libopenraw-1.0/libopenraw/thumbnails.h
 include/libopenraw-1.0/libopenraw/types.h
 %%GNOME%%include/libopenraw-1.0/libopenraw-gnome/gdkpixbuf.h
-%%GNOME%%lib/gtk-2.0/%%GTK2_VERSION%%/loaders/libopenraw_pixbuf.a
-%%GNOME%%lib/gtk-2.0/%%GTK2_VERSION%%/loaders/libopenraw_pixbuf.la
-%%GNOME%%lib/gtk-2.0/%%GTK2_VERSION%%/loaders/libopenraw_pixbuf.so
+%%GNOME%%lib/gdk-pixbuf-2.0/%%GTK2_VERSION%%/loaders/libopenraw_pixbuf.a
+%%GNOME%%lib/gdk-pixbuf-2.0/%%GTK2_VERSION%%/loaders/libopenraw_pixbuf.la
+%%GNOME%%lib/gdk-pixbuf-2.0/%%GTK2_VERSION%%/loaders/libopenraw_pixbuf.so
 lib/libopenraw.a
 lib/libopenraw.la
 lib/libopenraw.so
-lib/libopenraw.so.6
+lib/libopenraw.so.1
+lib/libopenraw.so.1.6.0
 %%GNOME%%lib/libopenrawgnome.a
 %%GNOME%%lib/libopenrawgnome.la
 %%GNOME%%lib/libopenrawgnome.so
-%%GNOME%%lib/libopenrawgnome.so.6
+%%GNOME%%lib/libopenrawgnome.so.1
+%%GNOME%%lib/libopenrawgnome.so.1.6.0
 libdata/pkgconfig/libopenraw-1.0.pc
 %%GNOME%%libdata/pkgconfig/libopenraw-gnome-1.0.pc
 %%GNOME%%@dirrm include/libopenraw-1.0/libopenraw-gnome
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 7 Tijl Coosemans freebsd_committer freebsd_triage 2014-03-19 19:27:39 UTC
State Changed
From-To: open->closed

Fixed in r348647.