Bug 186904 - ports-mgmt/pkg_rmleaves: always says to resize terminal to at least 80x24
Summary: ports-mgmt/pkg_rmleaves: always says to resize terminal to at least 80x24
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jason E. Hale
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-19 23:00 UTC by Lawrence Chen
Modified: 2014-02-23 02:00 UTC (History)
1 user (show)

See Also:


Attachments
pkg_rmleaves.patch (796 bytes, patch)
2014-02-19 23:00 UTC, Lawrence Chen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lawrence Chen 2014-02-19 23:00:00 UTC
	No matter what terminal I use, or what size, it always fails with:

	Dialog Error, try to resize your terminal to at least 80x24.

Fix: Turns out this is a fixed message for any Exit status of 255 (-1) from
	dialog, which is the Exit status for any errors occuring inside dialog
	or dialog is exited by pressing the ESC key.

	After a deeper investigation, the problem is due to ports that use
	quotation marks in the package comment.

	Ugly kluge below is what I did to make it work for me.  I have
	converted all my FreeBSD systems to pkgng, so don't know if the
	non-pkgng way is right.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-02-19 23:00:15 UTC
Maintainer of ports-mgmt/pkg_rmleaves,

Please note that PR ports/186904 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/186904

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2014-02-19 23:00:16 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 alexander 2014-02-22 14:10:28 UTC
Thanks for bringing the problem to my attention. I was aware of the =
described deficiency in the quote handling, however, on my test system =
with FreeBSD 10 everything worked also with e.g. php55-extensions (A =
=93meta-port=94 to install PHP extensions), despite the quotes in the =
description.
I included a modified version of the proposed patch, please try the new =
version of the script at =
http://alex.wittig.name/pkg_rmleaves/pkg_rmleaves-20140222.tar.gz
If it works for you, I=92ll submit an update to the port.=
Comment 4 Lawrence Chen 2014-02-22 20:58:34 UTC
On 2014-02-22 08:10, Alexander Wittig wrote:
> Thanks for bringing the problem to my attention. I was aware of the
> described deficiency in the quote handling, however, on my test system with
> FreeBSD 10 everything worked also with e.g. php55-extensions (A âmeta-portâ
> to install PHP extensions), despite the quotes in the description.
> I included a modified version of the proposed patch, please try the new
> version of the script at
> http://alex.wittig.name/pkg_rmleaves/pkg_rmleaves-20140222.tar.gz
> If it works for you, Iâll submit an update to the port.

Yes, this works for me.

-- 
   Name: Lawrence "The Dreamer" Chen    Call: W0LKC
  Snail: 1530 College Ave, A5          Email: beastie@tardisi.com
         Manhattan, KS 66502-2768       Blog: http://lawrencechen.net
Comment 5 Jason E. Hale freebsd_committer freebsd_triage 2014-02-23 01:39:28 UTC
Responsible Changed
From-To: freebsd-ports-bugs->jhale

I'll take it.
Comment 6 dfilter service freebsd_committer freebsd_triage 2014-02-23 01:51:31 UTC
Author: jhale
Date: Sun Feb 23 01:51:24 2014
New Revision: 345688
URL: http://svnweb.freebsd.org/changeset/ports/345688
QAT: https://qat.redports.org/buildarchive/r345688/

Log:
  - Update to 20140222 [1]
  - This addresses a reported dialog error [2]
  
  PR:		ports/186964 [1], ports/186904 [2]
  Submitted by:	Alexander Wittig <alexander@wittig.name> (maintainer) [1],
  		Lawrence Chen <lchen@zen.lhaven.homeip.net> [2]

Modified:
  head/ports-mgmt/pkg_rmleaves/Makefile
  head/ports-mgmt/pkg_rmleaves/distinfo

Modified: head/ports-mgmt/pkg_rmleaves/Makefile
==============================================================================
--- head/ports-mgmt/pkg_rmleaves/Makefile	Sun Feb 23 01:48:15 2014	(r345687)
+++ head/ports-mgmt/pkg_rmleaves/Makefile	Sun Feb 23 01:51:24 2014	(r345688)
@@ -2,7 +2,7 @@
 # $FreeBSD$
 
 PORTNAME=	pkg_rmleaves
-PORTVERSION=	20140110
+PORTVERSION=	20140222
 CATEGORIES=	ports-mgmt
 MASTER_SITES=	http://alex.wittig.name/${PORTNAME}/
 

Modified: head/ports-mgmt/pkg_rmleaves/distinfo
==============================================================================
--- head/ports-mgmt/pkg_rmleaves/distinfo	Sun Feb 23 01:48:15 2014	(r345687)
+++ head/ports-mgmt/pkg_rmleaves/distinfo	Sun Feb 23 01:51:24 2014	(r345688)
@@ -1,2 +1,2 @@
-SHA256 (pkg_rmleaves-20140110.tar.gz) = e0ac071a2d774843a597268830000a81c423eb5ade1cb0a5c66fad20e4559382
-SIZE (pkg_rmleaves-20140110.tar.gz) = 3167
+SHA256 (pkg_rmleaves-20140222.tar.gz) = 2b2f7e19c96d885dab2c36bf2fdbdd30c9529a40ac3a77bda1d5fb1f7690c4a3
+SIZE (pkg_rmleaves-20140222.tar.gz) = 3179
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 7 Jason E. Hale freebsd_committer freebsd_triage 2014-02-23 01:53:32 UTC
State Changed
From-To: feedback->closed

Maintainer submitted ports/186964 to fix the issue.  Committed in 
r345688.