New port to provide a programmatic interface to Sonos speakers. This is my first port, but I've followed the porters handbook and ports of other python modules. portlint is clean and installs and deinstalls on a freshly installed system without difficulty.
Responsible Changed From-To: freebsd-ports-bugs->freebsd-python freebsd-python@ wants this port PRs (via the GNATS Auto Assign Tool)
Responsible Changed From-To: freebsd-python->koobs I'll take it.
Thanks for your submission Conall, and especially for proactively referencing the Porters Handbook and other examples. What a great first port! In return for the time and effort you put in, here's a review that I hope helps you for future contributions: * No need to prefix PORTNAME (py-), use PYTHON_PKGNAMEPREFIX Tip: We normally match the upstream (PyPi) name here, lowercased. If the upstream name is pyfoo, then PORTNAME=pyfoo, and the package name ends up pyXY-pyfoo (pyXY is what PYTHON_PKGNAMEPREFIX does). This change affects the distribution filename among other things, so I ran make makesum to update the distinfo. * MASTER_SITES= GITHUB is not needed when USE_GITHUB=yes * Use of spaces for alignment, saw several portlint instances of: FATAL: Makefile: use a tab (not space) after a variable name Tip: Check out portlint's -A, -C and -N flags to test your port for extra syntactical and semantic issues, and other ports conventions * No need to include the name of the software in COMMENT * The upstream requirements.txt file doesn't specify a minimum version of requests, but >=1.1.0 was set in RUN_DEPENDS. You can use >0 to specify *any* version in a *_DEPENDS line. In normal circumstances it is best to match the upstream requirements as closely as possible unless there is a good reason not to do so.
Author: koobs Date: Tue Apr 22 13:54:42 2014 New Revision: 351835 URL: http://svnweb.freebsd.org/changeset/ports/351835 QAT: https://qat.redports.org/buildarchive/r351835/ Log: [NEW PORT] multimedia/py-soco: Python interface to Sonos speakers SoCo (Sonos Controller) is a simple Python class that allows you to programmatically control Sonos speakers. WWW: https://github.com/SoCo/SoCo PR: ports/186993 Submitted by: Conall O'Brien <conall at conall dot net> Added: head/multimedia/py-soco/ head/multimedia/py-soco/Makefile (contents, props changed) head/multimedia/py-soco/distinfo (contents, props changed) head/multimedia/py-soco/pkg-descr (contents, props changed) Modified: head/multimedia/Makefile Modified: head/multimedia/Makefile ============================================================================== --- head/multimedia/Makefile Tue Apr 22 13:41:53 2014 (r351834) +++ head/multimedia/Makefile Tue Apr 22 13:54:42 2014 (r351835) @@ -294,6 +294,7 @@ SUBDIR += py-periscope SUBDIR += py-qt4-multimedia SUBDIR += py-qt4-phonon + SUBDIR += py-soco SUBDIR += py-subliminal SUBDIR += py-tvnamer SUBDIR += pyjama Added: head/multimedia/py-soco/Makefile ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/multimedia/py-soco/Makefile Tue Apr 22 13:54:42 2014 (r351835) @@ -0,0 +1,25 @@ +# $FreeBSD$ + +PORTNAME= soco +PORTVERSION= 0.6 +CATEGORIES= multimedia python +PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} + +MAINTAINER= conall@conall.net +COMMENT= Python library to control Sonos speakers + +LICENSE= MIT + +RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}requests>0:${PORTSDIR}/www/py-requests + +USE_GITHUB= yes +GH_ACCOUNT= SoCo +GH_PROJECT= SoCo +GH_TAGNAME= v${PORTVERSION} +GH_COMMIT= 6640f85 + +USE_PYTHON= 2 +USE_PYDISTUTILS= yes +PYDISTUTILS_AUTOPLIST= yes + +.include <bsd.port.mk> Added: head/multimedia/py-soco/distinfo ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/multimedia/py-soco/distinfo Tue Apr 22 13:54:42 2014 (r351835) @@ -0,0 +1,2 @@ +SHA256 (soco-0.6.tar.gz) = bf70457610ce7483539d1d4a26949c9ba125c4b0a08e7195559b88369f5be21f +SIZE (soco-0.6.tar.gz) = 429086 Added: head/multimedia/py-soco/pkg-descr ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/multimedia/py-soco/pkg-descr Tue Apr 22 13:54:42 2014 (r351835) @@ -0,0 +1,4 @@ +SoCo (Sonos Controller) is a simple Python class that allows you to +programmatically control Sonos speakers. + +WWW: https://github.com/SoCo/SoCo _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed New port added, with minor changes. Thanks Conall!