Bug 187115 - devel/py-gyp-devel: generate Makefile for FreeBSD by default
Summary: devel/py-gyp-devel: generate Makefile for FreeBSD by default
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Daichi GOTO
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-27 16:30 UTC by Thierry Thomas
Modified: 2014-04-16 22:50 UTC (History)
1 user (show)

See Also:


Attachments
py-gyp-devel.diff (698 bytes, patch)
2014-02-27 16:30 UTC, Thierry Thomas
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thierry Thomas freebsd_committer freebsd_triage 2014-02-27 16:30:01 UTC
	By default, Gyp generate Makefile for the OS target "linux";
	change it to "freebsd" (actually OPSYS).

	Since I'm there, support staging.

Fix: Please apply the hereunder patch:
How-To-Repeat: 	Generate a Makefile with conditional target based upon OS
		=> it will use the case for linux.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-02-27 16:30:33 UTC
Responsible Changed
From-To: freebsd-ports-bugs->daichi

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Thierry Thomas freebsd_committer freebsd_triage 2014-02-27 17:55:54 UTC
On thu 27 feb 14 at 17:21:37 +0100, Thierry Thomas <thierry@FreeBSD.org>
 wrote:

> >Description:
> 	By default, Gyp generate Makefile for the OS target "linux";
> 	change it to "freebsd" (actually OPSYS).
> 
> 	Since I'm there, support staging.

Yet better: since we are there, it's possible to initialize the default
compilers with values suitable for the target platform.

Please check this second patch:

--- py-gyp-devel.diff begins here ---
diff -u devel/py-gyp-devel.orig/Makefile devel/py-gyp-devel/Makefile
--- devel/py-gyp-devel.orig/Makefile	2014-01-27 00:00:07.000000000 +0100
+++ devel/py-gyp-devel/Makefile	2014-02-27 18:23:50.000000000 +0100
@@ -3,7 +3,7 @@
 
 PORTNAME=	gyp
 PORTVERSION=	r832
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	devel python
 MASTER_SITES=	http://people.freebsd.org/~daichi/distfiles/
 PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
@@ -15,5 +15,10 @@
 USE_PYDISTUTILS=	yes
 PYDISTUTILS_PKGVERSION=	0.1
 
-NO_STAGE=	yes
-.include <bsd.port.mk>
+.include <bsd.port.pre.mk>
+
+pre-configure:
+	${REINPLACE_CMD} -e 's/linux/${OPSYS:L}/;s|gcc|${CC}|;s|g++|${CXX}|'	\
+		${WRKSRC}/pylib/gyp/generator/make.py
+
+.include <bsd.port.post.mk>
Common subdirectories: devel/py-gyp-devel.orig/files and devel/py-gyp-devel/files
--- py-gyp-devel.diff ends here ---

Best regards,
-- 
Th. Thomas.
Comment 3 dfilter service freebsd_committer freebsd_triage 2014-04-16 22:39:59 UTC
Author: thierry
Date: Wed Apr 16 21:39:54 2014
New Revision: 351421
URL: http://svnweb.freebsd.org/changeset/ports/351421
QAT: https://qat.redports.org/buildarchive/r351421/

Log:
  - Don't generate Makefile for the OS target "linux" but for freebsd;
  
  - Initialize default values for the compilers.
  
  PR:		ports/187115
  Submitted by:	/me
  Approved by:	maintainer's time-out

Modified:
  head/devel/py-gyp-devel/Makefile

Modified: head/devel/py-gyp-devel/Makefile
==============================================================================
--- head/devel/py-gyp-devel/Makefile	Wed Apr 16 21:37:14 2014	(r351420)
+++ head/devel/py-gyp-devel/Makefile	Wed Apr 16 21:39:54 2014	(r351421)
@@ -3,7 +3,7 @@
 
 PORTNAME=	gyp
 PORTVERSION=	r832
-PORTREVISION=	3
+PORTREVISION=	4
 CATEGORIES=	devel python
 MASTER_SITES=	http://people.freebsd.org/~daichi/distfiles/
 PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
@@ -15,4 +15,10 @@ USE_PYTHON=	yes
 USE_PYDISTUTILS=	yes
 PYDISTUTILS_AUTOPLIST=	yes
 
-.include <bsd.port.mk>
+.include <bsd.port.pre.mk>
+
+pre-configure:
+	${REINPLACE_CMD} -e 's/linux/${OPSYS:L}/;s|gcc|${CC}|;s|g++|${CXX}|' \
+	${WRKSRC}/pylib/gyp/generator/make.py
+
+.include <bsd.port.post.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Thierry Thomas freebsd_committer freebsd_triage 2014-06-01 08:07:58 UTC
State Changed
From-To: open->closed


Committed!