Bug 187171 - [maintainer-update] [patch] devel/diffuse: Update Maintainer Mail Address
Summary: [maintainer-update] [patch] devel/diffuse: Update Maintainer Mail Address
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-01 11:10 UTC by Marco Bröder
Modified: 2014-03-03 19:10 UTC (History)
0 users

See Also:


Attachments
file.diff (3.23 KB, patch)
2014-03-01 11:10 UTC, Marco Bröder
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marco Bröder 2014-03-01 11:10:00 UTC
Update maintainer mail address.

Remove DOCS and NLS options from OPTIONS_DEFAULT. They are on by default.

Remove PORT_OPTIONS handling for safe cases, where STAGE already takes care
of it through pkg-plist. But leave it for the special NLS translations
build step, because it is required there.

Rearrange some lines for better readability.

Build tests:
# portlint -C
# make DEVELOPER=yes stage check-orphans package install deinstall clean
# poudriere testport ... on amd64 for head, stable/10, releng/9.2, releng/8.4

Runtime tests:
on stable/10 amd64

Thanks!

Fix: Patch attached with submission follows:
Comment 1 Pawel Pekala freebsd_committer freebsd_triage 2014-03-03 18:39:15 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pawel

I'll take it.
Comment 2 dfilter service freebsd_committer freebsd_triage 2014-03-03 19:00:19 UTC
Author: pawel
Date: Mon Mar  3 19:00:11 2014
New Revision: 346954
URL: http://svnweb.freebsd.org/changeset/ports/346954
QAT: https://qat.redports.org/buildarchive/r346954/

Log:
  - Update maintainer's email address
  - Remove DOCS and NLS options from OPTIONS_DEFAULT. They are on by default.
  - Remove PORT_OPTIONS handling for safe cases, where STAGE already takes care
    of it through pkg-plist. But leave it for the special NLS translations
    build step, because it is required there.
  - Rearrange some lines for better readability.
  
  PR:		ports/187171
  Submitted by:	maintainer

Modified:
  head/devel/diffuse/Makefile

Modified: head/devel/diffuse/Makefile
==============================================================================
--- head/devel/diffuse/Makefile	Mon Mar  3 18:58:14 2014	(r346953)
+++ head/devel/diffuse/Makefile	Mon Mar  3 19:00:11 2014	(r346954)
@@ -1,4 +1,4 @@
-# Created by: Marco Broeder <marco.broeder@gmx.eu>
+# Created by: Marco Broeder <marco.broeder@posteo.eu>
 # $FreeBSD$
 
 PORTNAME=	diffuse
@@ -6,7 +6,7 @@ PORTVERSION=	0.4.7
 CATEGORIES=	devel python
 MASTER_SITES=	SF
 
-MAINTAINER=	marco.broeder@gmx.eu
+MAINTAINER=	marco.broeder@posteo.eu
 COMMENT=	Graphical N-way diff and merge tool written in python
 
 LICENSE=	GPLv2 GPLv3
@@ -20,28 +20,26 @@ USE_GNOME=	pygtk2
 
 CONFLICTS=	tinker-[0-9]*
 
+PORTDATA=	syntax
 PORTDOCS=	AUTHORS ChangeLog ChangeLog_ru README README_ru
 
 OPTIONS_DEFINE=	DATA DOCS MENU NLS
 DATA_DESC=	Enable syntax highlighting support
 MENU_DESC=	Enable a desktop program menu entry
-OPTIONS_DEFAULT=DATA DOCS MENU NLS
+OPTIONS_DEFAULT=DATA MENU
 OPTIONS_SUB=	yes
 MENU_USES=	desktop-file-utils
 NLS_USES=	gettext
 
-.include <bsd.port.options.mk>
-
-.if ${PORT_OPTIONS:MDATA}
-PORTDATA=	syntax
-.endif
-
-.if ${PORT_OPTIONS:MNLS}
 TRANSLATIONS=	cs de es it ja ko pl ru zh_CN
 MANUALS=	cs it ru
-.endif
+
+.include <bsd.port.options.mk>
 
 post-patch:
+	${REINPLACE_CMD} -e 's|/usr/bin/env python|${PYTHON_CMD}|g; \
+		s|../../etc|${PREFIX}/etc|g' ${WRKSRC}/src/usr/bin/${PORTNAME}
+
 .if ${PORT_OPTIONS:MDATA}
 	${REINPLACE_CMD} -e 's|../usr|${PREFIX}|g; s|/etc|${PREFIX}/etc|g' \
 		${WRKSRC}/src/etc/${PORTNAME}rc
@@ -50,35 +48,25 @@ post-patch:
 		import ${PREFIX}|g; s|/etc|${PREFIX}/etc|g' \
 		${WRKSRC}/src/etc/${PORTNAME}rc
 .endif
-	${REINPLACE_CMD} -e 's|/usr/bin/env python|${PYTHON_CMD}|g; \
-		s|../../etc|${PREFIX}/etc|g' ${WRKSRC}/src/usr/bin/${PORTNAME}
 
 do-install:
 	${INSTALL_SCRIPT} ${WRKSRC}/src/usr/bin/${PORTNAME} \
 		${STAGEDIR}${PREFIX}/bin/
 	${INSTALL_DATA} ${WRKSRC}/src/etc/${PORTNAME}rc \
 		${STAGEDIR}${PREFIX}/etc/
-	${INSTALL_MAN} ${WRKSRC}/src/usr/share/man/man1/*.1 \
-		${STAGEDIR}${MANPREFIX}/man/man1/
 
-.if ${PORT_OPTIONS:MDATA}
-	@${MKDIR} ${STAGEDIR}${DATADIR}/${PORTDATA}
+	@${MKDIR} ${STAGEDIR}${DATADIR}
 	(cd ${WRKSRC}/src/usr/share/${PORTNAME} && \
 		${COPYTREE_SHARE} \* ${STAGEDIR}${DATADIR}/)
-.endif
 
-.if ${PORT_OPTIONS:MDOCS}
 	@${MKDIR} ${STAGEDIR}${DOCSDIR}
 	(cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} ${STAGEDIR}${DOCSDIR}/)
-.endif
 
-.if ${PORT_OPTIONS:MMENU}
-	${INSTALL_DATA} ${WRKSRC}/src/usr/share/pixmaps/${PORTNAME}.png \
-		${STAGEDIR}${PREFIX}/share/pixmaps/
 	@${MKDIR} ${STAGEDIR}${DESKTOPDIR}
 	${INSTALL_DATA} ${WRKSRC}/src/usr/share/applications/*.desktop \
 		${STAGEDIR}${DESKTOPDIR}/
-.endif
+	${INSTALL_DATA} ${WRKSRC}/src/usr/share/pixmaps/${PORTNAME}.png \
+		${STAGEDIR}${PREFIX}/share/pixmaps/
 
 .if ${PORT_OPTIONS:MNLS}
 .for x in ${TRANSLATIONS}
@@ -88,11 +76,15 @@ do-install:
 	${INSTALL_DATA} ${WRKSRC}/translations/${x}/*.mo \
 		${STAGEDIR}${PREFIX}/share/locale/${x}/LC_MESSAGES/
 .endfor
+.endif
+
 .for y in ${MANUALS}
 	@${MKDIR} ${STAGEDIR}${MANPREFIX}/man/${y}/man1
 	${INSTALL_MAN} ${WRKSRC}/src/usr/share/man/${y}/man1/*.1 \
 		${STAGEDIR}${MANPREFIX}/man/${y}/man1/
 .endfor
-.endif
+
+	${INSTALL_MAN} ${WRKSRC}/src/usr/share/man/man1/*.1 \
+		${STAGEDIR}${MANPREFIX}/man/man1/
 
 .include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Pawel Pekala freebsd_committer freebsd_triage 2014-03-03 19:00:23 UTC
State Changed
From-To: open->closed

Committed. Thanks!