Bug 187609 - devel/linux-f10-devtools: absolute symlink(s?) break compilation
Summary: devel/linux-f10-devtools: absolute symlink(s?) break compilation
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-15 17:30 UTC by Juergen Lock
Modified: 2014-03-15 21:13 UTC (History)
1 user (show)

See Also:


Attachments
linux-f10-devtools.patch (592 bytes, patch)
2014-03-15 18:42 UTC, Jason W. Bacon
no flags Details | Diff
linux-f10-devtools.patch (592 bytes, patch)
2014-03-15 18:43 UTC, Jason W. Bacon
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Juergen Lock 2014-03-15 17:30:00 UTC
	I just tried to swich my devel/linux_libusb port,

        http://lists.freebsd.org/pipermail/freebsd-usb/2014-March/012832.html

to using devel/linux-f10-devtools instead of
emulators/linux_base-gentoo-stage3, and got a build failure caused
by /compat/linux/usr/lib/gcc/i386-redhat-linux/4.3.2/libgcc_s.so
being an absolute symlink that made the Linux compiler (linker)
pick up the native /lib/libgcc_s.so.1 instead of the Linux one
and bailing out.

Fix: 

Make sure symlinks to Linux libs/objects that have native
counterparts are relative.
How-To-Repeat: 	Try and use /compat/linux/usr/bin/g?cc ...
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-03-15 17:30:03 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2014-03-15 17:30:03 UTC
Maintainer of devel/linux-f10-devtools,

Please note that PR ports/187609 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/187609

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Jason W. Bacon freebsd_committer freebsd_triage 2014-03-15 18:42:49 UTC
Thanks for the heads-up.  That appears to be the only link to an 
absolute pathname.

Patch attached.

     JB

-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   Jason W. Bacon
   jwbacon@tds.net

   Circumstances don't make a man:
   They reveal him.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Comment 4 Jason W. Bacon freebsd_committer freebsd_triage 2014-03-15 18:43:38 UTC
Patch attached.

-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   Jason W. Bacon
   jwbacon@tds.net

   Circumstances don't make a man:
   They reveal him.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Comment 5 dfilter service freebsd_committer freebsd_triage 2014-03-15 20:57:25 UTC
Author: nox
Date: Sat Mar 15 20:57:21 2014
New Revision: 348379
URL: http://svnweb.freebsd.org/changeset/ports/348379
QAT: https://qat.redports.org/buildarchive/r348379/

Log:
  - Fix absolute symlink that made Linux linker pick up native lib.
    (and fail)
  - Bump PORTREVISION.
  
  PR:		ports/187609
  Submitted by:	nox (self, PR),
  Submitted by:	Jason Bacon <jwbacon@tds.net> (maintainer, fix)

Modified:
  head/devel/linux-f10-devtools/Makefile

Modified: head/devel/linux-f10-devtools/Makefile
==============================================================================
--- head/devel/linux-f10-devtools/Makefile	Sat Mar 15 20:55:33 2014	(r348378)
+++ head/devel/linux-f10-devtools/Makefile	Sat Mar 15 20:57:21 2014	(r348379)
@@ -3,6 +3,7 @@
 
 PORTNAME=	devtools
 PORTVERSION=	10
+PORTREVISION=	1
 CATEGORIES=	devel
 MASTER_SITES=	http://archives.fedoraproject.org/pub/archive/fedora/linux/updates/${PORTVERSION}/${LINUX_RPM_ARCH}/ \
 		http://archives.fedoraproject.org/pub/archive/fedora/linux/releases/${PORTVERSION}/Fedora/${LINUX_RPM_ARCH}/os/Packages/
@@ -42,4 +43,9 @@ USE_LDCONFIG=	yes
 
 PLIST_SUB+=	NLS=""
 
+# Replace link to absolute path /lib/libgcc_s.so.1, which is a FreeBSD lib
+post-install:
+	${RM} ${STAGEDIR}/compat/linux/usr/lib/gcc/i386-redhat-linux/4.3.2/libgcc_s.so
+	${LN} -s ../../../../../lib/libgcc_s.so.1 ${STAGEDIR}/compat/linux/usr/lib/gcc/i386-redhat-linux/4.3.2/libgcc_s.so
+
 .include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 Juergen Lock freebsd_committer freebsd_triage 2014-03-15 20:58:14 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!