Bug 187640 - [patch] update games/sl and remove nkf dependency
Summary: [patch] update games/sl and remove nkf dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Adam Weinberger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-16 20:40 UTC by Adam Weinberger
Modified: 2014-04-25 00:40 UTC (History)
0 users

See Also:


Attachments
sl.patch (4.48 KB, patch)
2014-03-16 20:40 UTC, Adam Weinberger
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Weinberger freebsd_committer freebsd_triage 2014-03-16 20:40:00 UTC
The attached patch updates to the latest version in git (by the same guy
who wrote the original version). It also drops the old-style WITH_... and
avoids the need for japanese/nkf. Also it adds STAGE support.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-03-16 20:40:03 UTC
Maintainer of games/sl,

Please note that PR ports/187640 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/187640

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2014-03-16 20:40:04 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Adam Weinberger freebsd_committer freebsd_triage 2014-03-16 20:41:38 UTC
Responsible Changed
From-To: freebsd-ports-bugs->adamw

Take.
Comment 4 dfilter service freebsd_committer freebsd_triage 2014-04-25 00:34:43 UTC
Author: adamw
Date: Thu Apr 24 23:34:39 2014
New Revision: 352079
URL: http://svnweb.freebsd.org/changeset/ports/352079
QAT: https://qat.redports.org/buildarchive/r352079/

Log:
  Update to version 5.01. Use upstream's new github account.
  This removes the japanese/nkf dependency. Also STAGE and such.
  
  PR:		ports/187640
  Approved by:	maintainer timeout

Deleted:
  head/games/sl/pkg-plist
Modified:
  head/games/sl/Makefile
  head/games/sl/distinfo
  head/games/sl/files/patch-sl.c

Modified: head/games/sl/Makefile
==============================================================================
--- head/games/sl/Makefile	Thu Apr 24 23:18:26 2014	(r352078)
+++ head/games/sl/Makefile	Thu Apr 24 23:34:39 2014	(r352079)
@@ -2,48 +2,29 @@
 # $FreeBSD$
 
 PORTNAME=	sl
-PORTVERSION=	3.03${SLPATCHVERSION}
+PORTVERSION=5.01
 CATEGORIES=	games
-MASTER_SITES=	http://www.tkl.iis.u-tokyo.ac.jp/~toyoda/sl/
-DISTNAME=	${PORTNAME}
-EXTRACT_SUFX=	.tar
-
-.if defined(WITH_PERSISTENT)
-SLPATCHVERSION=	.5p1
-PATCH_SITES=	http://www.izumix.org.uk/sl/ \
-		http://www.SpringDaemons.com/stas/
-PATCHFILES=	sl5-1.patch
-PATCH_DIST_STRIP=	-p1
-.endif
 
 MAINTAINER=	hym@cocoa.freemail.ne.jp
 COMMENT=	A steam locomotive runs across the screen if you type "sl" instead of "ls"
 
-BUILD_DEPENDS=	nkf:${PORTSDIR}/japanese/nkf
+USE_GITHUB=	yes
+GH_ACCOUNT=	mtoyoda
+GH_COMMIT=	5891c2d
 
-ALL_TARGET=	sl
-MAN1=		sl.1
-MANLANG=	ja
-
-NO_STAGE=	yes
-pre-everything::
-.if !defined(WITH_PERSISTENT)
-	@${ECHO_MSG}
-	@${ECHO_MSG} " If you want to apply additional patch to make sl more annoying,"
-	@${ECHO_MSG} " hit Ctrl-C right now and use \"make WITH_PERSISTENT=yes\""
-	@${ECHO_MSG}
-.endif
+PLIST_FILES=bin/${PORTNAME} man/man1/${PORTNAME}.1.gz man/ja/man1/${PORTNAME}.1.gz
+PORTDOCS=	*
 
 do-build:
-	@${CC} ${CFLAGS} -I${WRKSRC} -o ${WRKSRC}/sl ${WRKSRC}/sl.c -lcurses -ltermcap
+	${CC} ${CFLAGS} -I${WRKSRC} -o ${WRKSRC}/sl ${WRKSRC}/sl.c -lncurses
 
 do-install:
-	${INSTALL_PROGRAM} ${WRKSRC}/sl ${PREFIX}/bin
-	${MV} ${WRKSRC}/sl.1 ${WRKSRC}/sl.man
-	nkf -e ${WRKSRC}/sl.man > ${WRKSRC}/sl.1
-	${INSTALL_MAN} ${WRKSRC}/sl.1 ${PREFIX}/man/ja/man1
-	${MKDIR} ${PREFIX}/share/doc/sl
-	${INSTALL_DATA} ${WRKSRC}/README ${PREFIX}/share/doc/sl
-	${INSTALL_DATA} ${WRKSRC}/sl.txt ${PREFIX}/share/doc/sl
+	${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${STAGEDIR}${PREFIX}/bin
+	${INSTALL_MAN} ${WRKSRC}/${PORTNAME}.1 ${STAGEDIR}${MANPREFIX}/man/man1
+	${INSTALL_MAN} ${WRKSRC}/${PORTNAME}.1.ja ${STAGEDIR}${MANPREFIX}/man/ja/man1/${PORTNAME}.1
+	@${MKDIR} ${STAGEDIR}${DOCSDIR}
+.for f in README.md README.ja.md LICENSE
+	${INSTALL_DATA} ${WRKSRC}/$f ${STAGEDIR}${DOCSDIR}
+.endfor
 
 .include <bsd.port.mk>

Modified: head/games/sl/distinfo
==============================================================================
--- head/games/sl/distinfo	Thu Apr 24 23:18:26 2014	(r352078)
+++ head/games/sl/distinfo	Thu Apr 24 23:34:39 2014	(r352079)
@@ -1,4 +1,2 @@
-SHA256 (sl.tar) = b2bcbd86acf2017c84b6aaf6161b3b24f97e34a2d70ab0204c9503f5d50965f4
-SIZE (sl.tar) = 20480
-SHA256 (sl5-1.patch) = 4943b6f000f518ed08755b36d9b753291989c4867e55d74bc4cc4502f6e9422f
-SIZE (sl5-1.patch) = 36035
+SHA256 (sl-5.01.tar.gz) = 5619fe87e3a3135126ca2a83bf47904fff2448ad57aec6f2d2017716488d3bf4
+SIZE (sl-5.01.tar.gz) = 5259

Modified: head/games/sl/files/patch-sl.c
==============================================================================
--- head/games/sl/files/patch-sl.c	Thu Apr 24 23:18:26 2014	(r352078)
+++ head/games/sl/files/patch-sl.c	Thu Apr 24 23:34:39 2014	(r352079)
@@ -1,27 +1,19 @@
---- sl.c.orig	1998-07-22 16:01:01.000000000 +0200
-+++ sl.c	2011-11-01 18:53:45.000000000 +0100
-@@ -32,6 +32,11 @@
+--- sl.c.orig	2014-01-04 00:18:33.000000000 -0500
++++ sl.c	2014-03-16 16:16:47.000000000 -0400
+@@ -37,6 +37,12 @@
  #include <unistd.h>
  #include "sl.h"
  
-+void add_man(int, int);
-+int add_D51(int);
 +int add_sl(int);
-+void add_smoke(int,int);
++int add_C51(int);
++int add_D51(int);
++void add_man(int, int);
++void add_smoke(int, int);
 +
  int ACCIDENT  = 0;
  int LOGO      = 0;
  int FLY       = 0;
-@@ -59,7 +64,7 @@
-     }
- }
- 
--void main(int argc, char *argv[])
-+int main(int argc, char *argv[])
- {
-     int x, i;
- 
-@@ -85,6 +90,8 @@
+@@ -99,6 +105,8 @@
      }
      mvcur(0, COLS - 1, LINES - 1, 0);
      endwin();
@@ -30,7 +22,7 @@
  }
  
  
-@@ -129,7 +136,7 @@
+@@ -143,7 +151,7 @@
  }
  
  
@@ -39,7 +31,16 @@
  {
      static char *d51[D51PATTERNS][D51HIGHT + 1]
  	= {{D51STR1, D51STR2, D51STR3, D51STR4, D51STR5, D51STR6, D51STR7,
-@@ -170,7 +177,7 @@
+@@ -183,7 +191,7 @@
+     return OK;
+ }
+ 
+-add_C51(int x)
++int add_C51(int x)
+ {
+     static char *c51[C51PATTERNS][C51HIGHT + 1]
+ 	= {{C51STR1, C51STR2, C51STR3, C51STR4, C51STR5, C51STR6, C51STR7,
+@@ -224,7 +232,7 @@
  }
  
  
@@ -48,7 +49,7 @@
  {
      static char *man[2][2] = {{"", "(O)"}, {"Help!", "\\O/"}};
      int i;
-@@ -181,7 +188,7 @@
+@@ -235,7 +243,7 @@
  }
  
  
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Adam Weinberger freebsd_committer freebsd_triage 2014-04-25 00:35:15 UTC
State Changed
From-To: feedback->closed

I'm taking your silence as approval of these changes, and this 
patch was committed with minor changes.