Bug 187684 - [MAINTAINER] emulators/tiemu3: Staging support, OPTIONS helpers
Summary: [MAINTAINER] emulators/tiemu3: Staging support, OPTIONS helpers
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Tijl Coosemans
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-17 23:50 UTC by Naram Qashat
Modified: 2014-03-25 17:32 UTC (History)
0 users

See Also:


Attachments
tiemu3-3.03.patch (1.54 KB, patch)
2014-03-17 23:50 UTC, Naram Qashat
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Naram Qashat 2014-03-17 23:50:01 UTC
- Staging support.
- Use OPTIONS helpers.

Generated with FreeBSD Port Tools 1.00.2014.03.11 (mode: change, diff: SVN)
Comment 1 Tijl Coosemans freebsd_committer freebsd_triage 2014-03-18 17:17:54 UTC
Responsible Changed
From-To: freebsd-ports-bugs->tijl

Take.
Comment 2 Tijl Coosemans freebsd_committer freebsd_triage 2014-03-19 10:38:42 UTC
Hi,

This patch causes build errors:
https://redports.org/buildarchive/20140318172200-38897/

Can you check that pkg-plist is correct?
Comment 3 Naram Qashat 2014-03-24 02:38:52 UTC
I'm surprised at the install error, because I don't get that here when I build 
it. I do have share/tiemu/glade/dbg_bits-2.glade in the pkg-plist, but the path 
of the file failing to be found is much different. I don't know enough about 
glade files to know why this is, though.

Thanks,
Naram Qashat
Comment 4 Tijl Coosemans freebsd_committer freebsd_triage 2014-03-25 17:27:16 UTC
On Sun, 23 Mar 2014 22:38:52 -0400 Naram Qashat wrote:
> I'm surprised at the install error, because I don't get that here when I build 
> it. I do have share/tiemu/glade/dbg_bits-2.glade in the pkg-plist, but the path 
> of the file failing to be found is much different. I don't know enough about 
> glade files to know why this is, though.

Hmm, your patch is correct but it got misapplied here for some reason.  I'll
commit it shortly.
Comment 5 dfilter service freebsd_committer freebsd_triage 2014-03-25 17:29:00 UTC
Author: tijl
Date: Tue Mar 25 17:28:57 2014
New Revision: 349163
URL: http://svnweb.freebsd.org/changeset/ports/349163
QAT: https://qat.redports.org/buildarchive/r349163/

Log:
  - New LIB_DEPENDS syntax.
  - Use option helpers.
  - Staging.
  
  PR:		ports/187684
  Submitted by:	Naram Qashat <cyberbotx@cyberbotx.com> (maintainer)

Modified:
  head/emulators/tiemu3/Makefile
  head/emulators/tiemu3/pkg-plist

Modified: head/emulators/tiemu3/Makefile
==============================================================================
--- head/emulators/tiemu3/Makefile	Tue Mar 25 17:25:17 2014	(r349162)
+++ head/emulators/tiemu3/Makefile	Tue Mar 25 17:28:57 2014	(r349163)
@@ -12,9 +12,9 @@ EXTRACT_SUFX=	-nogdb.tar.gz
 MAINTAINER=	cyberbotx@cyberbotx.com
 COMMENT=	TI89(ti)/92(+)/V200 hand-helds emulator
 
-LIB_DEPENDS=	ticalcs2:${PORTSDIR}/comms/libticalcs2 \
-		ticables2:${PORTSDIR}/comms/libticables2 \
-		tifiles2:${PORTSDIR}/devel/libtifiles2
+LIB_DEPENDS=	libticalcs2.so:${PORTSDIR}/comms/libticalcs2 \
+		libticables2.so:${PORTSDIR}/comms/libticables2 \
+		libtifiles2.so:${PORTSDIR}/devel/libtifiles2
 
 USES=		gmake pkgconfig
 USE_AUTOTOOLS=	libtool
@@ -23,25 +23,13 @@ USE_SDL=	sdl
 
 CPPFLAGS+=	-I${LOCALBASE}/include
 LDFLAGS+=	-L${LOCALBASE}/lib -export-dynamic
-CONFIGURE_ARGS=	--disable-gdb
-
-MAN1=		tiemu.1
-
-NO_STAGE=	yes
+CONFIGURE_ARGS=	--disable-gdb --without-kde
 
 OPTIONS_DEFINE=	NLS
+OPTIONS_SUB=	yes
 
-.include <bsd.port.options.mk>
-
-.if ${PORT_OPTIONS:MNLS}
-USES+=		gettext
-PLIST_SUB=	NLS=""
-.else
-CONFIGURE_ARGS+=	--disable-nls
-PLIST_SUB=	NLS="@comment "
-.endif
-
-CONFIGURE_ARGS+=	--without-kde
+NLS_USES=	gettext
+NLS_CONFIGURE_ENABLE=	nls
 
 post-patch: .SILENT
 	${REINPLACE_CMD} -E 's,(install-data-am:).*$$,\1,' ${WRKSRC}/Makefile.in

Modified: head/emulators/tiemu3/pkg-plist
==============================================================================
--- head/emulators/tiemu3/pkg-plist	Tue Mar 25 17:25:17 2014	(r349162)
+++ head/emulators/tiemu3/pkg-plist	Tue Mar 25 17:28:57 2014	(r349163)
@@ -1,4 +1,5 @@
 bin/tiemu
+man/man1/tiemu.1.gz
 %%NLS%%share/locale/fr/LC_MESSAGES/tiemu.mo
 share/tiemu/Manpage.txt
 share/tiemu/glade/calc-2.glade
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 Tijl Coosemans freebsd_committer freebsd_triage 2014-03-25 17:31:22 UTC
State Changed
From-To: open->closed

Committed in r349163.